From: Krzysztof Kozlowski <krzk@kernel.org>
To: Catalin Popescu <catalin.popescu@leica-geosystems.com>,
lgirdwood@gmail.com, broonie@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, shenghao-ding@ti.com,
kevin-lu@ti.com, baojun.xu@ti.com, perex@perex.cz,
tiwai@suse.com, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com
Cc: linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, m.felsch@pengutronix.de,
bsp-development.geo@leica-geosystems.com
Subject: Re: [PATCH next 2/3] ASoC: tas2781: fix reset-gpio polarity
Date: Thu, 3 Jul 2025 10:03:44 +0200 [thread overview]
Message-ID: <1e08ec21-e863-4720-8604-df0640624a83@kernel.org> (raw)
In-Reply-To: <20250703075037.2558549-2-catalin.popescu@leica-geosystems.com>
On 03/07/2025 09:50, Catalin Popescu wrote:
> Both TAS2563 & TAS2781 have an active low reset, yet the driver assumes
> an active high reset. Hence, in order to get the chip out of reset we
> need to lie to the devicetree about the reset polarity. The patch fixes
> the driver so it could work no matter the polarity and leaves it to the
> devicetree to define the correct polarity.
>
> Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com>
This breaks all existing in-tree and out-tree users.
DTS patches are independent, so you cannot fix in-tree that way. Anyway,
you cannot fix other users, so sorry, you are stuck with this or you
need some tricks (I once did for a qcom codec, but I don't know if this
is really the solution and my case was easier about the users).
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-03 8:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-03 7:50 [PATCH next 1/3] ASoC: dt-bindings: tas2781: fix reset polarity Catalin Popescu
2025-07-03 7:50 ` [PATCH next 2/3] ASoC: tas2781: fix reset-gpio polarity Catalin Popescu
2025-07-03 8:03 ` Krzysztof Kozlowski [this message]
2025-07-03 12:29 ` POPESCU Catalin
2025-07-03 7:50 ` [PATCH next 3/3] dts: arm64: mediatek: mt8188: fix audio amplifier reset polarity Catalin Popescu
2025-07-03 8:04 ` [PATCH next 1/3] ASoC: dt-bindings: tas2781: fix " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e08ec21-e863-4720-8604-df0640624a83@kernel.org \
--to=krzk@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=bsp-development.geo@leica-geosystems.com \
--cc=catalin.popescu@leica-geosystems.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kevin-lu@ti.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=matthias.bgg@gmail.com \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=shenghao-ding@ti.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.