From: George Dunlap <george.dunlap@eu.citrix.com>
To: xen-devel@lists.xensource.com
Cc: george.dunlap@eu.citrix.com
Subject: [PATCH 3 of 3] libxl: Warn that /usr/bin/pygrub is deprecated
Date: Thu, 26 Apr 2012 15:26:14 +0100 [thread overview]
Message-ID: <1e09187be21dc9e7e6aa.1335450374@kodo2> (raw)
In-Reply-To: <patchbomb.1335450371@kodo2>
Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
diff -r 2783a97c5d5d -r 1e09187be21d tools/libxl/libxl_bootloader.c
--- a/tools/libxl/libxl_bootloader.c Thu Apr 26 15:23:56 2012 +0100
+++ b/tools/libxl/libxl_bootloader.c Thu Apr 26 15:23:56 2012 +0100
@@ -15,6 +15,7 @@
#include "libxl_osdeps.h" /* must come before any other headers */
#include <termios.h>
+#include <string.h>
#include "libxl_internal.h"
@@ -398,6 +399,11 @@ int libxl_run_bootloader(libxl_ctx *ctx,
goto out_close;
}
+ if ( !strncmp(info->u.pv.bootloader, "/usr/bin/pygrub", 20) )
+ LIBXL__LOG(ctx, LIBXL__LOG_WARNING,
+ "WARNING: bootloader='/usr/bin/pygrub' " \
+ "is deprecated; use bootloader='pygrub' instead");
+
bootloader = libxl__abs_path(gc, info->u.pv.bootloader,
libxl__libexec_path());
if ( bootloader == NULL ) {
prev parent reply other threads:[~2012-04-26 14:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-26 14:26 [PATCH 0 of 3] tools: Move bootloaders to libexec directory George Dunlap
2012-04-26 14:26 ` [PATCH 1 of 3] libxl: Look for bootloader in libexec path George Dunlap
2012-04-26 14:26 ` [PATCH 2 of 3] tools: Install pv bootloaders in libexec rather than /usr/bin George Dunlap
2012-04-26 14:26 ` George Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e09187be21dc9e7e6aa.1335450374@kodo2 \
--to=george.dunlap@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.