From: Richard Henderson <rth@twiddle.net>
To: jiang.biao2@zte.com.cn
Cc: aurelien@aurel32.net, qemu-devel@nongnu.org, zhong.weidong@zte.com.cn
Subject: Re: [Qemu-devel] [PATCH] tcg/mips: make some functions inline.
Date: Thu, 2 Nov 2017 12:43:16 +0100 [thread overview]
Message-ID: <1e17a8cf-e81e-91ba-5656-e8e2dfa3baea@twiddle.net> (raw)
In-Reply-To: <201711021923504024201@zte.com.cn>
On 11/02/2017 12:23 PM, jiang.biao2@zte.com.cn wrote:
> No, :) Just found some of these functions are inline and others are not when reading
> the code, the style looks inconsistent.
My preference would be to remove them all.
> Besides, The compiler may make default inline choices for some functions, but may
> not for some cases(some longer ones). Adding inline manually can guarantee and
> not hurt. :)
The longer ones in particular should *not* be inline, so that we don't expand
the size of the code unnecessarily. Which *can* hurt.
r~
next prev parent reply other threads:[~2017-11-02 11:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 10:26 [Qemu-devel] [PATCH] tcg/mips: make some functions inline Jiang Biao
2017-11-02 10:53 ` Richard Henderson
2017-11-02 11:23 ` jiang.biao2
2017-11-02 11:43 ` Richard Henderson [this message]
2017-11-02 12:16 ` Philippe Mathieu-Daudé
2017-11-03 0:37 ` jiang.biao2
2017-11-03 8:42 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e17a8cf-e81e-91ba-5656-e8e2dfa3baea@twiddle.net \
--to=rth@twiddle.net \
--cc=aurelien@aurel32.net \
--cc=jiang.biao2@zte.com.cn \
--cc=qemu-devel@nongnu.org \
--cc=zhong.weidong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.