From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org
Cc: wangyanan55@huawei.com, pbonzini@redhat.com, thuth@redhat.com
Subject: Re: [PATCH] machine: do not crash if default RAM backend name has been stollen
Date: Mon, 22 May 2023 15:33:16 +0200 [thread overview]
Message-ID: <1e1c53d7-227a-dfcd-c76f-da02027edde7@linaro.org> (raw)
In-Reply-To: <20230522131717.3780533-1-imammedo@redhat.com>
On 22/5/23 15:17, Igor Mammedov wrote:
> QEMU aborts when default RAM backend should be used (i.e. no
> explicit '-machine memory-backend=' specified) but user
> has created an object which 'id' equals to default RAM backend
> name used by board.
>
> $QEMU -machine pc \
> -object memory-backend-ram,id=pc.ram,size=4294967296
>
> Actual results:
> QEMU 7.2.0 monitor - type 'help' for more information
> (qemu) Unexpected error in object_property_try_add() at ../qom/object.c:1239:
> qemu-kvm: attempt to add duplicate property 'pc.ram' to object (type 'container')
> Aborted (core dumped)
>
> Instead of abort, check for the conflicting 'id' and exit with
> an error, suggesting how to remedy the issue.
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> CC: thuth@redhat.com
> ---
> hw/core/machine.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-05-22 13:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 13:17 [PATCH] machine: do not crash if default RAM backend name has been stollen Igor Mammedov
2023-05-22 13:33 ` Philippe Mathieu-Daudé [this message]
2023-05-23 9:10 ` Shaoqin Huang
2023-05-23 12:31 ` The madness of ad hoc special IDs (was: [PATCH] machine: do not crash if default RAM backend name has been stollen) Markus Armbruster
2023-05-23 12:56 ` Igor Mammedov
2023-05-27 7:45 ` The madness of ad hoc special IDs Markus Armbruster
2023-05-23 13:06 ` The madness of ad hoc special IDs (was: [PATCH] machine: do not crash if default RAM backend name has been stollen) Thomas Huth
2023-05-27 7:22 ` The madness of ad hoc special IDs Markus Armbruster
2023-05-27 7:59 ` Markus Armbruster
2023-05-23 13:16 ` [PATCH] machine: do not crash if default RAM backend name has been stollen Thomas Huth
2023-06-09 14:06 ` Igor Mammedov
2023-06-10 20:47 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e1c53d7-227a-dfcd-c76f-da02027edde7@linaro.org \
--to=philmd@linaro.org \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.