All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurentiu Mihalcea <laurentiumihalcea111@gmail.com>
To: Frank Li <Frank.li@nxp.com>
Cc: Bard Liao <yung-chuan.liao@linux.intel.com>,
	Daniel Baluta <daniel.baluta@nxp.com>,
	Iuliana Prodan <iuliana.prodan@nxp.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Mark Brown <broonie@kernel.org>,
	linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
	imx@lists.linux.dev
Subject: Re: [PATCH 8/9] ASoC: SOF: imx: merge imx8 and imx8ulp drivers
Date: Tue, 4 Feb 2025 18:46:15 +0200	[thread overview]
Message-ID: <1e228234-96eb-4482-bc35-343ed42af746@gmail.com> (raw)
In-Reply-To: <Z6EhvHXeNJPW1Cwh@lizhi-Precision-Tower-5810>


(snip)

>>  IMX_SOF_DEV_DESC(imx8, sof_imx8_machs, &imx8_chip_info, &sof_imx8_ops, imx_ops_init);
>>  IMX_SOF_DEV_DESC(imx8x, sof_imx8_machs, &imx8x_chip_info, &sof_imx8_ops, imx_ops_init);
>>  IMX_SOF_DEV_DESC(imx8m, sof_imx8_machs, &imx8m_chip_info, &sof_imx8_ops, imx_ops_init);
>> +IMX_SOF_DEV_DESC(imx8ulp, sof_imx8_machs, &imx8ulp_chip_info, &sof_imx8_ops, imx_ops_init);
>>
>>  static const struct of_device_id sof_of_imx8_ids[] = {
>>  	{
>> @@ -339,6 +448,10 @@ static const struct of_device_id sof_of_imx8_ids[] = {
>>  		.compatible = "fsl,imx8mp-dsp",
>>  		.data = &IMX_SOF_DEV_DESC_NAME(imx8m),
>>  	},
>> +	{
>> +		.compatible = "fsl,imx8ulp-dsp",
>> +		.data = &IMX_SOF_DEV_DESC_NAME(imx8ulp),
>> +	},
> Can you put imx8ulp_dai into driver data to avoid of_device_is_compatible()
> logic?
>
> Frank

should be able to add it to "struct imx_chip_info"


  reply	other threads:[~2025-02-04 16:46 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-03 17:17 [PATCH 0/9] Refactor imx drivers and introduce support for imx95 Laurentiu Mihalcea
2025-02-03 17:18 ` [PATCH 1/9] ASoC: SOF: imx: introduce more common structures and functions Laurentiu Mihalcea
2025-02-03 19:52   ` Frank Li
2025-02-04 16:59     ` Laurentiu Mihalcea
2025-02-04 17:15       ` Mark Brown
2025-02-05 16:10       ` Frank Li
2025-02-05 18:58         ` Laurentiu Mihalcea
2025-02-03 17:18 ` [PATCH 2/9] ASoC: SOF: imx8: use common imx chip interface Laurentiu Mihalcea
2025-02-03 17:18 ` [PATCH 3/9] ASoC: SOF: imx8: use IMX_SOF_* macros Laurentiu Mihalcea
2025-02-03 17:18 ` [PATCH 4/9] ASoC: SOF: imx8: shuffle structure and function definitions Laurentiu Mihalcea
2025-02-03 17:18 ` [PATCH 5/9] ASoC: SOF: imx8: drop unneeded/unused macros/header includes Laurentiu Mihalcea
2025-02-03 17:18 ` [PATCH 6/9] ASoC: SOF: imx8: make imx8_ops_init() an util function Laurentiu Mihalcea
2025-02-03 17:18 ` [PATCH 7/9] ASoC: SOF: imx: merge imx8 and imx8m drivers Laurentiu Mihalcea
2025-02-03 17:18 ` [PATCH 8/9] ASoC: SOF: imx: merge imx8 and imx8ulp drivers Laurentiu Mihalcea
2025-02-03 20:06   ` Frank Li
2025-02-04 16:46     ` Laurentiu Mihalcea [this message]
2025-02-05 16:12       ` Frank Li
2025-02-03 17:18 ` [PATCH 9/9] ASoC: SOF: imx: add driver for the imx95 chip Laurentiu Mihalcea
2025-02-10 16:29 ` [PATCH 0/9] Refactor imx drivers and introduce support for imx95 Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1e228234-96eb-4482-bc35-343ed42af746@gmail.com \
    --to=laurentiumihalcea111@gmail.com \
    --cc=Frank.li@nxp.com \
    --cc=broonie@kernel.org \
    --cc=daniel.baluta@nxp.com \
    --cc=imx@lists.linux.dev \
    --cc=iuliana.prodan@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.