From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "yilun.xu@linux.intel.com" <yilun.xu@linux.intel.com>
Cc: "Gao, Chao" <chao.gao@intel.com>,
"Hansen, Dave" <dave.hansen@intel.com>,
"Xu, Yilun" <yilun.xu@intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"kas@kernel.org" <kas@kernel.org>,
"Li, Xiaoyao" <xiaoyao.li@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"djbw@kernel.org" <djbw@kernel.org>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"linux-coco@lists.linux.dev" <linux-coco@lists.linux.dev>,
"Fang, Peter" <peter.fang@intel.com>
Subject: Re: [PATCH v3] x86/virt/tdx: Formalize SEAMCALL version encoding support
Date: Fri, 24 Jul 2026 17:05:43 +0000 [thread overview]
Message-ID: <1e4885e1da81c8a7665bb4d885de62ac61e6063a.camel@intel.com> (raw)
In-Reply-To: <amLYiGOfYJEuYKkY@yilunxu-OptiPlex-7050>
On Fri, 2026-07-24 at 11:14 +0800, Xu Yilun wrote:
> > I guess this works because the __always_inline is enough for the compiler to
> > trace fn to a compile time constant up the callchain. It seems somewhat
> > compiler
> > sensitive though. Did you convince yourself somehow that some compiler will
> > not
> > complain?
>
> I see the previous talk [1][2], that existing __seamcall*() rely on the
> direct call, though there is no guarantee. We accept the assumption
> until there is compiler issue. So I think this doesn't add more problem.
>
> [1]
> https://lore.kernel.org/lkml/20250605145914.GW39944@noisy.programming.kicks-ass.net/
> [2] 0b3bc018e86a ("x86/virt/tdx: Avoid indirect calls to TDX assembly
> function")
Oh, right. It is one more layer of function it has to track it through compared
to that case, but LGTM.
next prev parent reply other threads:[~2026-07-24 17:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 8:46 [PATCH v3] x86/virt/tdx: Formalize SEAMCALL version encoding support Xu Yilun
2026-07-22 11:23 ` Kiryl Shutsemau
2026-07-23 5:43 ` Xu Yilun
2026-07-23 9:35 ` Nikolay Borisov
2026-07-23 18:13 ` Edgecombe, Rick P
2026-07-24 3:14 ` Xu Yilun
2026-07-24 17:05 ` Edgecombe, Rick P [this message]
2026-09-11 19:58 ` Kishen Maloor
2026-09-14 4:58 ` Xu Yilun
2026-09-15 0:18 ` Kishen Maloor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e4885e1da81c8a7665bb4d885de62ac61e6063a.camel@intel.com \
--to=rick.p.edgecombe@intel.com \
--cc=chao.gao@intel.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=djbw@kernel.org \
--cc=kas@kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.fang@intel.com \
--cc=x86@kernel.org \
--cc=xiaoyao.li@intel.com \
--cc=yilun.xu@intel.com \
--cc=yilun.xu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.