Re: [PATCH v4 0/6] Enhance the bond framework to support offload

[Ferruh Yigit <ferruh.yigit@amd.com>]

On 10/18/2023 8:48 AM, Chaoyong He wrote:
> This patch series try to enhance the bond framework to support the
> offload feature better:
> * Add new API to make the member port can access some information of the
>   bond port which belongs.
> * Add new API to get the result of whether bond port is created by the
>   member port.
> * Add two command line argument to control if enable member port
>   notification and dedicated queue features.
> * Add logic to support add ports which share the same PCI address into
>   bond port.
> * Also modify the testpmd application to test the new APIs and logics
>   added by this patch series.
> 
> ---
> v2:
> * Fix compile error on github-robot by removing the redundancy function
>   declaration in the header file.
> v3:
> * Use the hole in the structure for the new added flag data field.
> v4:
> * Drop two commits not necessary for this series.
> * Modify some logic as the review comments from reviewers.
> ---
> 
> Long Wu (6):
>   ethdev: add member notification for bonding port
>   ethdev: add API to get hardware creation of bonding port
>   net/bonding: add bonding port arguments
>   net/bonding: support add port by data name
>   net/bonding: support checking valid bonding port ID
>   net/bonding: add commands for bonding port notification
> 
>  

Hi Chaoyong,

This patchset discussed in the technical board, to be able to discuss in
more details, can you please provide more details in the usecase?

Also there can be a gap on how to test this new additions, again knowing
the intended usecase may help.


There are a few things not ideal in the set, like adding bonding
specific APIs, ethdev additions specific to bonding, port not working on
generic capabilities/configuration approach but app needs to know that
it is bonding port etc ...

I will postpone the patchset to next release, please clarify more the
usecase and we can continue discussions.


Thanks,
ferruh