From: Paul Moore <paul@paul-moore.com>
To: Colin Ian King <colin.i.king@gmail.com>,
James Morris <jmorris@namei.org>,
"Serge E . Hallyn" <serge@hallyn.com>,
linux-security-module@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] security: remove redundant assignment to variable rc
Date: Sat, 04 Jan 2025 21:52:12 -0500 [thread overview]
Message-ID: <1e9b49e3e80d71ab8a34f7d873614908@paul-moore.com> (raw)
In-Reply-To: <20241112124532.468198-1-colin.i.king@gmail.com>
On Nov 12, 2024 Colin Ian King <colin.i.king@gmail.com> wrote:
>
> In the case where rc is equal to EOPNOTSUPP it is being reassigned a
> new value of zero that is never read. The following continue statement
> loops back to the next iteration of the lsm_for_each_hook loop and
> rc is being re-assigned a new value from the call to getselfattr.
> The assignment is redundant and can be removed.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> Reviewed-by: Serge Hallyn <serge@hallyn.com>
> ---
> security/security.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Merged to lsm/dev, thanks.
--
paul-moore.com
prev parent reply other threads:[~2025-01-05 2:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 12:45 [PATCH][next] security: remove redundant assignment to variable rc Colin Ian King
2024-11-12 13:32 ` Serge E. Hallyn
2024-11-12 14:00 ` Dan Carpenter
2025-01-05 2:54 ` Paul Moore
2025-01-05 2:52 ` Paul Moore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e9b49e3e80d71ab8a34f7d873614908@paul-moore.com \
--to=paul@paul-moore.com \
--cc=colin.i.king@gmail.com \
--cc=jmorris@namei.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.