From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Ladislav Michl <ladis@linux-mips.org>, linux-omap@vger.kernel.org
Cc: Lee Jones <lee.jones@linaro.org>,
Tony Lindgren <tony@atomide.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll
Date: Mon, 15 Jan 2018 15:38:43 +0000 [thread overview]
Message-ID: <1ebb5ac5-aa4d-7c19-94db-210b518d562f@users.sourceforge.net> (raw)
In-Reply-To: <20180115134101.GA6711@lenoch>
>> @@ -258,7 +256,6 @@ static int usbtll_omap_probe(struct platform_device *pdev)
>> GFP_KERNEL);
>> if (!tll->ch_clk) {
>> ret = -ENOMEM;
>> - dev_err(dev, "Couldn't allocate memory for channel clocks\n");
>
> I'd either leave this one, just to know which allocation failed or better use
> something like this …
Are you aware on the structure for a Linux allocation failure report?
Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Ladislav Michl <ladis@linux-mips.org>, linux-omap@vger.kernel.org
Cc: Lee Jones <lee.jones@linaro.org>,
Tony Lindgren <tony@atomide.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_probe()
Date: Mon, 15 Jan 2018 16:38:43 +0100 [thread overview]
Message-ID: <1ebb5ac5-aa4d-7c19-94db-210b518d562f@users.sourceforge.net> (raw)
In-Reply-To: <20180115134101.GA6711@lenoch>
>> @@ -258,7 +256,6 @@ static int usbtll_omap_probe(struct platform_device *pdev)
>> GFP_KERNEL);
>> if (!tll->ch_clk) {
>> ret = -ENOMEM;
>> - dev_err(dev, "Couldn't allocate memory for channel clocks\n");
>
> I'd either leave this one, just to know which allocation failed or better use
> something like this …
Are you aware on the structure for a Linux allocation failure report?
Regards,
Markus
next prev parent reply other threads:[~2018-01-15 15:38 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 13:14 [PATCH 0/3] mfd/omap-usb-tll: Adjustments for usbtll_omap_probe() SF Markus Elfring
2018-01-15 13:14 ` SF Markus Elfring
2018-01-15 13:15 ` [PATCH 1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_oma SF Markus Elfring
2018-01-15 13:15 ` [PATCH 1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_probe() SF Markus Elfring
2018-01-15 13:41 ` [PATCH 1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll Ladislav Michl
2018-01-15 13:41 ` [PATCH 1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_probe() Ladislav Michl
2018-01-15 15:34 ` [PATCH 1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll Roger Quadros
2018-01-15 15:34 ` [PATCH 1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_probe() Roger Quadros
2018-01-15 15:34 ` Roger Quadros
2018-01-15 15:38 ` SF Markus Elfring [this message]
2018-01-15 15:38 ` SF Markus Elfring
2018-01-15 16:05 ` [PATCH 1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll Ladislav Michl
2018-01-15 16:05 ` [PATCH 1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_probe() Ladislav Michl
2018-01-15 16:21 ` [1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_ SF Markus Elfring
2018-01-15 16:21 ` [1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_probe() SF Markus Elfring
2018-01-15 16:35 ` [1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_ Ladislav Michl
2018-01-15 16:35 ` [1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_probe() Ladislav Michl
2018-01-15 17:06 ` [1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_ SF Markus Elfring
2018-01-15 17:06 ` [1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_probe() SF Markus Elfring
2018-01-15 17:41 ` [1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_ Ladislav Michl
2018-01-15 17:41 ` [1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_probe() Ladislav Michl
2018-01-15 18:12 ` [1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_ SF Markus Elfring
2018-01-15 18:12 ` [1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_probe() SF Markus Elfring
2018-01-15 18:30 ` [1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_ Ladislav Michl
2018-01-15 18:30 ` [1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_probe() Ladislav Michl
2018-01-15 19:04 ` mfd/omap-usb-tll: Allocate driver data at once " SF Markus Elfring
2018-01-15 19:04 ` SF Markus Elfring
2018-01-15 19:23 ` Ladislav Michl
2018-01-15 19:23 ` Ladislav Michl
2018-01-15 19:40 ` SF Markus Elfring
2018-01-15 19:40 ` SF Markus Elfring
2018-01-15 19:26 ` SF Markus Elfring
2018-01-15 19:26 ` SF Markus Elfring
2018-01-15 19:33 ` Ladislav Michl
2018-01-15 19:33 ` Ladislav Michl
2018-01-15 13:16 ` [PATCH 2/3] mfd/omap-usb-tll: Improve a size determination " SF Markus Elfring
2018-01-15 13:16 ` SF Markus Elfring
2018-01-22 15:50 ` Lee Jones
2018-01-22 15:50 ` Lee Jones
2018-01-15 13:17 ` [PATCH 3/3] mfd/omap-usb-tll: Return an error code only as a constant " SF Markus Elfring
2018-01-15 13:17 ` SF Markus Elfring
2018-01-22 15:50 ` Lee Jones
2018-01-22 15:50 ` Lee Jones
2018-01-23 13:04 ` Lee Jones
2018-01-23 13:04 ` Lee Jones
2018-01-23 14:43 ` [3/3] " SF Markus Elfring
2018-01-23 14:43 ` SF Markus Elfring
2018-01-23 15:04 ` Lee Jones
2018-01-23 17:13 ` Ladislav Michl
2018-01-23 17:13 ` Ladislav Michl
2018-01-24 15:16 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ebb5ac5-aa4d-7c19-94db-210b518d562f@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=ladis@linux-mips.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.