All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ivan Safonov <insafonov@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Jiri Pirko <jiri@resnulli.us>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Lorenzo Bianconi <lorenzo@kernel.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: fix register_netdev description
Date: Mon, 7 Oct 2024 01:00:19 +0300	[thread overview]
Message-ID: <1ebce461-e4eb-4f10-9de8-19240193b262@gmail.com> (raw)
In-Reply-To: <844f8c95-634c-4153-bfab-d6a032677854@lunn.ch>



On 10/7/24 00:16, Andrew Lunn wrote:
> On Sun, Oct 06, 2024 at 08:57:20PM +0300, Ivan Safonov wrote:
>> register_netdev() does not expands the device name.
> 
> Please could you explain what makes you think it will not expand the
> device name.
> 
> 	Andrew

It is the register_netdev implementation:

> int register_netdev(struct net_device *dev)
> {
> 	int err;
> 
> 	if (rtnl_lock_killable())
> 		return -EINTR;
> 	err = register_netdevice(dev);
> 	rtnl_unlock();
> 	return err;
> }

There is no device name expansion, rtnl lock and register_netdevice call 
only. The register_netdevice expands device name using dev_get_valid_name().




  reply	other threads:[~2024-10-06 22:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-06 17:57 [PATCH v2] net: fix register_netdev description Ivan Safonov
2024-10-06 21:16 ` Andrew Lunn
2024-10-06 22:00   ` Ivan Safonov [this message]
2024-10-06 22:48     ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ebce461-e4eb-4f10-9de8-19240193b262@gmail.com \
    --to=insafonov@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=bigeasy@linutronix.de \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.