Re: [PATCH 1/2] mm/hugetlb: extract sysfs into hugetlb_sysfs.c

[hui.zhu@linux.dev]

2025年11月4日 00:28, "David Hildenbrand (Red Hat)" <david@kernel.org mailto:david@kernel.org?to=%22David%20Hildenbrand%20(Red%20Hat)%22%20%3Cdavid%40kernel.org%3E > 写到:


> 
> On 03.11.25 09:22, Hui Zhu wrote:
> 
> > 
> > From: Geliang Tang <geliang@kernel.org>
> >  Currently, hugetlb.c contains both core management logic and sysfs
> >  interface implementations, making it difficult to maintain. This patch
> >  extracts the sysfs-related code into a dedicated file to improve code
> >  organization.
> >  The following components are moved to mm/hugetlb_sysfs.c:
> >  - hugetlb page demote functions (demote_free_hugetlb_folios,
> >  demote_pool_huge_page)
> >  - sysfs attribute definitions and handlers
> >  - sysfs kobject management functions
> >  - NUMA per-node hstate attribute registration
> >  Several inline helper functions and macros are moved to
> >  mm/hugetlb_internal.h:
> >  - hstate_is_gigantic_no_runtime()
> >  - next_node_allowed()
> >  - get_valid_node_allowed()
> >  - hstate_next_node_to_alloc()
> >  - hstate_next_node_to_free()
> >  - for_each_node_mask_to_alloc/to_free macros
> >  To support code sharing, these functions are changed from static to
> >  exported symbols:
> >  - remove_hugetlb_folio()
> >  - add_hugetlb_folio()
> >  - init_new_hugetlb_folio()
> >  - prep_and_add_allocated_folios()
> >  - __nr_hugepages_store_common()
> >  The Makefile is updated to compile hugetlb_sysfs.o when
> >  CONFIG_HUGETLBFS is enabled. This maintains all existing functionality
> >  while improving maintainability by separating concerns.
> >  Signed-off-by: Geliang Tang <geliang@kernel.org>
> >  Signed-off-by: Hui Zhu <zhuhui@kylinos.cn>
> >  ---
> > 
> [...]
> 
> > 
> > index 000000000000..63ab13cfb072
> >  --- /dev/null
> >  +++ b/mm/hugetlb_internal.h
> >  @@ -0,0 +1,110 @@
> >  +// SPDX-License-Identifier: GPL-2.0-only
> >  +/*
> >  + * Internal HugeTLB definitions.
> >  + *
> >  + * Copyright (C) 2025 KylinSoft Corporation.
> >  + * Author: Geliang Tang <geliang@kernel.org>
> >  + */
> > 
> So, you move some code and suddenly have copyright and authored that code.
> 
> Especially given the cove letter says "The code is moved
> as-is, with only minor formatting adjustments for code style
> consistency."
> 
> ?

Thanks for your remind.
Remove the wrong copyright according to your comments.

Best,
Hui

> 
> -- Cheers
> 
> David
>