From: Krzysztof Kozlowski <krzk@kernel.org>
To: Nabige Aala <nabige.aala@oss.qualcomm.com>,
Mahadevan P <mahadevan.p@oss.qualcomm.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Abel Vesa <abelvesa@kernel.org>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/4] drm/bridge: Add a driver for the Parade PS195
Date: Thu, 12 Nov 2026 17:18:07 +0100 [thread overview]
Message-ID: <1eddac06-1a89-4e71-a38f-ceafeb9128c1@kernel.org> (raw)
In-Reply-To: <20261112-mahua-hdmi-v1-2-b463d7b1dd7e@oss.qualcomm.com>
On 12/11/2026 11:15, Nabige Aala wrote:
> + ret = devm_add_action_or_reset(dev, ps195_power_off_action, ps195);
> + if (ret)
> + return ret;
> +
> + /*
> + * Firmware drives DP HPD and services AUX, including EDID reads,
> + * before a modeset. Keep the bridge powered while the system is
> + * awake, including when no monitor is connected.
> + */
> + ret = ps195_power_on(ps195);
First you power on, then you add reset action.
> + if (ret)
> + return ret;
> +
> + ps195->bridge.of_node = dev->of_node;
> + ps195->bridge.type = DRM_MODE_CONNECTOR_HDMIA;
> +
> + return devm_drm_bridge_add(dev, &ps195->bridge);
> +}
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-11-12 16:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 10:15 [PATCH 0/4] Add Parade PS195 bridge support to enable HDMI on Glymur/Mahua/Kalambo CRDs Nabige Aala
2026-11-12 10:15 ` [PATCH 1/4] dt-bindings: display: bridge: Add Parade PS195 Nabige Aala
2026-11-12 16:23 ` Krzysztof Kozlowski
2026-11-12 10:15 ` [PATCH 2/4] drm/bridge: Add a driver for the " Nabige Aala
2026-11-12 16:18 ` Krzysztof Kozlowski [this message]
2026-11-12 10:15 ` [PATCH 3/4] arm64: defconfig: Enable the Parade PS195 bridge Nabige Aala
2026-11-12 16:14 ` Krzysztof Kozlowski
2026-11-12 17:21 ` Krzysztof Kozlowski
2026-11-12 10:15 ` [PATCH 4/4] arm64: dts: qcom: glymur-crd: Enable HDMI output via PS195 Nabige Aala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1eddac06-1a89-4e71-a38f-ceafeb9128c1@kernel.org \
--to=krzk@kernel.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=abelvesa@kernel.org \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=andrzej.hajda@intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mahadevan.p@oss.qualcomm.com \
--cc=mripard@kernel.org \
--cc=nabige.aala@oss.qualcomm.com \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.