From: Xiaoyao Li <xiaoyao.li@intel.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "Cameron Esfahani" <dirty@apple.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, "Roman Bolshakov" <rbolshakov@ddn.com>,
"Mads Ynddal" <mads@ynddal.dk>,
"Phil Dennis-Jordan" <phil@philjordan.eu>,
"Alexander Graf" <agraf@csgraf.de>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH-for-10.1 1/3] accel/hvf: Display executable bit as 'X'
Date: Thu, 17 Jul 2025 21:08:49 +0800 [thread overview]
Message-ID: <1edeecdd-76cf-4baa-97d8-c07df20b4824@intel.com> (raw)
In-Reply-To: <20250716172813.73405-2-philmd@linaro.org>
On 7/17/2025 1:28 AM, Philippe Mathieu-Daudé wrote:
> Developers are custom to read RWX, not RWE.
> Replace E -> X.
>
> Reported-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Xiaoyao Li <xiaoyao.li@intel.com>
> ---
> accel/hvf/hvf-all.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/accel/hvf/hvf-all.c b/accel/hvf/hvf-all.c
> index e67a8105a66..0a4b498e836 100644
> --- a/accel/hvf/hvf-all.c
> +++ b/accel/hvf/hvf-all.c
> @@ -84,7 +84,7 @@ static int do_hvf_set_memory(hvf_slot *slot, hv_memory_flags_t flags)
> trace_hvf_vm_map(slot->start, slot->size, slot->mem, flags,
> flags & HV_MEMORY_READ ? 'R' : '-',
> flags & HV_MEMORY_WRITE ? 'W' : '-',
> - flags & HV_MEMORY_EXEC ? 'E' : '-');
> + flags & HV_MEMORY_EXEC ? 'X' : '-');
> ret = hv_vm_map(slot->mem, slot->start, slot->size, flags);
> assert_hvf_ok(ret);
> return 0;
next prev parent reply other threads:[~2025-07-17 14:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 17:28 [PATCH-for-10.1 0/3] accel/hvf: Do not abort in hvf_arm_get_*_ipa_bit_size() Philippe Mathieu-Daudé
2025-07-16 17:28 ` [PATCH-for-10.1 1/3] accel/hvf: Display executable bit as 'X' Philippe Mathieu-Daudé
2025-07-16 18:12 ` Alex Bennée
2025-07-17 10:09 ` Mads Ynddal
2025-07-17 13:08 ` Xiaoyao Li [this message]
2025-07-17 14:55 ` BALATON Zoltan
2025-07-16 17:28 ` [PATCH-for-10.1 2/3] accel/hvf: Do not abort in hvf_arm_get_*_ipa_bit_size() Philippe Mathieu-Daudé
2025-07-17 10:02 ` Mads Ynddal
2025-07-16 17:28 ` [PATCH-for-10.1 3/3] hw/arm/virt: Warn when HVF doesn't report IPA bit length Philippe Mathieu-Daudé
2025-07-17 10:06 ` Mads Ynddal
2025-07-17 11:15 ` Philippe Mathieu-Daudé
2025-07-17 12:15 ` Mads Ynddal
2025-07-21 10:41 ` Peter Maydell
2025-07-21 12:40 ` [PATCH-for-10.1 0/3] accel/hvf: Do not abort in hvf_arm_get_*_ipa_bit_size() Peter Maydell
2025-07-21 13:14 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1edeecdd-76cf-4baa-97d8-c07df20b4824@intel.com \
--to=xiaoyao.li@intel.com \
--cc=agraf@csgraf.de \
--cc=alex.bennee@linaro.org \
--cc=dirty@apple.com \
--cc=mads@ynddal.dk \
--cc=peter.maydell@linaro.org \
--cc=phil@philjordan.eu \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rbolshakov@ddn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.