All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Olivain via buildroot <buildroot@buildroot.org>
To: Philippe Nunes <nunes.philippe@free.fr>
Cc: buildroot@buildroot.org, Vincent Jardin <vjardin@free.fr>
Subject: Re: [Buildroot] [PATCH v2 1/3] package/mcpp: new package
Date: Sun, 02 Aug 2026 09:30:03 +0200	[thread overview]
Message-ID: <1f145fced560982ff7c7627ba97dfd3f@free.fr> (raw)
In-Reply-To: <20260707161000.629475-2-nunes.philippe@free.fr>

Hi Philippe,

Thanks for the patch. I have a comment, see below.

On 07/07/2026 18:09, Philippe Nunes via buildroot wrote:
> mcpp (Matsui CPP) is a portable C/C++ preprocessor. Builds both
> host and target with --enable-mcpplib, so libmcpp.{a,so} and
> mcpp_lib.h are available to other packages in addition to the
> standalone mcpp(1) CLI.
> 
> Upstream: https://mcpp.sourceforge.net/
> 
> Suggested-by: Vincent Jardin <vjardin@free.fr>
> Signed-off-by: Philippe Nunes <nunes.philippe@free.fr>
> ---
>  DEVELOPERS                                    |  3 +
>  package/Config.in                             |  1 +
>  package/Config.in.host                        |  1 +
>  ...ined-assignment-between-differently-.patch | 36 +++++++++++
>  ...POSIX.1-2008-so-readlink-is-declared.patch | 36 +++++++++++
>  ...ue-false-labels-they-are-reserved-in.patch | 63 +++++++++++++++++++
>  package/mcpp/Config.in                        |  7 +++
>  package/mcpp/Config.in.host                   |  7 +++
>  package/mcpp/mcpp.hash                        |  4 ++
>  package/mcpp/mcpp.mk                          | 19 ++++++
>  10 files changed, 177 insertions(+)
[...]
> diff --git a/package/mcpp/mcpp.mk b/package/mcpp/mcpp.mk
> new file mode 100644
> index 0000000000..04ca6e15df
> --- /dev/null
> +++ b/package/mcpp/mcpp.mk
> @@ -0,0 +1,19 @@
> +################################################################################
> +#
> +# mcpp
> +#
> +################################################################################
> +
> +MCPP_VERSION = 2.7.2
> +MCPP_SITE = 
> https://downloads.sourceforge.net/project/mcpp/mcpp/V.$(MCPP_VERSION)
> +MCPP_LICENSE = BSD-2-Clause
> +MCPP_LICENSE_FILES = LICENSE
> +
> +MCPP_INSTALL_STAGING = YES
> +

On a host with gcc 16 (like Fedora 44), compiling host-mcpp fails.
Using the command "make host-mcpp" produces the errors:

eval.c: In function 'eval_eval':
eval.c:1284:22: error: expected ',' or ';' before 'LL_FORM'
eval.c: In function 'dump_val':
eval.c:1638:51: error: expected ',' or ';' before 'LL_FORM'

You could probably workaround that issue by adding here:

HOST_MCPP_CONF_ENV = CFLAGS="$(HOST_CFLAGS) -std=gnu99"

But I don't really like the idea of introducing this new mcpp
package which has apparently not been maintained for the past
two decades... It already needs 3 patches and has this build
failures.

Is there any other maintained alternatives?

Otherwise, you could eventually fork it and maintain it, to have a
person of contact (e.g. for security and other bugfixes) and to avoid
piling up patches in Buildroot?

> +# builds libmcpp.{a,so} alongside the mcpp CLI
> +MCPP_CONF_OPTS = --enable-mcpplib
> +HOST_MCPP_CONF_OPTS = --enable-mcpplib
> +
> +$(eval $(autotools-package))
> +$(eval $(host-autotools-package))
> --
> 2.54.0

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2026-08-02  7:30 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-01 12:19 [Buildroot] [PATCH 0/3] Add qoriq-rcw C reimplementation + libmcpp dep Philippe Nunes via buildroot
2026-07-01 12:19 ` [Buildroot] [PATCH 1/3] package/mcpp: new package Philippe Nunes via buildroot
2026-07-06  8:23   ` Vincent Jardin via buildroot
2026-07-06 15:49     ` Philippe Nunes via buildroot
2026-07-01 12:19 ` [Buildroot] [PATCH 2/3] package/libqoriq-rcw: " Philippe Nunes via buildroot
2026-07-06  8:19   ` Vincent Jardin via buildroot
2026-07-06 15:56     ` Philippe Nunes via buildroot
2026-07-01 12:19 ` [Buildroot] [PATCH 3/3] package/qoriq-rcw-c: " Philippe Nunes via buildroot
2026-07-06  8:15   ` Vincent Jardin via buildroot
2026-07-06 16:04     ` Philippe Nunes via buildroot
2026-07-07 16:09 ` [Buildroot] [PATCH v2 0/3] Add qoriq-rcw C reimplementation + libmcpp dep Philippe Nunes via buildroot
2026-07-07 16:09   ` [Buildroot] [PATCH v2 1/3] package/mcpp: new package Philippe Nunes via buildroot
2026-08-02  7:30     ` Julien Olivain via buildroot [this message]
2026-07-07 16:09   ` [Buildroot] [PATCH v2 2/3] package/libqoriq-rcw: " Philippe Nunes via buildroot
2026-07-07 16:10   ` [Buildroot] [PATCH v2 3/3] package/qoriq-rcw-c: " Philippe Nunes via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1f145fced560982ff7c7627ba97dfd3f@free.fr \
    --to=buildroot@buildroot.org \
    --cc=ju.o@free.fr \
    --cc=nunes.philippe@free.fr \
    --cc=vjardin@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.