From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 276902DF153 for ; Fri, 24 Jul 2026 00:52:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.97.179.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784854325; cv=none; b=dodsvnvPE+Lm4PikIO97txyFN7h4JKjgvl8/5z8wye/d2CLCXEEznNndALH+xZrUi+Uo22jus9sXW2xaml0449zqD659eSeUtG3DHRruZPz9hdS188/5NWKD8zHCxvdke5aJI7ZmzpuXElrB0K6uEdCEdMKSvRs7UIw8JD4tqx0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784854325; c=relaxed/simple; bh=yfWb2zO48bIdxW8JEYB4JEguMfYbQtPMvXOZ7I1irR0=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=UAHOOBhpC+HhDVNSJr9XryC8fwJP0dIlcsIzGdV5EbzTdy9/RX8aPt2rl9XoEdZljGHzR7VtmSBJ98fZtfZwyiL8m94Nq5PZ1Vx2hTnU6daQqB1e29jViLvPgODFVEJnDaRG6cS9vt6TGMoZyhZAKB2jSdB3dPnG9PJUJWLbfFQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=J/GoU1YG; arc=none smtp.client-ip=213.97.179.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="J/GoU1YG" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:Message-ID:Subject:Cc:To :From:Date:MIME-Version:From:Reply-To; bh=zdmddBTnxu3ecQxTHZrj1U5FRs6aMjme2tgnifhIgMo=; b=J/GoU1YGDbVnh24W+ablo26MIH 0LmOITnPxpA63P0EpkmJ9Mf8dIMowGPhx5vysRSERbQ5hYNErUcqflMSCRUPgo4btBkkqyt85i8aW JaUR0PWXRFXmbmaTbvInttaN1jARlhl3O+BLnH8CdnsbsEiYBoetm9r/PPEPhEnw+B114h6+ZlKs8 pj4+qXSho71cHKhDcjjboaONgrdAsgLUAcUe9Db9WAEc1dOkmLzXAhhklZ5+vpNf6gxWiZiGhIjl+ QJO7i0JuFx4uk6Gm8cZ/cD/Kdz7XpnRZAKRD2lJPOJIV8yZRNxTQ5vaAbneQDCLjXY/5/XfzMCQRR fOFu3NRA==; Received: from maestria.local.igalia.com ([192.168.10.14] helo=mail.igalia.com) by fanzine2.igalia.com with esmtps (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1wn48e-003fgj-Mk; Fri, 24 Jul 2026 02:51:44 +0200 Received: from webmail.service.igalia.com ([192.168.21.45]) by mail.igalia.com with esmtp (Exim) id 1wn48c-00205n-Kh; Fri, 24 Jul 2026 02:51:44 +0200 Received: from localhost ([127.0.0.1] helo=webmail.igalia.com) by webmail.service.igalia.com with esmtp (Exim 4.98.2) (envelope-from ) id 1wn48c-000000032b5-1lMV; Fri, 24 Jul 2026 02:51:42 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Thu, 23 Jul 2026 21:51:42 -0300 From: Mauricio Faria de Oliveira To: Borislav Petkov Cc: Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juergen Gross , Alexey Dobriyan , Boris Ostrovsky , kernel-dev@igalia.com, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH v7 3/5] x86/asm: group inline string functions In-Reply-To: <20260723215928.GBamKOwB3PIaHrQFbs@fat_crate.local> References: <20260721-pvh-kasan-inline-v7-0-38979a50cef0@igalia.com> <20260721-pvh-kasan-inline-v7-3-38979a50cef0@igalia.com> <20260723215928.GBamKOwB3PIaHrQFbs@fat_crate.local> Message-ID: <1f3f0d30b592f4ddbb8f64f9d8fed429@igalia.com> X-Sender: mfo@igalia.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Report: NO, Score=-2.2, Tests=ALL_TRUSTED=-3,BAYES_50=0.8 X-Spam-Score: -21 X-Spam-Bar: -- On 2026-07-23 18:59, Borislav Petkov wrote: > On Tue, Jul 21, 2026 at 12:56:44PM -0300, Mauricio Faria de Oliveira wrote: >> Group the __inline string functions in the same header. >> >> Use since __inline_memcmp() must remain there for use >> by arch/x86/boot/string.c. > > "No functional changes." Ok, added. > >> Signed-off-by: Mauricio Faria de Oliveira >> --- >> arch/x86/include/asm/shared/string.h | 26 ++++++++++++++++++++++++++ >> arch/x86/include/asm/string.h | 21 +-------------------- >> 2 files changed, 27 insertions(+), 20 deletions(-) >> >> diff --git a/arch/x86/include/asm/shared/string.h b/arch/x86/include/asm/shared/string.h >> index 166274e44f3cb49e3dccab3cdac281d67aef5d44..9714fbda8b734e20686bfb88a6ca857bfee59e1a 100644 >> --- a/arch/x86/include/asm/shared/string.h >> +++ b/arch/x86/include/asm/shared/string.h >> @@ -2,6 +2,32 @@ >> #ifndef _ASM_X86_SHARED_STRING_H >> #define _ASM_X86_SHARED_STRING_H >> >> +/* >> + * The __inline string functions are grouped in this file for consistency and >> + * for use by arch/x86/boot code due to limitations on including asm/string.h. > > What limitations? > > Either explain them or don't bother adding a comment. asm/shared/ is generally > an understood concept if you grep the tree and you don't really need a comment > here. Ok, removed. Thanks, -- Mauricio