From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53B47C02194 for ; Fri, 7 Feb 2025 01:51:22 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1tgDWb-0003Ao-1X; Fri, 07 Feb 2025 01:51:21 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tgDWZ-0003AY-Ih for linux-f2fs-devel@lists.sourceforge.net; Fri, 07 Feb 2025 01:51:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:To:Subject:Cc:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=k8vWcZEyceCC9Fu+RzdRdhPCZxaTjydNZbkSsyXzr8c=; b=J+qnAdDa3WlxzEsX4+ZufhB2kk KTBBftiL+lP7ica0gHecYszqm+0qrfzmz8DhH1ekYFqa+Jz5eyGz8h8Jl++ZM3/bj1vbLgATHW02K mn0yRhnfHn1sWmZtr690dP+1Qp/aPP9an9fZkJEANUukypFNCzJkXfzahP6d6bVAgKhc=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:To: Subject:Cc:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=k8vWcZEyceCC9Fu+RzdRdhPCZxaTjydNZbkSsyXzr8c=; b=F7M9XjfpW2p2frCUcJtBouiBIs WkLgVgzOCYrPG4Cy3qA73RnR7RdJXJFjqvLSfSSXbOL7dINGk/JaIZKOQC+wZEbgIZoQG6CocAnyt v3cGOsLfopVXWglX5RUpP76zx5P0xTN3Mn7i/LJeUEgYeQlijT1WjSuH3dhs6YRB832w=; Received: from nyc.source.kernel.org ([147.75.193.91]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1tgDWY-0001Sv-GD for linux-f2fs-devel@lists.sourceforge.net; Fri, 07 Feb 2025 01:51:19 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id B73B3A44AA8; Fri, 7 Feb 2025 01:49:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 402E6C4CEDD; Fri, 7 Feb 2025 01:51:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738893072; bh=qDPEUa+3VPipKqb2Khm5lOImg9eJn2DBhB7VMEdHmrI=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=E6a8bq3RmaNKe5gpbXzGzVjBd3wLKJ4ObYGwk0s8E1z1tSL/Nn4yNOwmjW/Q6GcBQ g6YEAnC039psZlciKpXb/EKhA5PHtUZ3RJJlC+b9xj0BLjOLVYLOjIq5+oB4mI2gJB CCFFrM0GgplzUnGlNiBVs4rJpgYw8uPDLuV97picpgdGrTrCOeVcKCj0Dj2nY6hshJ lZytyuqZRIBAs5uNQcKbaT8rFPPa/LPhvGLWqsMmaBVl5zgp7pZnZSjTiGY1yyQVXk lsAhWZ3pUVAJAHcDAvlkTftihkmQcY96amK3rVxF6TKG5UAjmZsSoL4GSacUEFgWKH LdhBN07cprLpg== Message-ID: <1f8f1dca-101c-45ae-a2cd-0b83d6cbae66@kernel.org> Date: Fri, 7 Feb 2025 09:51:09 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Zhiguo Niu References: <20250206064451.3088028-1-chao@kernel.org> Content-Language: en-US In-Reply-To: X-Headers-End: 1tgDWY-0001Sv-GD Subject: Re: [f2fs-dev] [PATCH] f2fs: quota: fix to avoid warning in dquot_writeback_dquots() X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Chao Yu via Linux-f2fs-devel Reply-To: Chao Yu Cc: jaegeuk@kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net T24gMi83LzI1IDA5OjMwLCBaaGlndW8gTml1IHdyb3RlOgo+IENoYW8gWXUgdmlhIExpbnV4LWYy ZnMtZGV2ZWwgPGxpbnV4LWYyZnMtZGV2ZWxAbGlzdHMuc291cmNlZm9yZ2UubmV0Pgo+IOS6jjIw MjXlubQy5pyINuaXpeWRqOWbmyAxNDo1MOWGmemBk++8mgo+Pgo+PiBGMkZTLWZzIChkbS01OSk6 IGNoZWNrcG9pbnQ9ZW5hYmxlIGhhcyBzb21lIHVud3JpdHRlbiBkYXRhLgo+Pgo+PiAtLS0tLS0t LS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0tLS0KPj4gV0FSTklORzogQ1BVOiA2IFBJRDogODAx MyBhdCBmcy9xdW90YS9kcXVvdC5jOjY5MSBkcXVvdF93cml0ZWJhY2tfZHF1b3RzKzB4MmZjLzB4 MzA4Cj4+IHBjIDogZHF1b3Rfd3JpdGViYWNrX2RxdW90cysweDJmYy8weDMwOAo+PiBsciA6IGYy ZnNfcXVvdGFfc3luYysweGNjLzB4MWM0Cj4+IENhbGwgdHJhY2U6Cj4+IGRxdW90X3dyaXRlYmFj a19kcXVvdHMrMHgyZmMvMHgzMDgKPj4gZjJmc19xdW90YV9zeW5jKzB4Y2MvMHgxYzQKPj4gZjJm c193cml0ZV9jaGVja3BvaW50KzB4M2Q0LzB4OWIwCj4+IGYyZnNfaXNzdWVfY2hlY2twb2ludCsw eDFiYy8weDJjMAo+PiBmMmZzX3N5bmNfZnMrMHg1NC8weDE1MAo+PiBmMmZzX2RvX3N5bmNfZmls ZSsweDJmOC8weDgxNAo+PiBfX2YyZnNfaW9jdGwrMHgxOTYwLzB4MzI0NAo+PiBmMmZzX2lvY3Rs KzB4NTQvMHhlMAo+PiBfX2FybTY0X3N5c19pb2N0bCsweGE4LzB4ZTQKPj4gaW52b2tlX3N5c2Nh bGwrMHg1OC8weDExNAo+Pgo+PiBjaGVja3BvaW50IGFuZCBmMmZzX3JlbW91bnQgbWF5IHJhY2Ug YXMgYmVsb3csIHJlc3VsdGluZyB0cmlnZ2VyaW5nIHdhcm5pbmcKPj4gaW4gZHF1b3Rfd3JpdGVi YWNrX2RxdW90cygpLgo+Pgo+PiBhdG9taWMgd3JpdGUgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICByZW1vdW50Cj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIC0gZG9fcmVtb3VudAo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgLSBkb3duX3dyaXRlKCZzYi0+c191bW91bnQpOwo+PiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIC0gZjJmc19yZW1v dW50Cj4+IC0gaW9jdGwKPj4gIC0gZjJmc19kb19zeW5jX2ZpbGUKPj4gICAtIGYyZnNfc3luY19m cwo+PiAgICAtIGYyZnNfd3JpdGVfY2hlY2twb2ludAo+PiAgICAgLSBibG9ja19vcGVyYXRpb25z Cj4+ICAgICAgLSBsb2NrZWQgPSBkb3duX3JlYWRfdHJ5bG9jaygmc2JpLT5zYi0+c191bW91bnQp Cj4+ICAgICAgICA6IGZhaWwgdG8gbG9jayBkdWUgdG8gdGhlIHdyaXRlIGxvY2sgd2FzIGhlbGQg YnkgcmVtb3VudAo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgLSB1cF93cml0ZSgmc2ItPnNfdW1vdW50KTsKPj4gICAgICAtIGYyZnNfcXVvdGFfc3lu Ywo+PiAgICAgICAtIGRxdW90X3dyaXRlYmFja19kcXVvdHMKPj4gICAgICAgIC0gV0FSTl9PTl9P TkNFKCFyd3NlbV9pc19sb2NrZWQoJnNiLT5zX3Vtb3VudCkpCj4+ICAgICAgICA6IHRyaWdnZXIg d2FybmluZyBiZWNhdXNlIHNfdW1vdW50IGxvY2sgd2FzIHVubG9ja2VkIGJ5IHJlbW91bnQKPj4K Pj4gSWYgY2hlY2twb2ludCBjb21lcyBmcm9tIG1vdW50L3Vtb3VudC9yZW1vdW50L2ZyZWV6ZS9x dW90YWN0bCwgY2FsbGVyIG9mCj4+IGNoZWNrcG9pbnQgaGFzIGFscmVhZHkgaGVsZCBzX3Vtb3Vu dCBsb2NrLCBjYWxsaW5nIGRxdW90X3dyaXRlYmFja19kcXVvdHMoKQo+PiBpbiB0aGUgY29udGV4 dCBzaG91bGQgYmUgc2FmZS4KPj4KPj4gU28gbGV0J3MgcmVjb3JkIHRhc2sgdG8gc2JpLT51bW91 bnRfbG9ja19ob2xkZXIsIHNvIHRoYXQgY2hlY2twb2ludCBjYW4KPj4ga25vdyB3aGV0aGVyIHRo ZSBsb2NrIGhhcyBoZWxkIGluIHRoZSBjb250ZXh0IG9yIG5vdCBieSBjaGVja2luZyBjdXJyZW50 Cj4+IHcvIGl0Lgo+Pgo+PiBJbiBhZGRpdGlvbiwgaW4gb3JkZXIgdG8gbWlzcmVwcmVzZW50IGNh bGxlciBvZiBjaGVja3BvaW50LCB3ZSBzaG91bGQgbm90Cj4+IGFsbG93IHRvIHRyaWdnZXIgYXN5 bmMgY2hlY2twb2ludCBmb3IgdGhvc2UgY2FsbGVyczogbW91bnQvdW1vdW50L3JlbW91bnQvCj4+ IGZyZWV6ZS9xdW90YWN0bC4KPj4KPj4gRml4ZXM6IGFmMDMzYjJhYThhOCAoImYyZnM6IGd1YXJh bnRlZSBqb3VybmFsbGVkIHF1b3RhIGRhdGEgYnkgY2hlY2twb2ludCIpCj4+IFNpZ25lZC1vZmYt Ynk6IENoYW8gWXUgPGNoYW9Aa2VybmVsLm9yZz4KPj4gLS0tCj4+ICBmcy9mMmZzL2NoZWNrcG9p bnQuYyB8IDE3ICsrKysrKysrLS0tLS0KPj4gIGZzL2YyZnMvZjJmcy5oICAgICAgIHwgIDMgKyst Cj4+ICBmcy9mMmZzL3N1cGVyLmMgICAgICB8IDU5ICsrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrLS0tLS0tLS0tCj4+ICAzIGZpbGVzIGNoYW5nZWQsIDYwIGluc2VydGlvbnMoKyks IDE5IGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZnMvZjJmcy9jaGVja3BvaW50LmMg Yi9mcy9mMmZzL2NoZWNrcG9pbnQuYwo+PiBpbmRleCBlZmRhOWEwMjI5ODEuLmJhZmY2MzlhYzBj NCAxMDA2NDQKPj4gLS0tIGEvZnMvZjJmcy9jaGVja3BvaW50LmMKPj4gKysrIGIvZnMvZjJmcy9j aGVja3BvaW50LmMKPj4gQEAgLTEyMzcsNyArMTIzNyw4IEBAIHN0YXRpYyBpbnQgYmxvY2tfb3Bl cmF0aW9ucyhzdHJ1Y3QgZjJmc19zYl9pbmZvICpzYmkpCj4+ICByZXRyeV9mbHVzaF9xdW90YXM6 Cj4+ICAgICAgICAgZjJmc19sb2NrX2FsbChzYmkpOwo+PiAgICAgICAgIGlmIChfX25lZWRfZmx1 c2hfcXVvdGEoc2JpKSkgewo+PiAtICAgICAgICAgICAgICAgaW50IGxvY2tlZDsKPj4gKyAgICAg ICAgICAgICAgIGJvb2wgbmVlZF9sb2NrID0gc2JpLT51bW91bnRfbG9ja19ob2xkZXIgIT0gY3Vy cmVudDsKPj4gKyAgICAgICAgICAgICAgIGJvb2wgbG9ja2VkID0gZmFsc2U7Cj4+Cj4+ICAgICAg ICAgICAgICAgICBpZiAoKytjbnQgPiBERUZBVUxUX1JFVFJZX1FVT1RBX0ZMVVNIX0NPVU5UKSB7 Cj4+ICAgICAgICAgICAgICAgICAgICAgICAgIHNldF9zYmlfZmxhZyhzYmksIFNCSV9RVU9UQV9T S0lQX0ZMVVNIKTsKPj4gQEAgLTEyNDYsMTAgKzEyNDcsMTMgQEAgc3RhdGljIGludCBibG9ja19v cGVyYXRpb25zKHN0cnVjdCBmMmZzX3NiX2luZm8gKnNiaSkKPj4gICAgICAgICAgICAgICAgIH0K Pj4gICAgICAgICAgICAgICAgIGYyZnNfdW5sb2NrX2FsbChzYmkpOwo+Pgo+PiAtICAgICAgICAg ICAgICAgLyogb25seSBmYWlsZWQgZHVyaW5nIG1vdW50L3Vtb3VudC9mcmVlemUvcXVvdGFjdGwg Ki8KPj4gLSAgICAgICAgICAgICAgIGxvY2tlZCA9IGRvd25fcmVhZF90cnlsb2NrKCZzYmktPnNi LT5zX3Vtb3VudCk7Cj4+IC0gICAgICAgICAgICAgICBmMmZzX3F1b3RhX3N5bmMoc2JpLT5zYiwg LTEpOwo+PiAtICAgICAgICAgICAgICAgaWYgKGxvY2tlZCkKPj4gKyAgICAgICAgICAgICAgIC8q IGRvbid0IGdyYWIgc191bW91bnQgbG9jayBkdXJpbmcgbW91bnQvdW1vdW50L3JlbW91bnQvZnJl ZXplL3F1b3RhY3RsICovCj4+ICsgICAgICAgICAgICAgICBpZiAobmVlZF9sb2NrICYmICFkb3du X3JlYWRfdHJ5bG9jaygmc2JpLT5zYi0+c191bW91bnQpKSB7Cj4+ICsgICAgICAgICAgICAgICAg ICAgICAgIGNvbmRfcmVzY2hlZCgpOwo+PiArICAgICAgICAgICAgICAgICAgICAgICBnb3RvIHJl dHJ5X2ZsdXNoX3F1b3RhczsKPj4gKyAgICAgICAgICAgICAgIH0KPj4gKyAgICAgICAgICAgICAg IGYyZnNfZG9fcXVvdGFfc3luYyhzYmktPnNiLCAtMSk7Cj4+ICsgICAgICAgICAgICAgICBpZiAo bmVlZF9sb2NrKQo+PiAgICAgICAgICAgICAgICAgICAgICAgICB1cF9yZWFkKCZzYmktPnNiLT5z X3Vtb3VudCk7Cj4+ICAgICAgICAgICAgICAgICBjb25kX3Jlc2NoZWQoKTsKPj4gICAgICAgICAg ICAgICAgIGdvdG8gcmV0cnlfZmx1c2hfcXVvdGFzOwo+PiBAQCAtMTg2Nyw3ICsxODcxLDggQEAg aW50IGYyZnNfaXNzdWVfY2hlY2twb2ludChzdHJ1Y3QgZjJmc19zYl9pbmZvICpzYmkpCj4+ICAg ICAgICAgc3RydWN0IGNwX2NvbnRyb2wgY3BjOwo+Pgo+PiAgICAgICAgIGNwYy5yZWFzb24gPSBf X2dldF9jcF9yZWFzb24oc2JpKTsKPj4gLSAgICAgICBpZiAoIXRlc3Rfb3B0KHNiaSwgTUVSR0Vf Q0hFQ0tQT0lOVCkgfHwgY3BjLnJlYXNvbiAhPSBDUF9TWU5DKSB7Cj4+ICsgICAgICAgaWYgKCF0 ZXN0X29wdChzYmksIE1FUkdFX0NIRUNLUE9JTlQpIHx8IGNwYy5yZWFzb24gIT0gQ1BfU1lOQyB8 fAo+PiArICAgICAgICAgICAgICAgc2JpLT51bW91bnRfbG9ja19ob2xkZXIgPT0gY3VycmVudCkg ewo+PiAgICAgICAgICAgICAgICAgaW50IHJldDsKPj4KPj4gICAgICAgICAgICAgICAgIGYyZnNf ZG93bl93cml0ZSgmc2JpLT5nY19sb2NrKTsKPj4gZGlmZiAtLWdpdCBhL2ZzL2YyZnMvZjJmcy5o IGIvZnMvZjJmcy9mMmZzLmgKPj4gaW5kZXggNjJiN2ZlZDE1MTRhLi43MTc0ZGVhNjQxZTkgMTAw NjQ0Cj4+IC0tLSBhL2ZzL2YyZnMvZjJmcy5oCj4+ICsrKyBiL2ZzL2YyZnMvZjJmcy5oCj4+IEBA IC0xNjcwLDYgKzE2NzAsNyBAQCBzdHJ1Y3QgZjJmc19zYl9pbmZvIHsKPj4KPj4gICAgICAgICB1 bnNpZ25lZCBpbnQgbnF1b3RhX2ZpbGVzOyAgICAgICAgICAgICAgLyogIyBvZiBxdW90YSBzeXNm aWxlICovCj4+ICAgICAgICAgc3RydWN0IGYyZnNfcndzZW0gcXVvdGFfc2VtOyAgICAgICAgICAg IC8qIGJsb2NraW5nIGNwIGZvciBmbGFncyAqLwo+PiArICAgICAgIHN0cnVjdCB0YXNrX3N0cnVj dCAqdW1vdW50X2xvY2tfaG9sZGVyOyAvKiBzX3Vtb3VudCBsb2NrIGhvbGRlciAqLwo+Pgo+PiAg ICAgICAgIC8qICMgb2YgcGFnZXMsIHNlZSBjb3VudF90eXBlICovCj4+ICAgICAgICAgYXRvbWlj X3QgbnJfcGFnZXNbTlJfQ09VTlRfVFlQRV07Cj4+IEBAIC0zNjUyLDcgKzM2NTMsNyBAQCBpbnQg ZjJmc19pbm9kZV9kaXJ0aWVkKHN0cnVjdCBpbm9kZSAqaW5vZGUsIGJvb2wgc3luYyk7Cj4+ICB2 b2lkIGYyZnNfaW5vZGVfc3luY2VkKHN0cnVjdCBpbm9kZSAqaW5vZGUpOwo+PiAgaW50IGYyZnNf ZHF1b3RfaW5pdGlhbGl6ZShzdHJ1Y3QgaW5vZGUgKmlub2RlKTsKPj4gIGludCBmMmZzX2VuYWJs ZV9xdW90YV9maWxlcyhzdHJ1Y3QgZjJmc19zYl9pbmZvICpzYmksIGJvb2wgcmRvbmx5KTsKPj4g LWludCBmMmZzX3F1b3RhX3N5bmMoc3RydWN0IHN1cGVyX2Jsb2NrICpzYiwgaW50IHR5cGUpOwo+ PiAraW50IGYyZnNfZG9fcXVvdGFfc3luYyhzdHJ1Y3Qgc3VwZXJfYmxvY2sgKnNiLCBpbnQgdHlw ZSk7Cj4+ICBsb2ZmX3QgbWF4X2ZpbGVfYmxvY2tzKHN0cnVjdCBpbm9kZSAqaW5vZGUpOwo+PiAg dm9pZCBmMmZzX3F1b3RhX29mZl91bW91bnQoc3RydWN0IHN1cGVyX2Jsb2NrICpzYik7Cj4+ICB2 b2lkIGYyZnNfc2F2ZV9lcnJvcnMoc3RydWN0IGYyZnNfc2JfaW5mbyAqc2JpLCB1bnNpZ25lZCBj aGFyIGZsYWcpOwo+PiBkaWZmIC0tZ2l0IGEvZnMvZjJmcy9zdXBlci5jIGIvZnMvZjJmcy9zdXBl ci5jCj4+IGluZGV4IGVmNjM5YTZkODJlNS4uY2I5ZDdiNmZhM2FkIDEwMDY0NAo+PiAtLS0gYS9m cy9mMmZzL3N1cGVyLmMKPj4gKysrIGIvZnMvZjJmcy9zdXBlci5jCj4+IEBAIC0xNzQwLDIyICsx NzQwLDI4IEBAIGludCBmMmZzX3N5bmNfZnMoc3RydWN0IHN1cGVyX2Jsb2NrICpzYiwgaW50IHN5 bmMpCj4+Cj4+ICBzdGF0aWMgaW50IGYyZnNfZnJlZXplKHN0cnVjdCBzdXBlcl9ibG9jayAqc2Ip Cj4+ICB7Cj4+ICsgICAgICAgc3RydWN0IGYyZnNfc2JfaW5mbyAqc2JpID0gRjJGU19TQihzYik7 Cj4+ICsKPj4gICAgICAgICBpZiAoZjJmc19yZWFkb25seShzYikpCj4+ICAgICAgICAgICAgICAg ICByZXR1cm4gMDsKPj4KPj4gICAgICAgICAvKiBJTyBlcnJvciBoYXBwZW5lZCBiZWZvcmUgKi8K Pj4gLSAgICAgICBpZiAodW5saWtlbHkoZjJmc19jcF9lcnJvcihGMkZTX1NCKHNiKSkpKQo+PiAr ICAgICAgIGlmICh1bmxpa2VseShmMmZzX2NwX2Vycm9yKHNiaSkpKQo+PiAgICAgICAgICAgICAg ICAgcmV0dXJuIC1FSU87Cj4+Cj4+ICAgICAgICAgLyogbXVzdCBiZSBjbGVhbiwgc2luY2Ugc3lu Y19maWxlc3lzdGVtKCkgd2FzIGFscmVhZHkgY2FsbGVkICovCj4+IC0gICAgICAgaWYgKGlzX3Ni aV9mbGFnX3NldChGMkZTX1NCKHNiKSwgU0JJX0lTX0RJUlRZKSkKPj4gKyAgICAgICBpZiAoaXNf c2JpX2ZsYWdfc2V0KHNiaSwgU0JJX0lTX0RJUlRZKSkKPj4gICAgICAgICAgICAgICAgIHJldHVy biAtRUlOVkFMOwo+Pgo+PiArICAgICAgIHNiaS0+dW1vdW50X2xvY2tfaG9sZGVyID0gY3VycmVu dDsKPj4gKwo+PiAgICAgICAgIC8qIExldCdzIGZsdXNoIGNoZWNrcG9pbnRzIGFuZCBzdG9wIHRo ZSB0aHJlYWQuICovCj4+IC0gICAgICAgZjJmc19mbHVzaF9ja3B0X3RocmVhZChGMkZTX1NCKHNi KSk7Cj4+ICsgICAgICAgZjJmc19mbHVzaF9ja3B0X3RocmVhZChzYmkpOwo+PiArCj4+ICsgICAg ICAgc2JpLT51bW91bnRfbG9ja19ob2xkZXIgPSBOVUxMOwo+Pgo+PiAgICAgICAgIC8qIHRvIGF2 b2lkIGRlYWRsb2NrIG9uIGYyZnNfZXZpY3RfaW5vZGUtPlNCX0ZSRUVaRV9GUyAqLwo+PiAtICAg ICAgIHNldF9zYmlfZmxhZyhGMkZTX1NCKHNiKSwgU0JJX0lTX0ZSRUVaSU5HKTsKPj4gKyAgICAg ICBzZXRfc2JpX2ZsYWcoc2JpLCBTQklfSVNfRlJFRVpJTkcpOwo+PiAgICAgICAgIHJldHVybiAw Owo+PiAgfQo+Pgo+PiBAQCAtMjMzMiw2ICsyMzM4LDggQEAgc3RhdGljIGludCBmMmZzX3JlbW91 bnQoc3RydWN0IHN1cGVyX2Jsb2NrICpzYiwgaW50ICpmbGFncywgY2hhciAqZGF0YSkKPj4gICAg ICAgICBvcmdfbW91bnRfb3B0ID0gc2JpLT5tb3VudF9vcHQ7Cj4+ICAgICAgICAgb2xkX3NiX2Zs YWdzID0gc2ItPnNfZmxhZ3M7Cj4+Cj4+ICsgICAgICAgc2JpLT51bW91bnRfbG9ja19ob2xkZXIg PSBjdXJyZW50Owo+PiArCj4+ICAjaWZkZWYgQ09ORklHX1FVT1RBCj4+ICAgICAgICAgb3JnX21v dW50X29wdC5zX2pxdW90YV9mbXQgPSBGMkZTX09QVElPTihzYmkpLnNfanF1b3RhX2ZtdDsKPj4g ICAgICAgICBmb3IgKGkgPSAwOyBpIDwgTUFYUVVPVEFTOyBpKyspIHsKPj4gQEAgLTI1NTUsNiAr MjU2Myw4IEBAIHN0YXRpYyBpbnQgZjJmc19yZW1vdW50KHN0cnVjdCBzdXBlcl9ibG9jayAqc2Is IGludCAqZmxhZ3MsIGNoYXIgKmRhdGEpCj4+Cj4+ICAgICAgICAgbGltaXRfcmVzZXJ2ZV9yb290 KHNiaSk7Cj4+ICAgICAgICAgKmZsYWdzID0gKCpmbGFncyAmIH5TQl9MQVpZVElNRSkgfCAoc2It PnNfZmxhZ3MgJiBTQl9MQVpZVElNRSk7Cj4+ICsKPj4gKyAgICAgICBzYmktPnVtb3VudF9sb2Nr X2hvbGRlciA9IE5VTEw7Cj4+ICAgICAgICAgcmV0dXJuIDA7Cj4+ICByZXN0b3JlX2NoZWNrcG9p bnQ6Cj4+ICAgICAgICAgaWYgKG5lZWRfZW5hYmxlX2NoZWNrcG9pbnQpIHsKPj4gQEAgLTI1OTUs NiArMjYwNSw4IEBAIHN0YXRpYyBpbnQgZjJmc19yZW1vdW50KHN0cnVjdCBzdXBlcl9ibG9jayAq c2IsIGludCAqZmxhZ3MsIGNoYXIgKmRhdGEpCj4+ICAjZW5kaWYKPj4gICAgICAgICBzYmktPm1v dW50X29wdCA9IG9yZ19tb3VudF9vcHQ7Cj4+ICAgICAgICAgc2ItPnNfZmxhZ3MgPSBvbGRfc2Jf ZmxhZ3M7Cj4+ICsKPj4gKyAgICAgICBzYmktPnVtb3VudF9sb2NrX2hvbGRlciA9IE5VTEw7Cj4+ ICAgICAgICAgcmV0dXJuIGVycjsKPj4gIH0KPj4KPj4gQEAgLTI5MTEsNyArMjkyMyw3IEBAIHN0 YXRpYyBpbnQgZjJmc19xdW90YV9zeW5jX2ZpbGUoc3RydWN0IGYyZnNfc2JfaW5mbyAqc2JpLCBp bnQgdHlwZSkKPj4gICAgICAgICByZXR1cm4gcmV0Owo+PiAgfQo+Pgo+PiAtaW50IGYyZnNfcXVv dGFfc3luYyhzdHJ1Y3Qgc3VwZXJfYmxvY2sgKnNiLCBpbnQgdHlwZSkKPj4gK2ludCBmMmZzX2Rv X3F1b3RhX3N5bmMoc3RydWN0IHN1cGVyX2Jsb2NrICpzYiwgaW50IHR5cGUpCj4+ICB7Cj4+ICAg ICAgICAgc3RydWN0IGYyZnNfc2JfaW5mbyAqc2JpID0gRjJGU19TQihzYik7Cj4+ICAgICAgICAg c3RydWN0IHF1b3RhX2luZm8gKmRxb3B0ID0gc2JfZHFvcHQoc2IpOwo+PiBAQCAtMjk1OSw2ICsy OTcxLDE2IEBAIGludCBmMmZzX3F1b3RhX3N5bmMoc3RydWN0IHN1cGVyX2Jsb2NrICpzYiwgaW50 IHR5cGUpCj4+ICAgICAgICAgcmV0dXJuIHJldDsKPj4gIH0KPj4KPj4gK3N0YXRpYyBpbnQgZjJm c19xdW90YV9zeW5jKHN0cnVjdCBzdXBlcl9ibG9jayAqc2IsIGludCB0eXBlKQo+PiArewo+PiAr ICAgICAgIGludCByZXQ7Cj4+ICsKPj4gKyAgICAgICBGMkZTX1NCKHNiKS0+dW1vdW50X2xvY2tf aG9sZGVyID0gY3VycmVudDsKPj4gKyAgICAgICByZXQgPSBmMmZzX2RvX3F1b3RhX3N5bmMoc2Is IHR5cGUpOwo+PiArICAgICAgIEYyRlNfU0Ioc2IpLT51bW91bnRfbG9ja19ob2xkZXIgPSBOVUxM Owo+PiArICAgICAgIHJldHVybiByZXQ7Cj4+ICt9Cj4+ICsKPj4gIHN0YXRpYyBpbnQgZjJmc19x dW90YV9vbihzdHJ1Y3Qgc3VwZXJfYmxvY2sgKnNiLCBpbnQgdHlwZSwgaW50IGZvcm1hdF9pZCwK Pj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBjb25zdCBzdHJ1Y3QgcGF0aCAqcGF0aCkKPj4gIHsKPj4gQEAgLTI5NzQsMzAgKzI5OTYsMzMg QEAgc3RhdGljIGludCBmMmZzX3F1b3RhX29uKHN0cnVjdCBzdXBlcl9ibG9jayAqc2IsIGludCB0 eXBlLCBpbnQgZm9ybWF0X2lkLAo+PiAgICAgICAgIGlmIChwYXRoLT5kZW50cnktPmRfc2IgIT0g c2IpCj4+ICAgICAgICAgICAgICAgICByZXR1cm4gLUVYREVWOwo+Pgo+PiAtICAgICAgIGVyciA9 IGYyZnNfcXVvdGFfc3luYyhzYiwgdHlwZSk7Cj4+ICsgICAgICAgRjJGU19TQihzYiktPnVtb3Vu dF9sb2NrX2hvbGRlciA9IGN1cnJlbnQ7Cj4+ICsKPj4gKyAgICAgICBlcnIgPSBmMmZzX2RvX3F1 b3RhX3N5bmMoc2IsIHR5cGUpOwo+PiAgICAgICAgIGlmIChlcnIpCj4+IC0gICAgICAgICAgICAg ICByZXR1cm4gZXJyOwo+PiArICAgICAgICAgICAgICAgZ290byBvdXQ7Cj4+Cj4+ICAgICAgICAg aW5vZGUgPSBkX2lub2RlKHBhdGgtPmRlbnRyeSk7Cj4+Cj4+ICAgICAgICAgZXJyID0gZmlsZW1h cF9mZGF0YXdyaXRlKGlub2RlLT5pX21hcHBpbmcpOwo+PiAgICAgICAgIGlmIChlcnIpCj4+IC0g ICAgICAgICAgICAgICByZXR1cm4gZXJyOwo+PiArICAgICAgICAgICAgICAgZ290byBvdXQ7Cj4+ Cj4+ICAgICAgICAgZXJyID0gZmlsZW1hcF9mZGF0YXdhaXQoaW5vZGUtPmlfbWFwcGluZyk7Cj4+ ICAgICAgICAgaWYgKGVycikKPj4gLSAgICAgICAgICAgICAgIHJldHVybiBlcnI7Cj4+ICsgICAg ICAgICAgICAgICBnb3RvIG91dDsKPj4KPj4gICAgICAgICBlcnIgPSBkcXVvdF9xdW90YV9vbihz YiwgdHlwZSwgZm9ybWF0X2lkLCBwYXRoKTsKPj4gICAgICAgICBpZiAoZXJyKQo+PiAtICAgICAg ICAgICAgICAgcmV0dXJuIGVycjsKPj4gKyAgICAgICAgICAgICAgIGdvdG8gb3V0Owo+Pgo+PiAg ICAgICAgIGlub2RlX2xvY2soaW5vZGUpOwo+PiAgICAgICAgIEYyRlNfSShpbm9kZSktPmlfZmxh Z3MgfD0gRjJGU19RVU9UQV9ERUZBVUxUX0ZMOwo+PiAgICAgICAgIGYyZnNfc2V0X2lub2RlX2Zs YWdzKGlub2RlKTsKPj4gICAgICAgICBpbm9kZV91bmxvY2soaW5vZGUpOwo+PiAgICAgICAgIGYy ZnNfbWFya19pbm9kZV9kaXJ0eV9zeW5jKGlub2RlLCBmYWxzZSk7Cj4+IC0KPj4gK291dDoKPj4g KyAgICAgICBGMkZTX1NCKHNiKS0+dW1vdW50X2xvY2tfaG9sZGVyID0gTlVMTDsKPj4gICAgICAg ICByZXR1cm4gMDsKPiBIaSBDaGFvLAo+IEhlcmUgc2hvdWxkIHJldHVybiBlcnI/IGFuZCBpbml0 IGVycj0wIGluIHRoZSBiZWdpbm5pbmc/CgpaaGlndW8sCgpPaCwgeWVzLCBsZXQgbWUgZml4IHRo aXMsIHRoYW5rIHlvdSBmb3IgdGhlIHJldmlldy4KClRoYW5rcywKCj4gdGhhbmtz77yBCj4+ICB9 Cj4+Cj4+IEBAIC0zMDA5LDcgKzMwMzQsNyBAQCBzdGF0aWMgaW50IF9fZjJmc19xdW90YV9vZmYo c3RydWN0IHN1cGVyX2Jsb2NrICpzYiwgaW50IHR5cGUpCj4+ICAgICAgICAgaWYgKCFpbm9kZSB8 fCAhaWdyYWIoaW5vZGUpKQo+PiAgICAgICAgICAgICAgICAgcmV0dXJuIGRxdW90X3F1b3RhX29m ZihzYiwgdHlwZSk7Cj4+Cj4+IC0gICAgICAgZXJyID0gZjJmc19xdW90YV9zeW5jKHNiLCB0eXBl KTsKPj4gKyAgICAgICBlcnIgPSBmMmZzX2RvX3F1b3RhX3N5bmMoc2IsIHR5cGUpOwo+PiAgICAg ICAgIGlmIChlcnIpCj4+ICAgICAgICAgICAgICAgICBnb3RvIG91dF9wdXQ7Cj4+Cj4+IEBAIC0z MDMyLDYgKzMwNTcsOCBAQCBzdGF0aWMgaW50IGYyZnNfcXVvdGFfb2ZmKHN0cnVjdCBzdXBlcl9i bG9jayAqc2IsIGludCB0eXBlKQo+PiAgICAgICAgIHN0cnVjdCBmMmZzX3NiX2luZm8gKnNiaSA9 IEYyRlNfU0Ioc2IpOwo+PiAgICAgICAgIGludCBlcnI7Cj4+Cj4+ICsgICAgICAgRjJGU19TQihz YiktPnVtb3VudF9sb2NrX2hvbGRlciA9IGN1cnJlbnQ7Cj4+ICsKPj4gICAgICAgICBlcnIgPSBf X2YyZnNfcXVvdGFfb2ZmKHNiLCB0eXBlKTsKPj4KPj4gICAgICAgICAvKgo+PiBAQCAtMzA0MSw2 ICszMDY4LDkgQEAgc3RhdGljIGludCBmMmZzX3F1b3RhX29mZihzdHJ1Y3Qgc3VwZXJfYmxvY2sg KnNiLCBpbnQgdHlwZSkKPj4gICAgICAgICAgKi8KPj4gICAgICAgICBpZiAoaXNfam91cm5hbGxl ZF9xdW90YShzYmkpKQo+PiAgICAgICAgICAgICAgICAgc2V0X3NiaV9mbGFnKHNiaSwgU0JJX1FV T1RBX05FRURfUkVQQUlSKTsKPj4gKwo+PiArICAgICAgIEYyRlNfU0Ioc2IpLT51bW91bnRfbG9j a19ob2xkZXIgPSBOVUxMOwo+PiArCj4+ICAgICAgICAgcmV0dXJuIGVycjsKPj4gIH0KPj4KPj4g QEAgLTQ3MTUsNiArNDc0NSw3IEBAIHN0YXRpYyBpbnQgZjJmc19maWxsX3N1cGVyKHN0cnVjdCBz dXBlcl9ibG9jayAqc2IsIHZvaWQgKmRhdGEsIGludCBzaWxlbnQpCj4+ICAgICAgICAgaWYgKGVy cikKPj4gICAgICAgICAgICAgICAgIGdvdG8gZnJlZV9jb21wcmVzc19pbm9kZTsKPj4KPj4gKyAg ICAgICBzYmktPnVtb3VudF9sb2NrX2hvbGRlciA9IGN1cnJlbnQ7Cj4+ICAjaWZkZWYgQ09ORklH X1FVT1RBCj4+ICAgICAgICAgLyogRW5hYmxlIHF1b3RhIHVzYWdlIGR1cmluZyBtb3VudCAqLwo+ PiAgICAgICAgIGlmIChmMmZzX3NiX2hhc19xdW90YV9pbm8oc2JpKSAmJiAhZjJmc19yZWFkb25s eShzYikpIHsKPj4gQEAgLTQ4NDEsNiArNDg3Miw4IEBAIHN0YXRpYyBpbnQgZjJmc19maWxsX3N1 cGVyKHN0cnVjdCBzdXBlcl9ibG9jayAqc2IsIHZvaWQgKmRhdGEsIGludCBzaWxlbnQpCj4+ICAg ICAgICAgZjJmc191cGRhdGVfdGltZShzYmksIENQX1RJTUUpOwo+PiAgICAgICAgIGYyZnNfdXBk YXRlX3RpbWUoc2JpLCBSRVFfVElNRSk7Cj4+ICAgICAgICAgY2xlYXJfc2JpX2ZsYWcoc2JpLCBT QklfQ1BfRElTQUJMRURfUVVJQ0spOwo+PiArCj4+ICsgICAgICAgc2JpLT51bW91bnRfbG9ja19o b2xkZXIgPSBOVUxMOwo+PiAgICAgICAgIHJldHVybiAwOwo+Pgo+PiAgc3luY19mcmVlX21ldGE6 Cj4+IEBAIC00OTQ1LDYgKzQ5NzgsOCBAQCBzdGF0aWMgdm9pZCBraWxsX2YyZnNfc3VwZXIoc3Ry dWN0IHN1cGVyX2Jsb2NrICpzYikKPj4gICAgICAgICBzdHJ1Y3QgZjJmc19zYl9pbmZvICpzYmkg PSBGMkZTX1NCKHNiKTsKPj4KPj4gICAgICAgICBpZiAoc2ItPnNfcm9vdCkgewo+PiArICAgICAg ICAgICAgICAgc2JpLT51bW91bnRfbG9ja19ob2xkZXIgPSBjdXJyZW50Owo+PiArCj4+ICAgICAg ICAgICAgICAgICBzZXRfc2JpX2ZsYWcoc2JpLCBTQklfSVNfQ0xPU0UpOwo+PiAgICAgICAgICAg ICAgICAgZjJmc19zdG9wX2djX3RocmVhZChzYmkpOwo+PiAgICAgICAgICAgICAgICAgZjJmc19z dG9wX2Rpc2NhcmRfdGhyZWFkKHNiaSk7Cj4+IC0tCj4+IDIuNDguMS41MDIuZzZkYzI0ZGZkYWYt Z29vZwo+Pgo+Pgo+Pgo+PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwo+PiBMaW51eC1mMmZzLWRldmVsIG1haWxpbmcgbGlzdAo+PiBMaW51eC1mMmZzLWRl dmVsQGxpc3RzLnNvdXJjZWZvcmdlLm5ldAo+PiBodHRwczovL2xpc3RzLnNvdXJjZWZvcmdlLm5l dC9saXN0cy9saXN0aW5mby9saW51eC1mMmZzLWRldmVsCgoKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LWYyZnMtZGV2ZWwgbWFpbGluZyBsaXN0 CkxpbnV4LWYyZnMtZGV2ZWxAbGlzdHMuc291cmNlZm9yZ2UubmV0Cmh0dHBzOi8vbGlzdHMuc291 cmNlZm9yZ2UubmV0L2xpc3RzL2xpc3RpbmZvL2xpbnV4LWYyZnMtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 817942940B for ; Fri, 7 Feb 2025 01:51:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738893072; cv=none; b=jZpkqLKYCBeB48UIx8yPHXlFZXXyd1GaXaCTTEW6rhIGM/Q6bOAO18HUsA8ontgeMevOLk3DthTwCBvBsgpQV1zk/7cuUvbOuNKJ1GjT6L67cF7LOWoyBDd7MkV7uMNsRxZ+5UuqSU7WcnTuke6nLb7z5NLXfOn/ggQ4SJuHG8Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738893072; c=relaxed/simple; bh=qDPEUa+3VPipKqb2Khm5lOImg9eJn2DBhB7VMEdHmrI=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=rkrsyjchsec+wJYmtBMvZ7rFPE8JErooliMpU4TtkhaTcFg8syx8VATSX8s0Ib9FNA9qRgZpXZaeiarHj5W80RgJgW1qFbebfJFjxFcn37iJAxKT76dJqPXWJTPAn5pvbW/fSpU3LvPuaYGc3HZM0OAh2qYgxqAObWdQc5HIdgA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=E6a8bq3R; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="E6a8bq3R" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 402E6C4CEDD; Fri, 7 Feb 2025 01:51:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738893072; bh=qDPEUa+3VPipKqb2Khm5lOImg9eJn2DBhB7VMEdHmrI=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=E6a8bq3RmaNKe5gpbXzGzVjBd3wLKJ4ObYGwk0s8E1z1tSL/Nn4yNOwmjW/Q6GcBQ g6YEAnC039psZlciKpXb/EKhA5PHtUZ3RJJlC+b9xj0BLjOLVYLOjIq5+oB4mI2gJB CCFFrM0GgplzUnGlNiBVs4rJpgYw8uPDLuV97picpgdGrTrCOeVcKCj0Dj2nY6hshJ lZytyuqZRIBAs5uNQcKbaT8rFPPa/LPhvGLWqsMmaBVl5zgp7pZnZSjTiGY1yyQVXk lsAhWZ3pUVAJAHcDAvlkTftihkmQcY96amK3rVxF6TKG5UAjmZsSoL4GSacUEFgWKH LdhBN07cprLpg== Message-ID: <1f8f1dca-101c-45ae-a2cd-0b83d6cbae66@kernel.org> Date: Fri, 7 Feb 2025 09:51:09 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, jaegeuk@kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH] f2fs: quota: fix to avoid warning in dquot_writeback_dquots() To: Zhiguo Niu References: <20250206064451.3088028-1-chao@kernel.org> Content-Language: en-US From: Chao Yu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 2/7/25 09:30, Zhiguo Niu wrote: > Chao Yu via Linux-f2fs-devel > 于2025年2月6日周四 14:50写道： >> >> F2FS-fs (dm-59): checkpoint=enable has some unwritten data. >> >> ------------[ cut here ]------------ >> WARNING: CPU: 6 PID: 8013 at fs/quota/dquot.c:691 dquot_writeback_dquots+0x2fc/0x308 >> pc : dquot_writeback_dquots+0x2fc/0x308 >> lr : f2fs_quota_sync+0xcc/0x1c4 >> Call trace: >> dquot_writeback_dquots+0x2fc/0x308 >> f2fs_quota_sync+0xcc/0x1c4 >> f2fs_write_checkpoint+0x3d4/0x9b0 >> f2fs_issue_checkpoint+0x1bc/0x2c0 >> f2fs_sync_fs+0x54/0x150 >> f2fs_do_sync_file+0x2f8/0x814 >> __f2fs_ioctl+0x1960/0x3244 >> f2fs_ioctl+0x54/0xe0 >> __arm64_sys_ioctl+0xa8/0xe4 >> invoke_syscall+0x58/0x114 >> >> checkpoint and f2fs_remount may race as below, resulting triggering warning >> in dquot_writeback_dquots(). >> >> atomic write remount >> - do_remount >> - down_write(&sb->s_umount); >> - f2fs_remount >> - ioctl >> - f2fs_do_sync_file >> - f2fs_sync_fs >> - f2fs_write_checkpoint >> - block_operations >> - locked = down_read_trylock(&sbi->sb->s_umount) >> : fail to lock due to the write lock was held by remount >> - up_write(&sb->s_umount); >> - f2fs_quota_sync >> - dquot_writeback_dquots >> - WARN_ON_ONCE(!rwsem_is_locked(&sb->s_umount)) >> : trigger warning because s_umount lock was unlocked by remount >> >> If checkpoint comes from mount/umount/remount/freeze/quotactl, caller of >> checkpoint has already held s_umount lock, calling dquot_writeback_dquots() >> in the context should be safe. >> >> So let's record task to sbi->umount_lock_holder, so that checkpoint can >> know whether the lock has held in the context or not by checking current >> w/ it. >> >> In addition, in order to misrepresent caller of checkpoint, we should not >> allow to trigger async checkpoint for those callers: mount/umount/remount/ >> freeze/quotactl. >> >> Fixes: af033b2aa8a8 ("f2fs: guarantee journalled quota data by checkpoint") >> Signed-off-by: Chao Yu >> --- >> fs/f2fs/checkpoint.c | 17 ++++++++----- >> fs/f2fs/f2fs.h | 3 ++- >> fs/f2fs/super.c | 59 +++++++++++++++++++++++++++++++++++--------- >> 3 files changed, 60 insertions(+), 19 deletions(-) >> >> diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c >> index efda9a022981..baff639ac0c4 100644 >> --- a/fs/f2fs/checkpoint.c >> +++ b/fs/f2fs/checkpoint.c >> @@ -1237,7 +1237,8 @@ static int block_operations(struct f2fs_sb_info *sbi) >> retry_flush_quotas: >> f2fs_lock_all(sbi); >> if (__need_flush_quota(sbi)) { >> - int locked; >> + bool need_lock = sbi->umount_lock_holder != current; >> + bool locked = false; >> >> if (++cnt > DEFAULT_RETRY_QUOTA_FLUSH_COUNT) { >> set_sbi_flag(sbi, SBI_QUOTA_SKIP_FLUSH); >> @@ -1246,10 +1247,13 @@ static int block_operations(struct f2fs_sb_info *sbi) >> } >> f2fs_unlock_all(sbi); >> >> - /* only failed during mount/umount/freeze/quotactl */ >> - locked = down_read_trylock(&sbi->sb->s_umount); >> - f2fs_quota_sync(sbi->sb, -1); >> - if (locked) >> + /* don't grab s_umount lock during mount/umount/remount/freeze/quotactl */ >> + if (need_lock && !down_read_trylock(&sbi->sb->s_umount)) { >> + cond_resched(); >> + goto retry_flush_quotas; >> + } >> + f2fs_do_quota_sync(sbi->sb, -1); >> + if (need_lock) >> up_read(&sbi->sb->s_umount); >> cond_resched(); >> goto retry_flush_quotas; >> @@ -1867,7 +1871,8 @@ int f2fs_issue_checkpoint(struct f2fs_sb_info *sbi) >> struct cp_control cpc; >> >> cpc.reason = __get_cp_reason(sbi); >> - if (!test_opt(sbi, MERGE_CHECKPOINT) || cpc.reason != CP_SYNC) { >> + if (!test_opt(sbi, MERGE_CHECKPOINT) || cpc.reason != CP_SYNC || >> + sbi->umount_lock_holder == current) { >> int ret; >> >> f2fs_down_write(&sbi->gc_lock); >> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h >> index 62b7fed1514a..7174dea641e9 100644 >> --- a/fs/f2fs/f2fs.h >> +++ b/fs/f2fs/f2fs.h >> @@ -1670,6 +1670,7 @@ struct f2fs_sb_info { >> >> unsigned int nquota_files; /* # of quota sysfile */ >> struct f2fs_rwsem quota_sem; /* blocking cp for flags */ >> + struct task_struct *umount_lock_holder; /* s_umount lock holder */ >> >> /* # of pages, see count_type */ >> atomic_t nr_pages[NR_COUNT_TYPE]; >> @@ -3652,7 +3653,7 @@ int f2fs_inode_dirtied(struct inode *inode, bool sync); >> void f2fs_inode_synced(struct inode *inode); >> int f2fs_dquot_initialize(struct inode *inode); >> int f2fs_enable_quota_files(struct f2fs_sb_info *sbi, bool rdonly); >> -int f2fs_quota_sync(struct super_block *sb, int type); >> +int f2fs_do_quota_sync(struct super_block *sb, int type); >> loff_t max_file_blocks(struct inode *inode); >> void f2fs_quota_off_umount(struct super_block *sb); >> void f2fs_save_errors(struct f2fs_sb_info *sbi, unsigned char flag); >> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c >> index ef639a6d82e5..cb9d7b6fa3ad 100644 >> --- a/fs/f2fs/super.c >> +++ b/fs/f2fs/super.c >> @@ -1740,22 +1740,28 @@ int f2fs_sync_fs(struct super_block *sb, int sync) >> >> static int f2fs_freeze(struct super_block *sb) >> { >> + struct f2fs_sb_info *sbi = F2FS_SB(sb); >> + >> if (f2fs_readonly(sb)) >> return 0; >> >> /* IO error happened before */ >> - if (unlikely(f2fs_cp_error(F2FS_SB(sb)))) >> + if (unlikely(f2fs_cp_error(sbi))) >> return -EIO; >> >> /* must be clean, since sync_filesystem() was already called */ >> - if (is_sbi_flag_set(F2FS_SB(sb), SBI_IS_DIRTY)) >> + if (is_sbi_flag_set(sbi, SBI_IS_DIRTY)) >> return -EINVAL; >> >> + sbi->umount_lock_holder = current; >> + >> /* Let's flush checkpoints and stop the thread. */ >> - f2fs_flush_ckpt_thread(F2FS_SB(sb)); >> + f2fs_flush_ckpt_thread(sbi); >> + >> + sbi->umount_lock_holder = NULL; >> >> /* to avoid deadlock on f2fs_evict_inode->SB_FREEZE_FS */ >> - set_sbi_flag(F2FS_SB(sb), SBI_IS_FREEZING); >> + set_sbi_flag(sbi, SBI_IS_FREEZING); >> return 0; >> } >> >> @@ -2332,6 +2338,8 @@ static int f2fs_remount(struct super_block *sb, int *flags, char *data) >> org_mount_opt = sbi->mount_opt; >> old_sb_flags = sb->s_flags; >> >> + sbi->umount_lock_holder = current; >> + >> #ifdef CONFIG_QUOTA >> org_mount_opt.s_jquota_fmt = F2FS_OPTION(sbi).s_jquota_fmt; >> for (i = 0; i < MAXQUOTAS; i++) { >> @@ -2555,6 +2563,8 @@ static int f2fs_remount(struct super_block *sb, int *flags, char *data) >> >> limit_reserve_root(sbi); >> *flags = (*flags & ~SB_LAZYTIME) | (sb->s_flags & SB_LAZYTIME); >> + >> + sbi->umount_lock_holder = NULL; >> return 0; >> restore_checkpoint: >> if (need_enable_checkpoint) { >> @@ -2595,6 +2605,8 @@ static int f2fs_remount(struct super_block *sb, int *flags, char *data) >> #endif >> sbi->mount_opt = org_mount_opt; >> sb->s_flags = old_sb_flags; >> + >> + sbi->umount_lock_holder = NULL; >> return err; >> } >> >> @@ -2911,7 +2923,7 @@ static int f2fs_quota_sync_file(struct f2fs_sb_info *sbi, int type) >> return ret; >> } >> >> -int f2fs_quota_sync(struct super_block *sb, int type) >> +int f2fs_do_quota_sync(struct super_block *sb, int type) >> { >> struct f2fs_sb_info *sbi = F2FS_SB(sb); >> struct quota_info *dqopt = sb_dqopt(sb); >> @@ -2959,6 +2971,16 @@ int f2fs_quota_sync(struct super_block *sb, int type) >> return ret; >> } >> >> +static int f2fs_quota_sync(struct super_block *sb, int type) >> +{ >> + int ret; >> + >> + F2FS_SB(sb)->umount_lock_holder = current; >> + ret = f2fs_do_quota_sync(sb, type); >> + F2FS_SB(sb)->umount_lock_holder = NULL; >> + return ret; >> +} >> + >> static int f2fs_quota_on(struct super_block *sb, int type, int format_id, >> const struct path *path) >> { >> @@ -2974,30 +2996,33 @@ static int f2fs_quota_on(struct super_block *sb, int type, int format_id, >> if (path->dentry->d_sb != sb) >> return -EXDEV; >> >> - err = f2fs_quota_sync(sb, type); >> + F2FS_SB(sb)->umount_lock_holder = current; >> + >> + err = f2fs_do_quota_sync(sb, type); >> if (err) >> - return err; >> + goto out; >> >> inode = d_inode(path->dentry); >> >> err = filemap_fdatawrite(inode->i_mapping); >> if (err) >> - return err; >> + goto out; >> >> err = filemap_fdatawait(inode->i_mapping); >> if (err) >> - return err; >> + goto out; >> >> err = dquot_quota_on(sb, type, format_id, path); >> if (err) >> - return err; >> + goto out; >> >> inode_lock(inode); >> F2FS_I(inode)->i_flags |= F2FS_QUOTA_DEFAULT_FL; >> f2fs_set_inode_flags(inode); >> inode_unlock(inode); >> f2fs_mark_inode_dirty_sync(inode, false); >> - >> +out: >> + F2FS_SB(sb)->umount_lock_holder = NULL; >> return 0; > Hi Chao, > Here should return err? and init err=0 in the beginning? Zhiguo, Oh, yes, let me fix this, thank you for the review. Thanks, > thanks！ >> } >> >> @@ -3009,7 +3034,7 @@ static int __f2fs_quota_off(struct super_block *sb, int type) >> if (!inode || !igrab(inode)) >> return dquot_quota_off(sb, type); >> >> - err = f2fs_quota_sync(sb, type); >> + err = f2fs_do_quota_sync(sb, type); >> if (err) >> goto out_put; >> >> @@ -3032,6 +3057,8 @@ static int f2fs_quota_off(struct super_block *sb, int type) >> struct f2fs_sb_info *sbi = F2FS_SB(sb); >> int err; >> >> + F2FS_SB(sb)->umount_lock_holder = current; >> + >> err = __f2fs_quota_off(sb, type); >> >> /* >> @@ -3041,6 +3068,9 @@ static int f2fs_quota_off(struct super_block *sb, int type) >> */ >> if (is_journalled_quota(sbi)) >> set_sbi_flag(sbi, SBI_QUOTA_NEED_REPAIR); >> + >> + F2FS_SB(sb)->umount_lock_holder = NULL; >> + >> return err; >> } >> >> @@ -4715,6 +4745,7 @@ static int f2fs_fill_super(struct super_block *sb, void *data, int silent) >> if (err) >> goto free_compress_inode; >> >> + sbi->umount_lock_holder = current; >> #ifdef CONFIG_QUOTA >> /* Enable quota usage during mount */ >> if (f2fs_sb_has_quota_ino(sbi) && !f2fs_readonly(sb)) { >> @@ -4841,6 +4872,8 @@ static int f2fs_fill_super(struct super_block *sb, void *data, int silent) >> f2fs_update_time(sbi, CP_TIME); >> f2fs_update_time(sbi, REQ_TIME); >> clear_sbi_flag(sbi, SBI_CP_DISABLED_QUICK); >> + >> + sbi->umount_lock_holder = NULL; >> return 0; >> >> sync_free_meta: >> @@ -4945,6 +4978,8 @@ static void kill_f2fs_super(struct super_block *sb) >> struct f2fs_sb_info *sbi = F2FS_SB(sb); >> >> if (sb->s_root) { >> + sbi->umount_lock_holder = current; >> + >> set_sbi_flag(sbi, SBI_IS_CLOSE); >> f2fs_stop_gc_thread(sbi); >> f2fs_stop_discard_thread(sbi); >> -- >> 2.48.1.502.g6dc24dfdaf-goog >> >> >> >> _______________________________________________ >> Linux-f2fs-devel mailing list >> Linux-f2fs-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel