From: Yang Zhang <yang.zhang.wz@gmail.com>
To: David Matlack <dmatlack@google.com>
Cc: "Wanpeng Li" <kernellwp@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvm list" <kvm@vger.kernel.org>,
"Wanpeng Li" <wanpeng.li@hotmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>
Subject: Re: [PATCH v2] KVM: halt-polling: poll if emulated lapic timer will fire soon
Date: Tue, 24 May 2016 09:13:59 +0800 [thread overview]
Message-ID: <1f925ff3-b654-e22e-9b60-23a26694aa89@gmail.com> (raw)
In-Reply-To: <CALzav=cAk1bnVLQY9NCH9EGYcTK1-D6Y1FGDBTY+0usGz1ETZA@mail.gmail.com>
On 2016/5/24 2:04, David Matlack wrote:
> On Sun, May 22, 2016 at 6:26 PM, Yang Zhang <yang.zhang.wz@gmail.com> wrote:
>> On 2016/5/21 2:37, David Matlack wrote:
>>>
>>> It's not obvious to me why polling for a timer interrupt would improve
>>> context switch latency. Can you explain a bit more?
>>
>>
>> We have a workload which using high resolution timer(less than 1ms) inside
>> guest. It rely on the timer to wakeup itself. Sometimes the timer is
>> expected to fired just after the VCPU is blocked due to execute halt
>> instruction. But the thread who is running in the CPU will turn off the
>> hardware interrupt for long time due to disk access. This will cause the
>> timer interrupt been blocked until the interrupt is re-open.
>
> Does this happen on the idle thread (swapper)? If not, halt-polling
> may not help; it only polls if there are no other runnable threads.
Yes, there is no runnable task inside guest.
>
>> For optimization, we let VCPU to poll for a while if the next timer will
>> arrive soon before schedule out. And the result shows good when running
>> several workloads inside guest.
>
> Thanks for the explanation, I appreciate it.
>
>>
>> --
>> best regards
>> yang
--
best regards
yang
next prev parent reply other threads:[~2016-05-24 1:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-19 13:27 [PATCH v2] KVM: halt-polling: poll if emulated lapic timer will fire soon Wanpeng Li
2016-05-19 13:46 ` Christian Borntraeger
2016-05-19 13:57 ` Paolo Bonzini
2016-05-19 14:52 ` Christian Borntraeger
2016-05-19 14:56 ` Paolo Bonzini
2016-05-19 15:03 ` Christian Borntraeger
2016-05-19 15:06 ` Paolo Bonzini
2016-05-19 15:42 ` Christian Borntraeger
2016-05-24 2:48 ` Wanpeng Li
2016-05-19 18:01 ` David Matlack
2016-05-19 18:36 ` David Matlack
2016-05-20 2:04 ` Yang Zhang
2016-05-20 5:53 ` Wanpeng Li
2016-05-20 18:37 ` David Matlack
2016-05-23 1:26 ` Yang Zhang
2016-05-23 18:04 ` David Matlack
2016-05-24 1:13 ` Yang Zhang [this message]
2016-05-24 1:16 ` David Matlack
2016-05-24 2:55 ` Yang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f925ff3-b654-e22e-9b60-23a26694aa89@gmail.com \
--to=yang.zhang.wz@gmail.com \
--cc=borntraeger@de.ibm.com \
--cc=dmatlack@google.com \
--cc=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=wanpeng.li@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.