All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Kanavin <alexander.kanavin@linux.intel.com>
To: zhe.he@windriver.com, openembedded-core@lists.openembedded.org
Cc: "Purdie, Richard" <richard.purdie@intel.com>
Subject: Re: [PATCH v2 0/1] kexec-tools: Upgrade to 2.0.14
Date: Wed, 28 Dec 2016 14:15:55 +0200	[thread overview]
Message-ID: <1fad67ac-8ae2-e242-9830-e89311f14b12@linux.intel.com> (raw)
In-Reply-To: <cover.1482820791.git.zhe.he@windriver.com>

On 12/27/2016 08:43 AM, zhe.he@windriver.com wrote:
> From: He Zhe <zhe.he@windriver.com>
>
> Remove kexec-aarch64.patch since it has been merged upstream
> Remove kexec-x32.patch since it has been reverted upstream
> Backport patches for kdump arm64 from:
> https://git.linaro.org/people/takahiro.akashi/kexec-tools.git
>
> v1 to v2: Remove redundant tarball link in SRC_URI

None of my comments are addressed in this new version of the patch. 
Specifically:

 > Remove kexec-aarch64.patch since it has been merged upstream
 > Remove kexec-x32.patch since it has been reverted upstream

You should also remove the actual files, not just drop them from the recipe.

 > Backport patches for kdump arm64 from:
 > https://git.linaro.org/people/takahiro.akashi/kexec-tools.git

If the patches are coming from a different repository, they are not a 
backport. Change the upstream-status to 'pending' please, or 'submitted 
(link)' if they have been submitted upstream.

 >  meta/recipes-kernel/kexec/kexec-tools_2.0.12.bb    |  37 ----
 >  meta/recipes-kernel/kexec/kexec-tools_2.0.14.bb    |  44 +++++

Please use git's rename detection when submitting patches, so we can see 
what is the difference between the two files.


Alex



  reply	other threads:[~2016-12-28 12:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-27  6:43 [PATCH v2 0/1] kexec-tools: Upgrade to 2.0.14 zhe.he
2016-12-28 12:15 ` Alexander Kanavin [this message]
2016-12-29  2:05   ` He Zhe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1fad67ac-8ae2-e242-9830-e89311f14b12@linux.intel.com \
    --to=alexander.kanavin@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@intel.com \
    --cc=zhe.he@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.