From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Tvrtko Ursulin <tursulin@ursulin.net>,
Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/i915: Stop ignoring failure to set up workaround batch buffers
Date: Fri, 19 Jan 2018 10:29:12 +0000 [thread overview]
Message-ID: <1fc48afb-a212-bf36-c587-5c6cb5b4600a@linux.intel.com> (raw)
In-Reply-To: <151635657463.1487.7960945913256146186@mail.alporthouse.com>
On 19/01/2018 10:09, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2018-01-19 10:00:05)
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Setting up the workaround batch buffers can fail either due programming
>> errors which will be caught in development, or by the inability to
>> allocate a 4k object and pin it in GGTT at runtime.
>>
>> Since this is highly unlikely, and it is not deterministic to allow driver
>> operation to continue with unknown status of workarounds, it is better to
>> fail engine initialization explicitly under those circumstances.
>
> Not entirely. Failing the driver load leaves the system without a
> display / console. Disabling GPU execution is one response, but that
> is likely to happen if the w/a requirement was severe enough.
>
> We are not expecting to see an -EIO at this point in the init sequence
> and all other errors abort the driver load.
Fair enough, I did not think about deeper consequences but only assumed
we would run without one engine. Assumptions assumptions!
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-01-19 10:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-19 10:00 [PATCH 1/3] drm/i915: Downgrade incorrect engine constructor usage warnings to development Tvrtko Ursulin
2018-01-19 10:00 ` [PATCH 2/3] drm/i915: Per-engine scratch VMA is mandatory Tvrtko Ursulin
2018-01-19 10:04 ` Chris Wilson
2018-01-19 10:00 ` [PATCH 3/3] drm/i915: Stop ignoring failure to set up workaround batch buffers Tvrtko Ursulin
2018-01-19 10:09 ` Chris Wilson
2018-01-19 10:29 ` Tvrtko Ursulin [this message]
2018-01-19 10:31 ` Chris Wilson
2018-01-19 10:43 ` ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Downgrade incorrect engine constructor usage warnings to development Patchwork
2018-01-22 17:17 ` Tvrtko Ursulin
2018-01-19 14:32 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-01-19 17:20 ` [PATCH 1/3] " Michel Thierry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fc48afb-a212-bf36-c587-5c6cb5b4600a@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.