Re: [PATCH] drm/amdgpu: Remove redundant logic in GC v9.4.3

["Lazar, Lijo" <lijo.lazar@amd.com>]

<Ping>

On 2/17/2025 10:44 AM, Lijo Lazar wrote:
> GFXOFF check is not need for GC v9.4.3. Also, save/restore list is
> available by default.
> 
> Signed-off-by: Lijo Lazar <lijo.lazar@amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 17 +----------------
>  1 file changed, 1 insertion(+), 16 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
> index f4635fc8a7ca..f1d6f4b92e99 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
> @@ -563,17 +563,6 @@ static int gfx_v9_4_3_init_rlc_microcode(struct amdgpu_device *adev,
>  	return err;
>  }
>  
> -static bool gfx_v9_4_3_should_disable_gfxoff(struct pci_dev *pdev)
> -{
> -	return true;
> -}
> -
> -static void gfx_v9_4_3_check_if_need_gfxoff(struct amdgpu_device *adev)
> -{
> -	if (gfx_v9_4_3_should_disable_gfxoff(adev->pdev))
> -		adev->pm.pp_feature &= ~PP_GFXOFF_MASK;
> -}
> -
>  static int gfx_v9_4_3_init_cp_compute_microcode(struct amdgpu_device *adev,
>  					  const char *chip_name)
>  {
> @@ -600,8 +589,6 @@ static int gfx_v9_4_3_init_cp_compute_microcode(struct amdgpu_device *adev,
>  	adev->gfx.mec2_fw_version = adev->gfx.mec_fw_version;
>  	adev->gfx.mec2_feature_version = adev->gfx.mec_feature_version;
>  
> -	gfx_v9_4_3_check_if_need_gfxoff(adev);
> -
>  out:
>  	if (err)
>  		amdgpu_ucode_release(&adev->gfx.mec_fw);
> @@ -1360,10 +1347,8 @@ static void gfx_v9_4_3_xcc_init_pg(struct amdgpu_device *adev, int xcc_id)
>  {
>  	/*
>  	 * Rlc save restore list is workable since v2_1.
> -	 * And it's needed by gfxoff feature.
>  	 */
> -	if (adev->gfx.rlc.is_rlc_v2_1)
> -		gfx_v9_4_3_xcc_enable_save_restore_machine(adev, xcc_id);
> +	gfx_v9_4_3_xcc_enable_save_restore_machine(adev, xcc_id);
>  }
>  
>  static void gfx_v9_4_3_xcc_disable_gpa_mode(struct amdgpu_device *adev, int xcc_id)