From: "flichtenheld (Code Review)" <gerrit@...515...>
To: plaisthos <arne-openvpn@...1227...>
Cc: cron2 <gert@...1296...>,
openvpn-devel <openvpn-devel@lists.sourceforge.net>
Subject: [Openvpn-devel] [L] Change in openvpn[master]: Remove openvpn_snprintf and similar functions
Date: Mon, 6 May 2024 10:00:53 +0000 [thread overview]
Message-ID: <1fef64a6886b8c1e3a0791b291219763c8a67228-EmailReviewComments-HTML@...2715...> (raw)
In-Reply-To: <gerrit.1711328743000.I07096977e3b562bcb5d2c6f11673a4175b8e12ac@...2715...>
[-- Attachment #1: Type: text/plain, Size: 1644 bytes --]
Attention is currently required from: cron2, ordex, plaisthos.
flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/547?usp=email )
Change subject: Remove openvpn_snprintf and similar functions
......................................................................
Patch Set 5:
(1 comment)
File src/openvpn/proxy.c:
http://gerrit.openvpn.net/c/openvpn/+/547/comment/1cc5661d_bc0d1f81 :
PS4, Line 966:
> What do you mean with spurious? It changes openvpn_snprintf to snprintf
Sorry, seems I was too brief. I meant the empty line you inserted here. Either way, not important.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/547?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I07096977e3b562bcb5d2c6f11673a4175b8e12ac
Gerrit-Change-Number: 547
Gerrit-PatchSet: 5
Gerrit-Owner: plaisthos <arne-openvpn@...1227...>
Gerrit-Reviewer: cron2 <gert@...1296...>
Gerrit-Reviewer: flichtenheld <frank@...2641...>
Gerrit-Reviewer: ordex <a@...2181...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...1227...>
Gerrit-Attention: cron2 <gert@...1296...>
Gerrit-Attention: ordex <a@...2181...>
Gerrit-Comment-Date: Mon, 06 May 2024 10:00:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: plaisthos <arne-openvpn@...1227...>
Comment-In-Reply-To: flichtenheld <frank@...2641...>
Gerrit-MessageType: comment
[-- Attachment #2: Type: text/html, Size: 3026 bytes --]
next prev parent reply other threads:[~2024-05-06 10:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <gerrit.1711328743000.I07096977e3b562bcb5d2c6f11673a4175b8e12ac@...2715...>
2024-03-25 1:05 ` [Openvpn-devel] [L] Change in openvpn[master]: Remove openvpn_snprintf and similar functions plaisthos (Code Review)
2024-03-25 1:15 ` ordex (Code Review)
2024-03-25 7:16 ` [Openvpn-devel] [PATCH v1] " Gert Doering
2024-03-25 11:14 ` [Openvpn-devel] [L] Change in openvpn[master]: " plaisthos (Code Review)
2024-03-25 18:04 ` plaisthos (Code Review)
2024-03-27 10:48 ` ordex (Code Review)
2024-04-08 6:59 ` ordex (Code Review)
2024-04-08 7:14 ` [Openvpn-devel] [PATCH v2] " Gert Doering
2024-04-08 8:22 ` [Openvpn-devel] [L] Change in openvpn[master]: " cron2 (Code Review)
2024-05-02 17:42 ` plaisthos (Code Review)
2024-05-02 17:44 ` plaisthos (Code Review)
2024-05-02 17:44 ` plaisthos (Code Review)
2024-05-03 15:49 ` flichtenheld (Code Review)
2024-05-03 16:44 ` plaisthos (Code Review)
2024-05-03 16:47 ` plaisthos (Code Review)
2024-05-03 16:48 ` plaisthos (Code Review)
2024-05-06 10:00 ` flichtenheld (Code Review) [this message]
2024-05-06 10:18 ` flichtenheld (Code Review)
2024-05-06 10:27 ` [Openvpn-devel] [PATCH v5] " Gert Doering
2024-05-06 15:27 ` [Openvpn-devel] [PATCH applied] " Gert Doering
2024-05-06 15:28 ` [Openvpn-devel] [L] Change in openvpn[master]: " cron2 (Code Review)
2024-05-06 15:28 ` cron2 (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fef64a6886b8c1e3a0791b291219763c8a67228-EmailReviewComments-HTML@...2715... \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.