From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B339C98324 for ; Fri, 25 Sep 2026 12:47:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ndeWH5KWVnrljnilyKEYQSkSY93BoXxpbkbvndrHlcc=; b=mxoOQU6we/0pO6 WPP89MY1miRUKDvsbGC/AOvcnPljMunLD3SJn13XvuVsCsOGKdyL5+tRT0pzafioh33BAIOW4MYrf HqgcwlJQuFALFURjjAUFPCDiSvbZZJaKcDI6xbNvJCHycWzTG2IowXrA/lD5oj0J/WF0vODc8NTyo 3WTTAPMQB6No5rZupySzyPFlC15B2GibWPbJuwimxlgRqfdGqM32SQrenpEzpXtVkE/BNSdeAcybq WUTIrUMgxcC0f1HGqtRtIX05H5m2hz17iK7aKuohDUZGPY+gTFe3KMhuUrPCn0fKIGKdDcnmutA3F xwhtRXlKHK5zxkQ/31Fg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xA5L6-0000000DM5E-2XAj; Fri, 25 Sep 2026 12:47:44 +0000 Received: from mail-wm2-x10.google.com ([2a00:1450:4864:31::10]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xA5Kz-0000000DM0N-26HH for linux-rockchip@lists.infradead.org; Fri, 25 Sep 2026 12:47:41 +0000 Received: by mail-wm2-x10.google.com with SMTP id 5b1f17b1804b1-49b912d3920so6542335e9.1 for ; Fri, 25 Sep 2026 05:47:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1790340455; x=1790945255; darn=lists.infradead.org; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=hVgejJErSi/df8/6avC+kCC2kZbgZL+1y5/eEh1fX5I=; b=RY4+Pxn59wsor4m5G30G6lelwdvxY+SP9I7gE8ydAQxEI2sEUaQ87OwtQ7JPO3tebe MspalvXufDkG4dOKTnOxuCNmmKk+9wZeF0iT2yoYnc3ZtrDCvVsg5EYjJonFZMMOtQIa tvtcCa93KrGyGiNWoO4zui1b/ORfnUUBgMhPbyxYtUZSYstz9Lsuzm55dJsPbkh04CbQ 4JkvT0FSFx1CAmNOyuA5ouMro9kDZkGx3GMort77K0BeaUaS5btmizNUyjz/udDbYmEi sPTggDNj1to0FDFvJ92WeaYWI3pFz4lNz9QNcy60+YVB8SFYNaOWfu7CRkxOnhLzJT2j GGbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790340455; x=1790945255; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=hVgejJErSi/df8/6avC+kCC2kZbgZL+1y5/eEh1fX5I=; b=Nr5Mm62MSnSuRKLptBaQ4x00mAacK01IJH7jCDbINw7h9C6EzZxhkWRfMlvUYE6FPZ TbcjeolX2mzwUvRIqNFiNxGhoHeFCUqdHgN48OQ7ZmUxhf8w6fthumO1UFxHQF7trkHF BZEZgTp0XrlqVf2VyjrBP9xwP4zBCrnbP9AeH0WCCuxKHEzlL98zzHlwN8fonycuP6d7 AnxjLzfsy9GY2rl4mIx7yWt7DDbXDIAft658BUr1gYEgC2MiO2EHzBtn3drIzIfiWobu Roo2VHWIzCqQZu4x+M54nLhPEoFdliQqa9S05DogHqeoLvXOS1CtioynMcxRtgqqiMw5 MvbQ== X-Forwarded-Encrypted: i=1; AKwUvBzI7eUcgiEDmzrdFR6VeBuPqfd1NLCn3bY/qMHorPhaRXanNzCbVSk4Ft09DgHY0AMhekBpWRAAhgAiF/mMbA==@lists.infradead.org X-Gm-Message-State: AFuF++lES5CanDImVkD0LPPmCkiyoYr92rz1ACFnIIxxU6W1ewgb4VNh f4pnB7kJkf+RyaRxYsgilc123n6aUYJPItD5pKuvI0+9mv/knGy3bGEtjkj5YqMetwk= X-Gm-Gg: AYBFou1e6nvdQtQmKNJ3HX3ws3U4eJ6uqlaPViT0baDkTk/4+tKiHN693eRb9lbBUaX wff1wj4afh7pzMB4JNBDVR7JrCvJv16zZI0Q3EehNAwLVHAEX9DHpw3o6NplTavKZKYZ5tIxEUI FPahZvfO6bwUC2OYKAlyku7jCQLsX1BhRLEJzlAXMaTKlGGcBs7KZ/HDXgEVxPGcezNhWZDl8x+ WTGtW7xtH5t5pE3OSh4TSj3jb5dFGx5011fhuvi9uTFJrvrjeGyEXrvWjKoyMgHpUuAUsGzvI8A Knse8XGjZDul8J3AZeLiGgRcD/L1tt2NHCwn+XOAVOqasd9oqIzYtOVuBEyeoSXA19fhkqrj4Qp hkSFZIR30O9DYwUvA0gBB6y5ejkSADexxivg9GnSYz+lstaTy8onZovadTkSQ/zZ58QY+gJTIe3 grXOLaHRqb4h98ckEWenEt9B1WMjH3BS3Jd+9N6s7e1KmXkrR1bYQdNfoWDrjVnwXgjoo00wEbf SkK81CVHuNa9OwUiQ== X-Received: by 2002:a05:600c:6090:b0:49e:6e94:7cae with SMTP id 5b1f17b1804b1-49fe670424cmr91000685e9.28.1790340455565; Fri, 25 Sep 2026 05:47:35 -0700 (PDT) Received: from localhost (82-67-6-57.subs.proxad.net. [82.67.6.57]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49ff27eabc1sm58460335e9.15.2026.09.25.05.47.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Sep 2026 05:47:32 -0700 (PDT) From: Jerome Brunet To: Michal Wilczynski , Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrzej Hajda , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Lee Jones , Andy Yan , Philipp Zabel , Emil Renner Berthing , Hal Feng , Michael Turquette , Stephen Boyd , Brian Masney , Heiko Stuebner , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Dominique Belhachemi , Brian Masney , Jerome Brunet Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, mfd@lists.linux.dev, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, Andy Yan , Marek Szyprowski , Maud Spierings , Graham Markall , Icenowy Zheng , Michal Wilczynski Subject: Re: [PATCH v3 13/19] clk: starfive: jh7110-vout: Allow pixel clock rate propagation In-Reply-To: <20260904-jh7110-clean-send-v3-13-484f9ae72715@samsung.com> References: <20260904-jh7110-clean-send-v3-0-484f9ae72715@samsung.com> <20260904-jh7110-clean-send-v3-13-484f9ae72715@samsung.com> Date: Fri, 25 Sep 2026 14:47:30 +0200 Message-ID: <1j5wzt8plp.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260925_054737_636808_262602EF X-CRM114-Status: GOOD ( 15.86 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On ven. 04 sept. 2026 at 15:27, Michal Wilczynski wrote: > The dc8200_pix0 and dc8200_pix1 MUXes feed the display controller, and > the rate they carry is ultimately produced by the HDMI PHY, which > registers hdmitx0_pixelclk as a clock provider. > > Add CLK_SET_RATE_PARENT to both MUXes so a rate requested on them > reaches that parent, instead of being clamped to whatever rate the > parent already happens to run at. > > Co-developed-by: Dominique Belhachemi > Signed-off-by: Dominique Belhachemi > Signed-off-by: Michal Wilczynski > --- > drivers/clk/starfive/clk-starfive-jh7110-vout.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/starfive/clk-starfive-jh7110-vout.c b/drivers/clk/starfive/clk-starfive-jh7110-vout.c > index bad20d5d794a72f071b4d547b7304786a8ba9afa..aeba42cd3c44ba205ced52b1826d2d2de82ad78f 100644 > --- a/drivers/clk/starfive/clk-starfive-jh7110-vout.c > +++ b/drivers/clk/starfive/clk-starfive-jh7110-vout.c > @@ -40,10 +40,12 @@ static const struct jh71x0_clk_data jh7110_voutclk_data[] = { > JH71X0_GATE(JH7110_VOUTCLK_DC8200_AXI, "dc8200_axi", 0, JH7110_VOUTCLK_VOUT_TOP_AXI), > JH71X0_GATE(JH7110_VOUTCLK_DC8200_CORE, "dc8200_core", 0, JH7110_VOUTCLK_VOUT_TOP_AXI), > JH71X0_GATE(JH7110_VOUTCLK_DC8200_AHB, "dc8200_ahb", 0, JH7110_VOUTCLK_VOUT_TOP_AHB), > - JH71X0_GMUX(JH7110_VOUTCLK_DC8200_PIX0, "dc8200_pix0", 0, 2, > + JH71X0_GMUX(JH7110_VOUTCLK_DC8200_PIX0, "dc8200_pix0", > + CLK_SET_RATE_PARENT | CLK_SET_RATE_NO_REPARENT, 2, I see that you've added CLK_SET_RATE_NO_REPARENT following a previous sashiko advice. Note that saying it will 'hijack' the parent without it is kind of strong. It is fine to let a mux reparent while setting a rate, as long as you understand the possible consequences for the rest of the tree. Regardless Reviewed-by: Jerome Brunet > JH7110_VOUTCLK_DC8200_PIX, > JH7110_VOUTCLK_HDMITX0_PIXELCLK), > - JH71X0_GMUX(JH7110_VOUTCLK_DC8200_PIX1, "dc8200_pix1", 0, 2, > + JH71X0_GMUX(JH7110_VOUTCLK_DC8200_PIX1, "dc8200_pix1", > + CLK_SET_RATE_PARENT | CLK_SET_RATE_NO_REPARENT, 2, > JH7110_VOUTCLK_DC8200_PIX, > JH7110_VOUTCLK_HDMITX0_PIXELCLK), > /* LCD */ > > -- > 2.34.1 > -- Jerome _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 497B2C98321 for ; Fri, 25 Sep 2026 12:47:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4wBrC2NL4BA5d+5Vl3BcJcrvk6bT/Qy1AIZAW+9f91s=; b=2v0hhDKYrp1WGi l8xWsB8TG0TeSafBbBgtVNVjDWBUfyreVW4JvldGeCCJRu2IeBGya9RBbsXuwT893uIstNbyhrJiD A7iitOeWwApD2VgUcr5uvuc79YkmuN/FUjmf0n3aon7jg2CHwtKhQmAzMBQfwPZv0bm2Y+30LrW5P cfEw0fw4I8PAPjMkNJQ6IP+0JHporlgUWjZbXwVRuwv34FwVI52FcOclzqtXJjSeZPGH2t5qSs13e +VBBCAAFV9M0yKALnlVCzr1WQEwBIdscglimVdCiJ33G8Z2nnhClzLCDNZeM3xFFqbL3ToK9ICzGM iHKdJyJZoG/t62tOuPYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xA5L7-0000000DM5o-3uMT; Fri, 25 Sep 2026 12:47:45 +0000 Received: from mail-wm2-x11.google.com ([2a00:1450:4864:31::11]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xA5Kz-0000000DM0R-25wn for linux-phy@lists.infradead.org; Fri, 25 Sep 2026 12:47:42 +0000 Received: by mail-wm2-x11.google.com with SMTP id 5b1f17b1804b1-49b912d3931so7127475e9.3 for ; Fri, 25 Sep 2026 05:47:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1790340455; x=1790945255; darn=lists.infradead.org; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=hVgejJErSi/df8/6avC+kCC2kZbgZL+1y5/eEh1fX5I=; b=RY4+Pxn59wsor4m5G30G6lelwdvxY+SP9I7gE8ydAQxEI2sEUaQ87OwtQ7JPO3tebe MspalvXufDkG4dOKTnOxuCNmmKk+9wZeF0iT2yoYnc3ZtrDCvVsg5EYjJonFZMMOtQIa tvtcCa93KrGyGiNWoO4zui1b/ORfnUUBgMhPbyxYtUZSYstz9Lsuzm55dJsPbkh04CbQ 4JkvT0FSFx1CAmNOyuA5ouMro9kDZkGx3GMort77K0BeaUaS5btmizNUyjz/udDbYmEi sPTggDNj1to0FDFvJ92WeaYWI3pFz4lNz9QNcy60+YVB8SFYNaOWfu7CRkxOnhLzJT2j GGbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790340455; x=1790945255; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=hVgejJErSi/df8/6avC+kCC2kZbgZL+1y5/eEh1fX5I=; b=iQzxDW4TfSWA9otzvN4ZQPiI+YKD6OxtR1fN8KrgX7t/3T0gnWRozuhfjNs6Oo2nOX qeuG/vZ5HdPUQEaZgUDfjqvDM/J4PZMCgs4qKw5gJUBpYG5Fl1NxRiLq0dBzetIy5wp4 8GyGgpbsXTlf3Vcih1nxb0sXRj2zxuUqhJW8PeHBLMknoFJFkosiW1R9rA3w4qlihXu8 8/DMQNCxKQNpgqNQQFVuLNlti5xyjKdbRK75smj1G6Ya4Xs0yplI9WoJ30bf+h/GOF07 2Euo98TYW5eRr8yM1fkHjatWFYj2xK7qlXTr6oEN2AajvyiBVgN5mweYAVuLWf6f85id NHDg== X-Gm-Message-State: AFuF++luFSrm4W7PddnkGaG1rmOXYgHgKr3+hGfB4xz3EFB1rKs3Fv2b yzWfXMLRhds+6jYztK4lYxtgMEbQArQW4LQdwtkyj4D2xGk2gVv0oQBUb1t3qwqEZkI= X-Gm-Gg: AYBFou0c+rUvMIEWXEVcjtsy2KjhudgBwGKCOrTNqExkRLu58ZOxFjx8UygKcL1UpoV Kp9JSE2GCYDqhpHBCmUP0jjX0zba4zylqxh8HyrWD8EEBl9nqe2rd+bPwXqLQVB7Hsv5Dp9lT14 1e8d4Ys6d49hRBNtB0Rl0elINUHwOFv93KugPfpkPp0/9jnYDDQkXxTcRq9VYf4cs9wTtUWYPsw pGQLzKWDdsiCrQirg+vdCMKCubRkDLO5m4K2QzNie0eGCd+DSZmjOfHPKMNhjhHQpDc9qkB4+Pl CwimZgCuGfCDB9zfrLj8XM8OrliM0YV4qqurZMWPFYYoNSbDifGFKCCK1ZRgPGMP8K4kf8fvCai 1ulIRUlu4SfMWkvaAWWTGJQr7NsenE5pH7cTN1kAPH3HtnGay5WdFK1V4lUi4Cr/kZCvpnGyOhi l14PIlxmbqU8XbCMVgGpx+iQH5tP+DNfAjMlv4VL+p9fJhLah5YfRKn2yzCR21Yq/+FhcaE3uLz 2upKkn07/7A8ZYrqg== X-Received: by 2002:a05:600c:6090:b0:49e:6e94:7cae with SMTP id 5b1f17b1804b1-49fe670424cmr91000685e9.28.1790340455565; Fri, 25 Sep 2026 05:47:35 -0700 (PDT) Received: from localhost (82-67-6-57.subs.proxad.net. [82.67.6.57]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49ff27eabc1sm58460335e9.15.2026.09.25.05.47.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Sep 2026 05:47:32 -0700 (PDT) From: Jerome Brunet To: Michal Wilczynski , Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrzej Hajda , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Lee Jones , Andy Yan , Philipp Zabel , Emil Renner Berthing , Hal Feng , Michael Turquette , Stephen Boyd , Brian Masney , Heiko Stuebner , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Dominique Belhachemi , Brian Masney , Jerome Brunet Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, mfd@lists.linux.dev, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, Andy Yan , Marek Szyprowski , Maud Spierings , Graham Markall , Icenowy Zheng , Michal Wilczynski Subject: Re: [PATCH v3 13/19] clk: starfive: jh7110-vout: Allow pixel clock rate propagation In-Reply-To: <20260904-jh7110-clean-send-v3-13-484f9ae72715@samsung.com> References: <20260904-jh7110-clean-send-v3-0-484f9ae72715@samsung.com> <20260904-jh7110-clean-send-v3-13-484f9ae72715@samsung.com> Date: Fri, 25 Sep 2026 14:47:30 +0200 Message-ID: <1j5wzt8plp.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260925_054737_660009_4E39DC2F X-CRM114-Status: GOOD ( 15.65 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On ven. 04 sept. 2026 at 15:27, Michal Wilczynski wrote: > The dc8200_pix0 and dc8200_pix1 MUXes feed the display controller, and > the rate they carry is ultimately produced by the HDMI PHY, which > registers hdmitx0_pixelclk as a clock provider. > > Add CLK_SET_RATE_PARENT to both MUXes so a rate requested on them > reaches that parent, instead of being clamped to whatever rate the > parent already happens to run at. > > Co-developed-by: Dominique Belhachemi > Signed-off-by: Dominique Belhachemi > Signed-off-by: Michal Wilczynski > --- > drivers/clk/starfive/clk-starfive-jh7110-vout.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/starfive/clk-starfive-jh7110-vout.c b/drivers/clk/starfive/clk-starfive-jh7110-vout.c > index bad20d5d794a72f071b4d547b7304786a8ba9afa..aeba42cd3c44ba205ced52b1826d2d2de82ad78f 100644 > --- a/drivers/clk/starfive/clk-starfive-jh7110-vout.c > +++ b/drivers/clk/starfive/clk-starfive-jh7110-vout.c > @@ -40,10 +40,12 @@ static const struct jh71x0_clk_data jh7110_voutclk_data[] = { > JH71X0_GATE(JH7110_VOUTCLK_DC8200_AXI, "dc8200_axi", 0, JH7110_VOUTCLK_VOUT_TOP_AXI), > JH71X0_GATE(JH7110_VOUTCLK_DC8200_CORE, "dc8200_core", 0, JH7110_VOUTCLK_VOUT_TOP_AXI), > JH71X0_GATE(JH7110_VOUTCLK_DC8200_AHB, "dc8200_ahb", 0, JH7110_VOUTCLK_VOUT_TOP_AHB), > - JH71X0_GMUX(JH7110_VOUTCLK_DC8200_PIX0, "dc8200_pix0", 0, 2, > + JH71X0_GMUX(JH7110_VOUTCLK_DC8200_PIX0, "dc8200_pix0", > + CLK_SET_RATE_PARENT | CLK_SET_RATE_NO_REPARENT, 2, I see that you've added CLK_SET_RATE_NO_REPARENT following a previous sashiko advice. Note that saying it will 'hijack' the parent without it is kind of strong. It is fine to let a mux reparent while setting a rate, as long as you understand the possible consequences for the rest of the tree. Regardless Reviewed-by: Jerome Brunet > JH7110_VOUTCLK_DC8200_PIX, > JH7110_VOUTCLK_HDMITX0_PIXELCLK), > - JH71X0_GMUX(JH7110_VOUTCLK_DC8200_PIX1, "dc8200_pix1", 0, 2, > + JH71X0_GMUX(JH7110_VOUTCLK_DC8200_PIX1, "dc8200_pix1", > + CLK_SET_RATE_PARENT | CLK_SET_RATE_NO_REPARENT, 2, > JH7110_VOUTCLK_DC8200_PIX, > JH7110_VOUTCLK_HDMITX0_PIXELCLK), > /* LCD */ > > -- > 2.34.1 > -- Jerome -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99F46C98321 for ; Fri, 25 Sep 2026 12:48:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gYlpK4ydfNs9ciNh/j586QHLkP0FGLrqA+CVc3biOik=; b=y42L35KjjFi7LX IMhMYOd57y0rL6YMmdg/C26qhYcetBKt4WZAinZKWtne1hLiHgaVL8v1vyUMNt/lFfXzuFmIibku3 SuUZBQnXtijteLL0/QPNOm1JaKP8IRa3zDZASWcDNFcWCl3ii254Rms60L7dYPMfUtTsW8axrL2pU X9KpoSOuMICkDC7vhjGbubl3WBxpSN5IqT7q0AMW1Bg4Z4ePUK4ImDLU8GXHo+bkCGAXv4mA0iMso h4//HrlFGuy3qZMlxkKyiVLczk0g1To9iq4AYwP+A1p7NRssErLAWaJ9j7V6VveG0X2cCRGDH+f9h Rp3JC3cGs6GgAlQNLfzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xA5L7-0000000DM5k-3Ndd; Fri, 25 Sep 2026 12:47:45 +0000 Received: from mail-wm2-x11.google.com ([2a00:1450:4864:31::11]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xA5Kz-0000000DM0O-26Nw for linux-riscv@lists.infradead.org; Fri, 25 Sep 2026 12:47:42 +0000 Received: by mail-wm2-x11.google.com with SMTP id 5b1f17b1804b1-49b912d3920so6542345e9.1 for ; Fri, 25 Sep 2026 05:47:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1790340455; x=1790945255; darn=lists.infradead.org; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=hVgejJErSi/df8/6avC+kCC2kZbgZL+1y5/eEh1fX5I=; b=RY4+Pxn59wsor4m5G30G6lelwdvxY+SP9I7gE8ydAQxEI2sEUaQ87OwtQ7JPO3tebe MspalvXufDkG4dOKTnOxuCNmmKk+9wZeF0iT2yoYnc3ZtrDCvVsg5EYjJonFZMMOtQIa tvtcCa93KrGyGiNWoO4zui1b/ORfnUUBgMhPbyxYtUZSYstz9Lsuzm55dJsPbkh04CbQ 4JkvT0FSFx1CAmNOyuA5ouMro9kDZkGx3GMort77K0BeaUaS5btmizNUyjz/udDbYmEi sPTggDNj1to0FDFvJ92WeaYWI3pFz4lNz9QNcy60+YVB8SFYNaOWfu7CRkxOnhLzJT2j GGbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790340455; x=1790945255; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=hVgejJErSi/df8/6avC+kCC2kZbgZL+1y5/eEh1fX5I=; b=RzbEAqXr7WWPVxxOEWKUZ/NrJ8T4yU6J0mqPsrptMVXvMn1twZcoh8QJI2/oaiEvL+ 9HPIRSkuBi/PRvPXqQ8kqjC2Lxg5oUjS1/Fw59RU2aELQjZW3jGCPSgrQMzAaV10b17J q9wojG6ZqhvXjWA2RxydZ554IMquymCvjbusofy1xphg1pmsz307uRUny4U9SaNvTPAM cTqLr7DSvqUTOb2BiU2HsnEoFs7zmhthZiHS91mMOnbnbSyufR9EStXmBIHKRLEgk++l A0jxwEtH5ea/+igAqQOp7Lr/Vqz3xp7BjwgrV6Kq/k730P0ngboLL/uHX3IbnfOZ/n6s +eZg== X-Forwarded-Encrypted: i=1; AKwUvBwDNBX2eFjhx/iLtzu7QZx0NvpxKRda0YdYDIaHoeK4+78ch6L9A8lBYqdh8U12Gemp/0oN+mCddCcA8g==@lists.infradead.org X-Gm-Message-State: AFuF++kZcDsoFAYB4qVWAsYyTxtCK7gr8HNTe3kJp8A0s8dRxeVtFpOT m+BDyyAlyO5ln0w2T1bj835pW7klSigUZNEzF1kvzUbXjhCM5+YR/Q72Vpt/R8Y12bs= X-Gm-Gg: AYBFou2ePrwaOmeisn6Y1edxLUnx/wX6xbmVqRdcTWPHNzX8Ykw9eed/u8jYmHaLtEq Nuar3OumvVnzqknOZ6x/058vvRYYxvssMghZHDncg2KTsCtkJRcsimOvWIifTrluKdL65s5sFcD H4dCAxkpoISo9tnBsXSChwWdvs3DcuECEEXXFPydzlNmSrgni18ND6PIJJaS0QOOlyJDdPTO1l0 KMwWCdVnOxq3uHH1xbV8gvPlPlD9csXma6OMcGbpekJWHnfkGxe4DiIrPen1YVLlevwbDV+sAdb uTzkTh4N6Gn0PLw7qehPrJeaZILww4sGPiRdLk7oa/FZx1pxvjN+EpMVuosu5l3H/1OwZx51Yxq BweQG8cuAmZ33NNTreyEUZzS1leQJCZYC8NaJzauHCyd+wgBx9oqyEv93HEg7g2fvWPfMYKh0V0 SkQcthTQQlkReU6gpvuu54r/U1CwRldViTnP3xpBsUZfBWo1tK9PLNRZfcOV64EaUObEqSvwuCu iR/Wzy9VoisQKNzDw== X-Received: by 2002:a05:600c:6090:b0:49e:6e94:7cae with SMTP id 5b1f17b1804b1-49fe670424cmr91000685e9.28.1790340455565; Fri, 25 Sep 2026 05:47:35 -0700 (PDT) Received: from localhost (82-67-6-57.subs.proxad.net. [82.67.6.57]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49ff27eabc1sm58460335e9.15.2026.09.25.05.47.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Sep 2026 05:47:32 -0700 (PDT) From: Jerome Brunet To: Michal Wilczynski , Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrzej Hajda , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Lee Jones , Andy Yan , Philipp Zabel , Emil Renner Berthing , Hal Feng , Michael Turquette , Stephen Boyd , Brian Masney , Heiko Stuebner , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Dominique Belhachemi , Brian Masney , Jerome Brunet Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, mfd@lists.linux.dev, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, Andy Yan , Marek Szyprowski , Maud Spierings , Graham Markall , Icenowy Zheng , Michal Wilczynski Subject: Re: [PATCH v3 13/19] clk: starfive: jh7110-vout: Allow pixel clock rate propagation In-Reply-To: <20260904-jh7110-clean-send-v3-13-484f9ae72715@samsung.com> References: <20260904-jh7110-clean-send-v3-0-484f9ae72715@samsung.com> <20260904-jh7110-clean-send-v3-13-484f9ae72715@samsung.com> Date: Fri, 25 Sep 2026 14:47:30 +0200 Message-ID: <1j5wzt8plp.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260925_054737_601396_944E0583 X-CRM114-Status: GOOD ( 15.65 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On ven. 04 sept. 2026 at 15:27, Michal Wilczynski wrote: > The dc8200_pix0 and dc8200_pix1 MUXes feed the display controller, and > the rate they carry is ultimately produced by the HDMI PHY, which > registers hdmitx0_pixelclk as a clock provider. > > Add CLK_SET_RATE_PARENT to both MUXes so a rate requested on them > reaches that parent, instead of being clamped to whatever rate the > parent already happens to run at. > > Co-developed-by: Dominique Belhachemi > Signed-off-by: Dominique Belhachemi > Signed-off-by: Michal Wilczynski > --- > drivers/clk/starfive/clk-starfive-jh7110-vout.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/starfive/clk-starfive-jh7110-vout.c b/drivers/clk/starfive/clk-starfive-jh7110-vout.c > index bad20d5d794a72f071b4d547b7304786a8ba9afa..aeba42cd3c44ba205ced52b1826d2d2de82ad78f 100644 > --- a/drivers/clk/starfive/clk-starfive-jh7110-vout.c > +++ b/drivers/clk/starfive/clk-starfive-jh7110-vout.c > @@ -40,10 +40,12 @@ static const struct jh71x0_clk_data jh7110_voutclk_data[] = { > JH71X0_GATE(JH7110_VOUTCLK_DC8200_AXI, "dc8200_axi", 0, JH7110_VOUTCLK_VOUT_TOP_AXI), > JH71X0_GATE(JH7110_VOUTCLK_DC8200_CORE, "dc8200_core", 0, JH7110_VOUTCLK_VOUT_TOP_AXI), > JH71X0_GATE(JH7110_VOUTCLK_DC8200_AHB, "dc8200_ahb", 0, JH7110_VOUTCLK_VOUT_TOP_AHB), > - JH71X0_GMUX(JH7110_VOUTCLK_DC8200_PIX0, "dc8200_pix0", 0, 2, > + JH71X0_GMUX(JH7110_VOUTCLK_DC8200_PIX0, "dc8200_pix0", > + CLK_SET_RATE_PARENT | CLK_SET_RATE_NO_REPARENT, 2, I see that you've added CLK_SET_RATE_NO_REPARENT following a previous sashiko advice. Note that saying it will 'hijack' the parent without it is kind of strong. It is fine to let a mux reparent while setting a rate, as long as you understand the possible consequences for the rest of the tree. Regardless Reviewed-by: Jerome Brunet > JH7110_VOUTCLK_DC8200_PIX, > JH7110_VOUTCLK_HDMITX0_PIXELCLK), > - JH71X0_GMUX(JH7110_VOUTCLK_DC8200_PIX1, "dc8200_pix1", 0, 2, > + JH71X0_GMUX(JH7110_VOUTCLK_DC8200_PIX1, "dc8200_pix1", > + CLK_SET_RATE_PARENT | CLK_SET_RATE_NO_REPARENT, 2, > JH7110_VOUTCLK_DC8200_PIX, > JH7110_VOUTCLK_HDMITX0_PIXELCLK), > /* LCD */ > > -- > 2.34.1 > -- Jerome _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm2-f13.google.com (mail-wm2-f13.google.com [74.125.225.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C4E73AEF34 for ; Fri, 25 Sep 2026 12:47:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790340460; cv=none; b=Eu05Swq1zax3XPBbQnGBbTX6StFWPj/hpo1BbOIEYkL3/Rq8OfgOx4Pdrd0wW+viP0PtC8mxAX9ZVcbQKteyZswudsheNIH7RI39aMT0DInwICUHEb77OrylV/QAg909rrvyx/5e3mOsK4HMUquJM0dvLDwf7kKMjZaeF42XMv8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790340460; c=relaxed/simple; bh=X8SD06Xsb+QlpqJHnrtPeIbPCA/K3oHZVylpioAlIxc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=UOPRBcJ55AntIP5kJ2GkKOduYZ8x7tj667Bb7THKF0XWWmeNfP3j1wNf25ypEbdQW7LAgTxXcgk5cl27xA69MH1p4gx7RqP0e+QbbzR168BJ7rIMVSycZijyvH3dKjzu0oo1rPIZA3m+rf58e6fNEz1GiQOALZErqf3GQgBOzCM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=JOki174R; arc=none smtp.client-ip=74.125.225.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="JOki174R" Received: by mail-wm2-f13.google.com with SMTP id 5b1f17b1804b1-49b912d3920so6542365e9.1 for ; Fri, 25 Sep 2026 05:47:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1790340455; x=1790945255; darn=vger.kernel.org; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=hVgejJErSi/df8/6avC+kCC2kZbgZL+1y5/eEh1fX5I=; b=JOki174RcaL6QezS2v04KMA++qfhwEcc/7Y/iyeeN4QUOg0KgoFHc2qvMwkjehyM0l /MM83apeVoE/ukdFju+vMP6ixPDUVXHVnLOFvhTIKPCZBuP38+Q8dhyJMPQrNkgMcqQG Ggi7Ob5w4RjXhnEvCT1mYkhj58D4a7SH9rtWnuWX9LymsFP915LlOzrfpxmV3IeFtY3k ZZglkPNYt1NUUBsYR4i6PB28CRkbcYKCgjLctVa3jNvyeie8iRyDH1ZV+3Hou4qrm+SZ RcP0rRhukcssFLnOFyba804gTusswmMH3XqHeiogcGlX7otPN4kCF5PQDPfw7nqL8aAu wRUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790340455; x=1790945255; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=hVgejJErSi/df8/6avC+kCC2kZbgZL+1y5/eEh1fX5I=; b=vO//ZCJSJGQk2o46QyfSkesX1kvgKcEntQvX1maJxI5dQ7Eo3xVGTxX70zDNkNcWCn Dgf+0CdtY47X0jlWBKneJqLY8KQbId+fzmK8CkcHvYzt/qxgy8KJUJptpxYkhVBbJBl+ tPAvvtEDEIRaC5E4q2JwPxThQVIwXpnjbyiTXUEz0IwKVaOFIMcYBsVyEC2zi+WUI1mk v4+fPiX1oSDQufgZBCCD9WuMqIkneJ606jGcZPGToMnfY9cag+9LcLBc4Lp0ppKcxTCE V9UMo11bMXhE7hO9982G+U1BgMrFR+rdsUBw3RFaxWHdxjH74z1RfBULOFsX5BIDutWk 8xng== X-Forwarded-Encrypted: i=1; AKwUvBwGvEKVoEdhCchWVyk55J4oYFjMEqq0+wIAMJSQRMt7PhnPYWQkq3funkVeUuJqbjRghkHqOhpOR4dG@vger.kernel.org X-Gm-Message-State: AFuF++mZXx58l3xPzhWDQ0sn626lmCmRuC4ZWh0eiRg1fHZXEoWBYkvo OAkGimyYI2+jtqrjks574rleBtvLqdkJSFY9Gvv0T/FqJxdhhwECwq7IE5ALo08JZ1c= X-Gm-Gg: AYBFou0u4qtlwRm9ooMYgHc0YKtjGRbP077agF7cwuZFVeWVKKAnmuD2vYKqZBfL5r2 UDu47mLmbxOxR3Rrw43uP0pyrrOtfCpScFFIi01rhK8f6oSdHsKw5zwc2xCxAb8l86wJ4pcUoYK kDTUgWidMTNg+1tVqyRB9lwn+mR9+K1wBYq3WUAkLsa4W2pgN9dqmohDCxqM/ll6+IE+sVYBXW6 jPfh7Iax5y6a1FeRwcLYEPWSSYXcd0xxqYAsoIl/niv4f42QpD58qo0VbWKA449tod3/ywyUsgj 9iMghbi2Ot6WbSrycr8hcdiC8aOPolVhz+IA9bO9qnFhDSpfeewUZPy6k1QmwKZp5TeHkdNG10C VN8JHe22VdD/j6IIJVM74uR/JFGTTLArl5Cv792rybDOqPhJ/bb+3Oy+nrdnfmRRejt70w9RBmF kTL1fzAPKa2vWljgACdyqM+Am85JcPU/GxV2L+jTSrgudxSYnvMuyZFcjeLbz2kHscNgcJcbg5R u96sClUiGqeVFqWcg== X-Received: by 2002:a05:600c:6090:b0:49e:6e94:7cae with SMTP id 5b1f17b1804b1-49fe670424cmr91000685e9.28.1790340455565; Fri, 25 Sep 2026 05:47:35 -0700 (PDT) Received: from localhost (82-67-6-57.subs.proxad.net. [82.67.6.57]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49ff27eabc1sm58460335e9.15.2026.09.25.05.47.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Sep 2026 05:47:32 -0700 (PDT) From: Jerome Brunet To: Michal Wilczynski , Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrzej Hajda , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Lee Jones , Andy Yan , Philipp Zabel , Emil Renner Berthing , Hal Feng , Michael Turquette , Stephen Boyd , Brian Masney , Heiko Stuebner , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Dominique Belhachemi , Brian Masney , Jerome Brunet Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, mfd@lists.linux.dev, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, Andy Yan , Marek Szyprowski , Maud Spierings , Graham Markall , Icenowy Zheng , Michal Wilczynski Subject: Re: [PATCH v3 13/19] clk: starfive: jh7110-vout: Allow pixel clock rate propagation In-Reply-To: <20260904-jh7110-clean-send-v3-13-484f9ae72715@samsung.com> References: <20260904-jh7110-clean-send-v3-0-484f9ae72715@samsung.com> <20260904-jh7110-clean-send-v3-13-484f9ae72715@samsung.com> Date: Fri, 25 Sep 2026 14:47:30 +0200 Message-ID: <1j5wzt8plp.fsf@starbuckisacylon.baylibre.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On ven. 04 sept. 2026 at 15:27, Michal Wilczynski wrote: > The dc8200_pix0 and dc8200_pix1 MUXes feed the display controller, and > the rate they carry is ultimately produced by the HDMI PHY, which > registers hdmitx0_pixelclk as a clock provider. > > Add CLK_SET_RATE_PARENT to both MUXes so a rate requested on them > reaches that parent, instead of being clamped to whatever rate the > parent already happens to run at. > > Co-developed-by: Dominique Belhachemi > Signed-off-by: Dominique Belhachemi > Signed-off-by: Michal Wilczynski > --- > drivers/clk/starfive/clk-starfive-jh7110-vout.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/starfive/clk-starfive-jh7110-vout.c b/drivers/clk/starfive/clk-starfive-jh7110-vout.c > index bad20d5d794a72f071b4d547b7304786a8ba9afa..aeba42cd3c44ba205ced52b1826d2d2de82ad78f 100644 > --- a/drivers/clk/starfive/clk-starfive-jh7110-vout.c > +++ b/drivers/clk/starfive/clk-starfive-jh7110-vout.c > @@ -40,10 +40,12 @@ static const struct jh71x0_clk_data jh7110_voutclk_data[] = { > JH71X0_GATE(JH7110_VOUTCLK_DC8200_AXI, "dc8200_axi", 0, JH7110_VOUTCLK_VOUT_TOP_AXI), > JH71X0_GATE(JH7110_VOUTCLK_DC8200_CORE, "dc8200_core", 0, JH7110_VOUTCLK_VOUT_TOP_AXI), > JH71X0_GATE(JH7110_VOUTCLK_DC8200_AHB, "dc8200_ahb", 0, JH7110_VOUTCLK_VOUT_TOP_AHB), > - JH71X0_GMUX(JH7110_VOUTCLK_DC8200_PIX0, "dc8200_pix0", 0, 2, > + JH71X0_GMUX(JH7110_VOUTCLK_DC8200_PIX0, "dc8200_pix0", > + CLK_SET_RATE_PARENT | CLK_SET_RATE_NO_REPARENT, 2, I see that you've added CLK_SET_RATE_NO_REPARENT following a previous sashiko advice. Note that saying it will 'hijack' the parent without it is kind of strong. It is fine to let a mux reparent while setting a rate, as long as you understand the possible consequences for the rest of the tree. Regardless Reviewed-by: Jerome Brunet > JH7110_VOUTCLK_DC8200_PIX, > JH7110_VOUTCLK_HDMITX0_PIXELCLK), > - JH71X0_GMUX(JH7110_VOUTCLK_DC8200_PIX1, "dc8200_pix1", 0, 2, > + JH71X0_GMUX(JH7110_VOUTCLK_DC8200_PIX1, "dc8200_pix1", > + CLK_SET_RATE_PARENT | CLK_SET_RATE_NO_REPARENT, 2, > JH7110_VOUTCLK_DC8200_PIX, > JH7110_VOUTCLK_HDMITX0_PIXELCLK), > /* LCD */ > > -- > 2.34.1 > -- Jerome