All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <bh40@calva.net>
To: Henry Worth <haworth@ncal.verio.com>, linuxppc-dev@lists.linuxppc.org
Subject: Re: PB2000 (pismo) install feedback
Date: Thu, 23 Mar 2000 17:44:16 +0100	[thread overview]
Message-ID: <20000323174416.031445@mailhost.mipsys.com> (raw)
In-Reply-To: <38DA42E5.2B80E717@ncal.verio.com>


On Thu, Mar 23, 2000, Henry Worth <haworth@ncal.verio.com> wrote:

>It's very timing sensitive, a slight rearrangment of the code eliminated
>the "burnout", but didn't fix the ongoing offb colormap problems. Adding
>a small delay between writing the index and the palette value fixed the
>colomap problem. I rearranged the code to just set the index once and
>then use the palette index register's auto-incrementing to avoid the
>index write and delay in the loop, and that worked as well. I think
>Ben is planning to use a read back of the index register to ensure the
>write is posted and and give enough of a delay.
>
>Does anyone know if any of the ATI chips don't have autoincrementing of
>the palette index? That's been a fairly standard feature of RAMDAC's
>for a long time. So I was a bit surprised to see the frame buffers
>explicitly setting the index on every iteration, especially since
>the race between writing the palette index and the data has been
>a common problem for a long time.

What bugs me is that we have no such delay in aty128fb.c and you didn't
see the problem occur. Looks like a 1 instruction timing (one eieio) is
enough, so I beleive reading back the index is enough. We didn't have
this problem with older r128, so this may be a side effect of the
swadowing of the 2 sets of palette registers in the M3.


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

  reply	other threads:[~2000-03-23 16:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-03-23 16:14 PB2000 (pismo) install feedback Henry Worth
2000-03-23 16:44 ` Benjamin Herrenschmidt [this message]
2000-03-24  5:23   ` Henry Worth
2000-03-25  8:26   ` offb.c fix (Re: " Henry Worth
     [not found] <20000323142808.002464@mailhost.mipsys.com>
2000-03-23 15:38 ` Michael Schmitz
  -- strict thread matches above, loose matches on Subject: below --
2000-03-23  0:14 Chris Leishman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20000323174416.031445@mailhost.mipsys.com \
    --to=bh40@calva.net \
    --cc=haworth@ncal.verio.com \
    --cc=linuxppc-dev@lists.linuxppc.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.