All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <bh40@calva.net>
To: Michael Schmitz <schmitz@opal.biophys.uni-duesseldorf.de>,
	<linuxppc-dev@lists.linuxppc.org>
Subject: Re: powerbook hang from post-sleep cdrom access - fix
Date: Thu, 27 Jul 2000 12:36:11 +0200	[thread overview]
Message-ID: <20000727103611.19275@mailhost.mipsys.com> (raw)
In-Reply-To: <Pine.LNX.4.10.10007271058170.18614-100000@opal.biophys.uni-duesseldorf.de>


>
>Should be called from the IDE notify chain perhaps. See the last function
>in ide-pmac().

Yep, this should be done juste before the pmac_ide_dma_onoff() call in
ide-pmac.c/idepmac_notify_sleep(). It should be done regardless of the
disk beeing in a bay or not since new machines will ultimately support
sleep on desktop boxes too. Something like

switch(drive->media) {
  case ide_disk:
    // spin up the disk
    break;
  case ide_cdrom:
    // do whatever you need here
    break;
  case ide_floppy:
    // do whatever you need here
    break;
}

Note that at his point, IDE interrupts have been re-enabled, so we should
be careful about the way the IDE layer is called from here.


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

  reply	other threads:[~2000-07-27 10:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-07-27  7:13 powerbook hang from post-sleep cdrom access - fix Joseph Garcia
2000-07-27  7:16 ` Stephan Leemburg
2000-07-27  8:12   ` Joseph Garcia
2000-07-27 10:32     ` Benjamin Herrenschmidt
2000-07-27 17:46     ` Robert Thompson
2000-07-27  8:59 ` Michael Schmitz
2000-07-27 10:36   ` Benjamin Herrenschmidt [this message]
2000-07-27 12:12     ` Michael Schmitz
2000-07-27 13:12       ` Benjamin Herrenschmidt
2000-07-27 19:27         ` Michael Schmitz
2000-07-27 16:10       ` Joseph Garcia
2000-07-27 19:48         ` Michael Schmitz
2000-07-27 20:36           ` Joseph Garcia
2000-07-27 20:50             ` Michael Schmitz
2000-07-27 21:21               ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20000727103611.19275@mailhost.mipsys.com \
    --to=bh40@calva.net \
    --cc=linuxppc-dev@lists.linuxppc.org \
    --cc=schmitz@opal.biophys.uni-duesseldorf.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.