From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailserv2.iuinc.com (IDENT:qmailr@mailserv2.iuinc.com [206.245.164.55]) by puffin.external.hp.com (8.9.3/8.9.3) with SMTP id GAA27403 for ; Wed, 30 Aug 2000 06:41:42 -0600 Received: from user32-149.jakinternet.co.uk (HELO rhirst.linuxcare.com) (@212.41.32.149) by mailserv2.iuinc.com with SMTP; 30 Aug 2000 12:41:44 -0000 Received: by rhirst.linuxcare.com (Postfix, from userid 501) id CD0C6B005; Wed, 30 Aug 2000 13:41:50 +0100 (BST) Date: Wed, 30 Aug 2000 13:41:50 +0100 From: Richard Hirst To: Matthew Wilcox Cc: Helge Deller , parisc-linux@thepuffingroup.com Subject: Re: [parisc-linux] 2.4.0-test6 lack of speed Message-ID: <20000830134150.J877@linuxcare.com> References: <20000822153803.U4060@linuxcare.com> <20000822155221.W4060@linuxcare.com> <20000822165047.X4060@linuxcare.com> <87n1i5wabx.fsf@linuxcare.com> <20000823172320.E4060@linuxcare.com> <20000829172308.A1032@vodka.thepuffingroup.com> <20000830011752.A9854@parcelfarce.linux.theplanet.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20000830011752.A9854@parcelfarce.linux.theplanet.co.uk>; from matthew@wil.cx on Wed, Aug 30, 2000 at 01:17:52AM +0100 List-ID: On Wed, Aug 30, 2000 at 01:17:52AM +0100, Matthew Wilcox wrote: > Anyway, would either of Richard or Helge like to look over the lasi_82596 > driver and convert it to use the flush_kernel_dcache_range() interface > or tell me why my code is no good and I suck? Ditto the sim700 driver > actually. Are there any other drivers which have simply taken the > lasi_82596 wback code and replicated it or are these the only two? I'm not that happy with calling flush_kernel_dcache_range() from drivers, when that function only exists on parisc. Most archs define dma_cache_wback/dma_cache_inv/dma_cache_wback_inv, which, from the descriptions in asm-ia64/io.h seem to be just what lasi_82596 and sim700 need. The versions on parisc currently just flush_all_caches(), but perhaps we should make all three call flush_kernel_dcache_range()? I'll try that approach anyway. Richard