All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Stephen C. Tweedie" <sct@redhat.com>
To: Andrea Arcangeli <andrea@suse.de>
Cc: "Stephen C. Tweedie" <sct@redhat.com>,
	Rik van Riel <riel@conectiva.com.br>,
	linux-lvm@msede.com, marcelo@conectiva.com.br
Subject: [linux-lvm] Re: LVM 2.2 snapshot bug
Date: Wed, 8 Nov 2000 11:10:28 +0000	[thread overview]
Message-ID: <20001108111028.F11411@redhat.com> (raw)
In-Reply-To: <20001107205137.A7093@inspiron.suse.de>; from andrea@suse.de on Tue, Nov 07, 2000 at 08:51:37PM +0100

Hi,

On Tue, Nov 07, 2000 at 08:51:37PM +0100, Andrea Arcangeli wrote:
> On Tue, Nov 07, 2000 at 05:04:20PM +0000, Stephen C. Tweedie wrote:
> > It's a major bug as far as ext3 is concerned, because filesystem
> > recovery is a critical prerequisite for mounting a filesystem, and
> > that requires write access.  ext3 has to be able to trust the ro bits
> > in order to know whether it is safe to perform recovery writes for a
> > mount, or whether the mount must be rejected because recovery cannot
> > take place.
> 
> Stephen, the floppy device is doing exactly the same thing of LVM.

"floppy.c has this bug so it's OK for a major storage infrastructure
device to have the same bug."  Hmm!

> I don't think it's a major bug. The _only_ downside of the bug is that
> it will generate I/O errors when you try to write to the device via
> ll_rw_block (no oopses, no corruption)

Worse --- it's the difference between having the kernel tell the user
"sorry, this operation is not possible" and saying "sure, fine"
followed by a thousand IO errors in the syslog when the user tries to
mount the ext3 filesystem.  Journal recovery can generate several
megabytes of write requests, and each request is going to fail
noisily (failing writes silently during recovery is not an option).

Cheers,
 Stephen

  parent reply	other threads:[~2000-11-08 11:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-11-07 10:55 [linux-lvm] LVM 2.2 snapshot bug Rik van Riel
2000-11-07 12:16 ` Heinz J. Mauelshagen
2000-11-07 14:42   ` Rik van Riel
2000-11-07 13:21 ` [linux-lvm] " Andrea Arcangeli
2000-11-07 14:56   ` Rik van Riel
2000-11-07 16:45     ` Andrea Arcangeli
2000-11-07 17:04       ` Stephen C. Tweedie
2000-11-07 19:51         ` Andrea Arcangeli
2000-11-07 20:36           ` Andreas Dilger
2000-11-08 11:11             ` Stephen C. Tweedie
2000-11-08 16:16             ` Andrea Arcangeli
2000-11-08 19:08               ` Andreas Dilger
2000-11-08 11:10           ` Stephen C. Tweedie [this message]
2000-11-08 16:53             ` Andrea Arcangeli
2000-11-07 23:04       ` Rik van Riel
2000-11-08  7:55         ` Heinz Mauelshagen
2000-11-08 13:44           ` Rik van Riel
2000-11-08 16:31         ` Andrea Arcangeli
     [not found]           ` <898720000.973701988@coffee>
2000-11-08 17:04             ` Andrea Arcangeli
2000-11-08 19:11               ` Andreas Dilger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20001108111028.F11411@redhat.com \
    --to=sct@redhat.com \
    --cc=andrea@suse.de \
    --cc=linux-lvm@msede.com \
    --cc=marcelo@conectiva.com.br \
    --cc=riel@conectiva.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.