From: Jens Axboe <axboe@suse.de>
To: Neil Brown <neilb@cse.unsw.edu.au>
Cc: Linus Torvalds <torvalds@transmeta.com>, linux-kernel@vger.kernel.org
Subject: Re: PATCH: rd - deadlock removal
Date: Thu, 9 Nov 2000 10:35:11 +0100 [thread overview]
Message-ID: <20001109103511.G467@suse.de> (raw)
In-Reply-To: <14857.60161.343937.977948@notabene.cse.unsw.edu.au>
In-Reply-To: <14857.60161.343937.977948@notabene.cse.unsw.edu.au>; from neilb@cse.unsw.edu.au on Thu, Nov 09, 2000 at 11:08:33AM +1100
On Thu, Nov 09 2000, Neil Brown wrote:
[snip]
> DEADLOCK
> I have two patches which address this problem.
> The first is simple and simply drops ui_request_lock before calling
> getblk. This may be the appropriate one to use given the code
> freeze.
rd still needs to hold the lock when calling end_request, since
that may end up fiddling with the queue list.
> The second is more elegant in that it side steps the problem by
> giving rd.c a make_request function instead of using the default
> _make_request. This means that io_request_lock is simply never
> claimed my rd.
And this solution is much better, even given the freeze I think that
is the way to go.
--
* Jens Axboe <axboe@suse.de>
* SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2000-11-09 9:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-11-09 0:08 PATCH: rd - deadlock removal Neil Brown
2000-11-09 9:35 ` Jens Axboe [this message]
2000-11-09 18:02 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20001109103511.G467@suse.de \
--to=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.