All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Dilger <adilger@turbolinux.com>
To: Andreas Dilger <adilger@turbolinux.com>
Cc: Linux LVM mailing list <linux-lvm@sistina.com>, jweber@valinux.com
Subject: Re: [linux-lvm] LVM 0.9 snapshot and ext3
Date: Thu, 30 Nov 2000 13:16:13 -0700 (MST)	[thread overview]
Message-ID: <200011302016.eAUKGD501949@webber.adilger.net> (raw)
In-Reply-To: <200011301948.eAUJm6k01893@webber.adilger.net> "from Andreas Dilger at Nov 30, 2000 12:48:06 pm"

I wrote:
> The simple fix for this problem is to remove "ret" from lvm_map, and always
> returning "0" at the end.

Strangely, in 2.4 lvm_make_request() we totally ignore the return code from
lvm_map() and always return 1.  This should also be fixed after lvm_map()
no longer returns the snapshot error codes.  There is currently a thread
on l-k (cc'd to linux-lvm) which is discussing this very issue.  A good
time to clean this whole thing up.

Cheers, Andreas
-- 
Andreas Dilger  \ "If a man ate a pound of pasta and a pound of antipasto,
                 \  would they cancel out, leaving him still hungry?"
http://www-mddsp.enel.ucalgary.ca/People/adilger/               -- Dogbert

  reply	other threads:[~2000-11-30 20:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-11-29  6:09 [linux-lvm] LVM 0.9 snapshot and ext3 Jay Weber
2000-11-29  6:21 ` Jay Weber
2000-11-29  6:24 ` Jay Weber
2000-11-29  7:01   ` Andreas Dilger
2000-11-29 10:18     ` Andreas Dilger
2000-11-30  9:46       ` Stephen C. Tweedie
2000-11-30 19:48         ` Andreas Dilger
2000-11-30 20:16           ` Andreas Dilger [this message]
2000-11-30 22:04           ` Jay Weber
2000-12-01 15:06           ` Stephen C. Tweedie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200011302016.eAUKGD501949@webber.adilger.net \
    --to=adilger@turbolinux.com \
    --cc=jweber@valinux.com \
    --cc=linux-lvm@sistina.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.