From: Tim Waugh <twaugh@redhat.com>
To: Lukasz Trabinski <lukasz@lt.wsisiz.edu.pl>
Cc: linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk,
tytso@valinux.com
Subject: Re: [patch] 2.2.18 PCI_DEVICE_ID_OXSEMI_16PCI954
Date: Sat, 16 Dec 2000 23:21:13 +0000 [thread overview]
Message-ID: <20001216232113.B12112@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.30.0012152140350.3740-100000@lt.wsisiz.edu.pl>
In-Reply-To: <Pine.LNX.4.30.0012152140350.3740-100000@lt.wsisiz.edu.pl>; from lukasz@lt.wsisiz.edu.pl on Fri, Dec 15, 2000 at 09:57:42PM +0100
On Fri, Dec 15, 2000 at 09:57:42PM +0100, Lukasz Trabinski wrote:
> In serial dirver from Theodore Ts'o we have:
>
> { PCI_VENDOR_ID_SPECIALIX, PCI_DEVICE_ID_OXSEMI_16PCI954,
This is for a serial port device.
> (IMHO that is correct), but in kernel 2.2.18 we have:
> (include/kernel/pci.h)
> #define PCI_DEVICE_ID_OXSEMI_16PCI954PP 0x9513
> ^^
This is for a parallel port device. They are two logically different
things, have two distinct PCI bus entries, and so have two distinct
PCI device IDs and consequently different names.
> -#define PCI_DEVICE_ID_OXSEMI_16PCI954PP 0x9513
> +#define PCI_DEVICE_ID_OXSEMI_16PCI954 0x9513
Alan, do not apply, this will break the parport code.
If the OXSEMI_16PCI954 is _missing_, it probably ought to be _added_,
but it does not have 0x9513 as its ID and so the existing name should
not be changed.
Tim.
*/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2000-12-16 23:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-12-15 20:57 [patch] 2.2.18 PCI_DEVICE_ID_OXSEMI_16PCI954 Lukasz Trabinski
2000-12-15 23:04 ` Bruce Korb
2000-12-16 23:21 ` Tim Waugh [this message]
2000-12-17 0:51 ` Lukasz Trabinski
2000-12-17 10:18 ` tytso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20001216232113.B12112@redhat.com \
--to=twaugh@redhat.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=lukasz@lt.wsisiz.edu.pl \
--cc=tytso@valinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.