Re: [PATCH][RFC] Converting drivers/net/rcpci45.c to new PCI API

[Rasmus Andersen <rasmus@jaquet.dk>]

On Tue, Dec 19, 2000 at 10:05:30PM +0100, Torben Mathiasen wrote:
> 
> You should release the irq when the adapter is closed, not removed,
> unless there's some special case that can't be handled if you take
> ints during init.

You seem to be right. I have moved the free_irq to the close function.

> 
> And why would you unregister your netdev after releasing resources?
> 

Instead of doing it before? Beats me :) I merely/blindly copied the 
existing sequence, but after RTFS'ing I changed the sequence to:

	unregister_netdev(dev);
	iounmap((void *)dev->base_addr);
	kfree(dev);

Thank you for your comments.
-- 
Regards,
        Rasmus(rasmus@jaquet.dk)

Freedom of the press is limited to those who own one.
                                 - A.J. Liebling 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/