From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: Drew Eckhardt <drew@PoohSticks.ORG>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] de620.c: nitpicking
Date: Mon, 8 Jan 2001 20:25:33 -0200 [thread overview]
Message-ID: <20010108202533.F17087@conectiva.com.br> (raw)
In-Reply-To: <20010108201103.E17087@conectiva.com.br>
In-Reply-To: <20010108201103.E17087@conectiva.com.br>; from acme@conectiva.com.br on Mon, Jan 08, 2001 at 08:11:04PM -0200
Hi,
Please consider applying, no need to restore_flags here, as it is
restored in the beginning of this if block.
- Arnaldo
--- linux-2.4.0-ac3/drivers/scsi/53c7,8xx.c Fri Oct 13 18:40:51 2000
+++ linux-2.4.0-ac3.acme/drivers/scsi/53c7,8xx.c Mon Jan 8 20:24:35 2001
@@ -1899,7 +1899,6 @@
hostdata->script, start);
printk ("scsi%d : DSPS = 0x%x\n", host->host_no,
NCR53c7x0_read32(DSPS_REG));
- restore_flags(flags);
return -1;
}
hostdata->test_running = 0;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2001-01-09 0:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-01-08 22:11 [PATCH] de620.c: nitpicking Arnaldo Carvalho de Melo
2001-01-08 22:25 ` Arnaldo Carvalho de Melo [this message]
2001-01-08 22:30 ` [PATCH] tidy 53c7,8xx.c was " Arnaldo Carvalho de Melo
2001-01-09 2:14 ` [PATCH] advansys.c: include missing restore_flags, etc Arnaldo Carvalho de Melo
2001-01-09 7:30 ` Pauline Middelink
2001-01-09 10:06 ` Arnaldo Carvalho de Melo
2001-01-09 10:23 ` Alan Cox
2001-01-09 23:12 ` Pauline Middelink
2001-01-10 7:48 ` Ralf Baechle
2001-01-09 10:02 ` Russell King
2001-01-09 11:18 ` [PATCH] ad1848.c: include missing restore_flags Arnaldo Carvalho de Melo
2001-01-09 12:00 ` [PATCH] sscape.c: " Arnaldo Carvalho de Melo
2001-01-09 12:24 ` [PATCH] via-macii.c: restore_flags on failure Arnaldo Carvalho de Melo
2001-01-09 13:38 ` [PATCH] dn_keyb.c: " Arnaldo Carvalho de Melo
2001-01-09 16:17 ` Alan Cox
2001-01-09 15:30 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010108202533.F17087@conectiva.com.br \
--to=acme@conectiva.com.br \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=drew@PoohSticks.ORG \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.