All of lore.kernel.org
 help / color / mirror / Atom feed
From: antirez <antirez@invece.org>
To: Brian Gerst <bgerst@didntduck.org>
Cc: antirez@invece.org, linux-kernel@vger.kernel.org
Subject: Re: * 4 converted to << 2 for networking code
Date: Wed, 10 Jan 2001 18:03:22 +0100	[thread overview]
Message-ID: <20010110180322.T7498@prosa.it> (raw)
In-Reply-To: <20010110174859.R7498@prosa.it> <3A5C778C.CFB363F3@didntduck.org>
In-Reply-To: <3A5C778C.CFB363F3@didntduck.org>; from bgerst@didntduck.org on Wed, Jan 10, 2001 at 09:54:04AM -0500

On Wed, Jan 10, 2001 at 09:54:04AM -0500, Brian Gerst wrote:
> This patch isn't really necessary, because GCC will automatically
> convert multiplications and divisions by powers of two to use shifts.

Sure, but since many << 2 already exists in the net kernel code
I feel it's better to use just a format, and it seems more appropriate
to write << 2, just to reflect what we want.
Also some piece of kernel code may be used with compilers that does not
optimize power of two.

antirez
(CC me)

-- 
Salvatore Sanfilippo              |                      <antirez@invece.org>
http://www.kyuzz.org/antirez      |      PGP: finger antirez@tella.alicom.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

  reply	other threads:[~2001-01-10 15:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-01-10 16:48 * 4 converted to << 2 for networking code antirez
2001-01-10 14:38 ` David S. Miller
2001-01-10 14:54 ` Brian Gerst
2001-01-10 17:03   ` antirez [this message]
2001-01-10 15:11     ` Jakob Østergaard
2001-01-10 15:18       ` Mike Harrold
2001-01-10 15:31         ` Chris Jones
2001-01-10 16:23         ` Jamie Lokier
2001-01-10 16:26           ` Mike Harrold
2001-01-10 17:25       ` antirez
2001-01-10 16:25         ` Pauline Middelink
2001-01-11  0:29       ` H. Peter Anvin
2001-01-10 22:21 ` Matthias Andree

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010110180322.T7498@prosa.it \
    --to=antirez@invece.org \
    --cc=bgerst@didntduck.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.