All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@kernel.crashing.org>
To: Jeff Garzik <jgarzik@mandrakesoft.com>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: 2.4.2-pre1
Date: Tue, 6 Feb 2001 11:36:15 -0700	[thread overview]
Message-ID: <20010206113615.G8469@opus.bloom.county> (raw)
In-Reply-To: <Pine.LNX.4.10.10102032021380.1010-100000@penguin.transmeta.com>
In-Reply-To: <Pine.LNX.4.10.10102032021380.1010-100000@penguin.transmeta.com>; from torvalds@transmeta.com on Sat, Feb 03, 2001 at 08:24:27PM -0800

On Sat, Feb 03, 2001 at 08:24:27PM -0800, Linus Torvalds wrote:

...
> -pre1:
...
>  - riva FB driver update

Er, what exactly is the CONFIG_PREP stuff in this driver supposed to be
for?  "CONFIG_PREP" doesn't exist anymore to start with, and secondly I'm
not sure if any PReP boxes ever shipped with a riva card to start with.  The
only real way to handle this in 2.4 is something like:
#ifdef CONFIG_ALL_PPC /* CHRP/PMAC/PREP */
#include <asm/processor.h>
#define isPReP (_machine == _MACH_prep)
#else
#define isPReP 0
#endif

That is, if there's really any need to test explicitly for a PReP box.
I asked Ani Joshi about this a while ago, and he wasn't quite sure why they
were in there either..

-- 
Tom Rini (TR1265)
http://gate.crashing.org/~trini/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

  reply	other threads:[~2001-02-06 18:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-02-04  4:24 2.4.2-pre1 Linus Torvalds
2001-02-06 18:36 ` Tom Rini [this message]
2001-02-06 18:52   ` 2.4.2-pre1 Jeff Garzik
2001-02-06 19:00     ` 2.4.2-pre1 Tom Rini
     [not found] <Pine.LNX.4.30.0102032118020.13720-100000@ns-01.hislinuxbox.com>
2001-02-04 17:48 ` 2.4.2-pre1 Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010206113615.G8469@opus.bloom.county \
    --to=trini@kernel.crashing.org \
    --cc=jgarzik@mandrakesoft.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.