From: Mitchell Blank Jr <mitch@sfgoth.com>
To: "David S. Miller" <davem@redhat.com>
Cc: dean gaudet <dean-list-linux-kernel@arctic.org>,
linux-kernel@vger.kernel.org
Subject: Re: dentry cache order 7 is broken
Date: Thu, 8 Feb 2001 00:22:12 -0800 [thread overview]
Message-ID: <20010208002212.Q12227@sfgoth.com> (raw)
In-Reply-To: <Pine.LNX.4.33.0102072302030.5947-100000@twinlark.arctic.org> <14978.21605.98365.252519@pizda.ninka.net>
In-Reply-To: <14978.21605.98365.252519@pizda.ninka.net>; from davem@redhat.com on Thu, Feb 08, 2001 at 12:10:13AM -0800
David S. Miller wrote:
> - hash = hash ^ (hash >> D_HASHBITS) ^ (hash >> D_HASHBITS*2);
> + hash = hash ^ (hash >> D_HASHBITS) ^
> + (hash >> (D_HASHBITS+(D_HASHBITS/2)));
Two comments:
1. The inode-cache has the exact same problem, but it'll require a lot
of RAM to run into it. The buffer and page caches don't have the
same problem.
2. Given that D_HASHBITS is not a constant I wonder if there isn't
a more efficient hash to be found. But I guess I'll leave that
to the hashing experts.
-Mitch
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2001-02-08 8:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-08 7:15 dentry cache order 7 is broken dean gaudet
2001-02-08 8:10 ` David S. Miller
2001-02-08 8:22 ` Mitchell Blank Jr [this message]
2001-02-08 9:22 ` David S. Miller
2001-02-09 0:36 ` dean gaudet
2001-02-09 1:21 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010208002212.Q12227@sfgoth.com \
--to=mitch@sfgoth.com \
--cc=davem@redhat.com \
--cc=dean-list-linux-kernel@arctic.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.