From: Francois romieu <romieu@ensta.fr>
To: Jeff Garzik <jgarzik@mandrakesoft.com>
Cc: davej@suse.de,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] Remaining net/ pci_enable_device cleanups.
Date: Thu, 8 Feb 2001 09:18:19 +0000 [thread overview]
Message-ID: <20010208091819.A30551@nic.fr> (raw)
In-Reply-To: <Pine.LNX.4.31.0102072310240.29253-100000@athlon.local> <3A821701.C7ED5ED2@mandrakesoft.com>
In-Reply-To: <3A821701.C7ED5ED2@mandrakesoft.com>; from jgarzik@mandrakesoft.com on Wed, Feb 07, 2001 at 10:48:17PM -0500
The Wed, Feb 07, 2001 at 10:48:17PM -0500, Jeff Garzik wrote :
[...]
> > diff -urN --exclude-from=/home/davej/.exclude linux/drivers/net/epic100.c linux-dj/drivers/net/epic100.c
> > --- linux/drivers/net/epic100.c Wed Feb 7 21:55:56 2001
> > +++ linux-dj/drivers/net/epic100.c Wed Feb 7 22:15:22 2001
>
> applied
@@ -341,7 +341,7 @@
static int printed_version;
long ioaddr;
int chip_idx = (int) ent->driver_data;
- const int irq = pdev->irq;
+ int irq;
struct net_device *dev;
struct epic_private *ep;
int i, option = 0, duplex = 0;
@@ -354,10 +354,11 @@
printk (KERN_INFO "%s" KERN_INFO "%s" KERN_INFO "%s",
version, version2, version3);
- i = pci_enable_device(pdev);
- if (i)
+ if (pci_enable_device(pdev))
return i;
return i ? Looks bogus to me.
--
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2001-02-08 8:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-07 23:13 [PATCH] Remaining net/ pci_enable_device cleanups davej
2001-02-08 3:48 ` Jeff Garzik
2001-02-08 9:18 ` Francois romieu [this message]
2001-02-08 17:45 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010208091819.A30551@nic.fr \
--to=romieu@ensta.fr \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davej@suse.de \
--cc=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.