From: Pauline Middelink <middelink@polyware.nl>
To: linux-kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] a more efficient BUG() macro
Date: Sat, 17 Feb 2001 13:57:23 +0100 [thread overview]
Message-ID: <20010217135723.A26653@polyware.nl> (raw)
In-Reply-To: <3A8E3BA5.4B98E94E@yahoo.com> <3A8E6E0C.2F205328@colorfullife.com>
In-Reply-To: <3A8E6E0C.2F205328@colorfullife.com>; from manfred@colorfullife.com on Sat, Feb 17, 2001 at 01:26:52PM +0100
On Sat, 17 Feb 2001 around 13:26:52 +0100, Manfred Spraul wrote:
> Paul Gortmaker wrote:
> >
> > Anyway this small patch makes sure there is only one "kernel BUG..." string,
> > and dumps __FILE__ in favour of an address value since System.map data is
> > needed to make full use of the BUG() dump anyways. The memory stats of two
> > otherwise identical kernels:
> >
>
> Shouldn't the linker drop duplicate strings?
Yes, but that wasn't his patch. He split off the
constant text in the bugline to a separate string and
made sure /that/ string was used only once.
The old way contained the 'kernel BUG at' string a
zillion times, now it only contains 'bla.c: 412'
and variants thereof a lot of times. (And most of
them are NO duplicates, or you would have had 2 BUGs
at the same line...
Met vriendelijke groet,
Pauline Middelink
--
GPG Key fingerprint = 2D5B 87A7 DDA6 0378 5DEA BD3B 9A50 B416 E2D0 C3C2
For more details look at my website http://www.polyware.nl/~middelink
next prev parent reply other threads:[~2001-02-17 12:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-17 8:51 [PATCH] a more efficient BUG() macro Paul Gortmaker
2001-02-17 12:26 ` Manfred Spraul
2001-02-17 12:57 ` Pauline Middelink [this message]
2001-02-17 13:15 ` Hugh Dickins
2001-02-17 14:22 ` J . A . Magallon
2001-02-17 15:14 ` J . A . Magallon
2001-02-17 17:04 ` [PATCH] conditionalize __io_virt_debug Jeff Garzik
2001-02-18 0:01 ` [PATCH] a more efficient BUG() macro Keith Owens
2001-02-18 0:33 ` J . A . Magallon
2001-02-18 0:48 ` Keith Owens
2001-02-18 1:33 ` Andrew Morton
2001-02-18 1:37 ` J . A . Magallon
2001-02-18 1:50 ` Andrew Morton
2001-02-18 1:47 ` Keith Owens
2001-02-18 14:27 ` Andi Kleen
2001-02-17 16:37 ` J . A . Magallon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010217135723.A26653@polyware.nl \
--to=middelink@polyware.nl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.