Re: Changes to ide-cd for 2.4.1 are broken?

[Jens Axboe <axboe@suse.de>]

On Sat, Feb 17 2001, John Fremlin wrote:
> Specifically, this part:
> 
> @@ -2324,11 +2309,17 @@
>                     sense.ascq == 0x04)
>                         return CDS_DISC_OK;
>  
> +
> +               /*
> +                * If not using Mt Fuji extended media tray reports,
> +                * just return TRAY_OPEN since ATAPI doesn't provide
> +                * any other way to detect this...
> +                */
>                 if (sense.sense_key == NOT_READY) {
> -                       /* ATAPI doesn't have anything that can help
> -                          us decide whether the drive is really
> -                          emtpy or the tray is just open. irk. */
> -                       return CDS_TRAY_OPEN;
> +                       if (sense.asc == 0x3a && (!sense.ascq||sense.ascq == 1))
> +                               return CDS_NO_DISC;
> +                       else
> +                               return CDS_TRAY_OPEN;
>                 }
> 
> My tray is open as I type, and it is misreported as CDS_NO_DISC. In
> 2.4.0 it worked fine.

Your drive is broken, the only other valid combination is 0x3a/0x02 which means
no media and tray open. You could try and dump the asc and ascq to see what
your drive reports for the different states.

-- 
Jens Axboe