All of lore.kernel.org
 help / color / mirror / Atom feed
From: Grant Grundler <grundler@cup.hp.com>
To: Matthew Wilcox <willy@ldl.fc.hp.com>
Cc: parisc-linux@parisc-linux.org
Subject: Re: [parisc-linux] [PATCH] Fix HPUX fork
Date: Thu, 22 Feb 2001 22:26:47 -0800	[thread overview]
Message-ID: <200102230626.WAA20515@milano.cup.hp.com> (raw)
In-Reply-To: Your message of "Thu, 22 Feb 2001 21:46:13 PST." <E14WA7R-0004qy-00@chrysl>

Matthew Wilcox wrote:
> -		cregs->kpc = &child_return;
>  		cregs->gr[30] = usp;
> +		if (p->personality == PER_HPUX) {
> +			cregs->kpc = &hpux_child_return;
> +		} else {
> +			cregs->kpc = &child_return;
> +		}

Matthew,
In general, branches hurt performance on RISC archs.
Could the code be structured something like:

	cregs->kpc = child_return_ftn[p->personality];
or 
	cregs->kpc = personality_data[p->personality].child_ret_ftn;


For PARISC-linux, do we need more personalities for wide-mode or SOM support?
If so, then indexing is probably a better solution.

thanks,
grant

Grant Grundler
parisc-linux {PCI|IOMMU|SMP} hacker
+1.408.447.7253

      reply	other threads:[~2001-02-23  6:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-02-23  4:46 [parisc-linux] [PATCH] Fix HPUX fork Matthew Wilcox
2001-02-23  6:26 ` Grant Grundler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200102230626.WAA20515@milano.cup.hp.com \
    --to=grundler@cup.hp.com \
    --cc=parisc-linux@parisc-linux.org \
    --cc=willy@ldl.fc.hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.