From: Jens Axboe <axboe@suse.de>
To: Russell King <rmk@arm.linux.org.uk>
Cc: Steve Whitehouse <Steve@ChyGwyn.com>,
torvalds@transmeta.com, pavel@suse.cz,
linux-kernel@vger.kernel.org
Subject: Re: NBD Cleanup patch and bugfix in ll_rw_blk.c
Date: Sun, 25 Feb 2001 23:49:27 +0100 [thread overview]
Message-ID: <20010225234927.S7830@suse.de> (raw)
In-Reply-To: <200102251957.TAA01718@gw.chygwyn.com> <20010225223913.A3627@flint.arm.linux.org.uk>
In-Reply-To: <20010225223913.A3627@flint.arm.linux.org.uk>; from rmk@arm.linux.org.uk on Sun, Feb 25, 2001 at 10:39:13PM +0000
On Sun, Feb 25 2001, Russell King wrote:
> On Sun, Feb 25, 2001 at 07:57:29PM +0000, Steve Whitehouse wrote:
> > -int nbd_init(void)
> > +int __init nbd_init(void)
>
> > -void cleanup_module(void)
> > +void __exit nbd_cleanup(void)
>
> > +
> > +module_init(nbd_init);
> > +module_exit(nbd_cleanup);
>
> If you're using module_init/module_exit, shouldn't nbd_init/nbd_cleanup
> be declared statically?
And more importantly, the init calls from ll_rw_blk.c:blk_dev_init()
should be removed too.
--
Jens Axboe
next prev parent reply other threads:[~2001-02-25 22:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-25 19:57 NBD Cleanup patch and bugfix in ll_rw_blk.c Steve Whitehouse
2001-02-25 20:55 ` Andrea Arcangeli
2001-02-25 20:59 ` Jens Axboe
2001-02-25 22:39 ` Russell King
2001-02-25 22:49 ` Jens Axboe [this message]
2001-02-25 23:02 ` Steve Whitehouse
2001-02-28 19:41 ` Linus Torvalds
2001-02-28 21:27 ` Steve Whitehouse
2001-02-28 21:37 ` Jens Axboe
2001-02-28 23:29 ` Linus Torvalds
2001-03-01 0:07 ` Jens Axboe
2001-03-01 3:14 ` Linus Torvalds
[not found] ` <200103010314.TAA06827@penguin.transmeta.com>
2001-03-01 13:39 ` Jens Axboe
2001-03-01 14:49 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010225234927.S7830@suse.de \
--to=axboe@suse.de \
--cc=Steve@ChyGwyn.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=rmk@arm.linux.org.uk \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.