From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>,
shingo@flab.fujitsu.co.jp, linux-kernel@vger.kernel.org
Subject: [PATCH] fmvj18x_cs: don't reference skb after passing it to netif_rx
Date: Mon, 26 Feb 2001 21:14:03 -0300 [thread overview]
Message-ID: <20010226211403.N8692@conectiva.com.br> (raw)
another pcmcia one
Em Mon, Feb 26, 2001 at 08:33:59PM -0300, Arnaldo Carvalho de Melo escreveu:
Hi,
I've just read davem's post at netdev about the brokeness of
referencing skbs after passing it to netif_rx, so please consider applying
this patch. Ah, this was just added to the Janitor's TODO list at
http://bazar.conectiva.com.br/~acme/TODO and I'm doing a quick audit in the
net drivers searching for this, maybe some more patches will follow.
- Arnaldo
--- linux-2.4.2/drivers/net/pcmcia/fmvj18x_cs.c Tue Feb 13 19:15:05 2001
+++ linux-2.4.2.acme/drivers/net/pcmcia/fmvj18x_cs.c Mon Feb 26 22:45:53 2001
@@ -994,9 +994,9 @@
}
#endif
+ lp->stats.rx_bytes += skb->len;
netif_rx(skb);
lp->stats.rx_packets++;
- lp->stats.rx_bytes += skb->len;
}
if (--boguscount <= 0)
break;
next reply other threads:[~2001-02-27 1:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-27 0:14 Arnaldo Carvalho de Melo [this message]
2001-02-27 0:41 ` [PATCH] tms380tr: update last_rx after netif_rx Arnaldo Carvalho de Melo
2001-02-27 1:57 ` [PATCH] fmvj18x_cs: don't reference skb after passing it to netif_rx Jeff Garzik
2001-02-27 0:25 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010226211403.N8692@conectiva.com.br \
--to=acme@conectiva.com.br \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=shingo@flab.fujitsu.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.