Re: [PATCH] 3c589_cs: don't reference skb after passing it to netif_rx

[Arnaldo Carvalho de Melo <acme@conectiva.com.br>]

Em Mon, Feb 26, 2001 at 08:56:06PM -0500, Jeff Garzik escreveu:
> Arnaldo Carvalho de Melo wrote:
> > --- linux-2.4.2/drivers/net/pcmcia/3c589_cs.c   Tue Feb 13 19:15:05 2001
> > +++ linux-2.4.2.acme/drivers/net/pcmcia/3c589_cs.c      Mon Feb 26 22:44:00 2001
> > @@ -992,9 +992,9 @@
> >                         (pkt_len+3)>>2);
> >                 skb->protocol = eth_type_trans(skb, dev);
> > 
> > +               lp->stats.rx_bytes += skb->len;
> >                 netif_rx(skb);
> >                 lp->stats.rx_packets++;
> > -               lp->stats.rx_bytes += skb->len;
> 
> I prefer the attached patch instead.  It makes use of the existing local
> 'pkt_len', and it checks off another item that should probably be on the
> janitor's todo list:  Set 'dev->last_rx=jiffies' immediately after
> netif_rx.

Thanks, I've added your comments and Donald one about grouping the stat
updates, as always the Janitor's TODO list is available at
http://bazar.conectiva.com.br/~acme/TODO, so get your broom and keep on
cleaning 8)

- Arnaldo