From: Robert Read <rread@datarithm.net>
To: Andrew Morton <andrewm@uow.edu.au>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, Ingo Molnar <mingo@elte.hu>,
Keith Owens <kaos@ocs.com.au>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [patch] serial console vs NMI watchdog
Date: Fri, 9 Mar 2001 14:23:32 -0800 [thread overview]
Message-ID: <20010309142332.E1792@tenchi.datarithm.net> (raw)
In-Reply-To: <3AA8E6E5.A4AD5035@uow.edu.au>
In-Reply-To: <3AA8E6E5.A4AD5035@uow.edu.au>; from andrewm@uow.edu.au on Sat, Mar 10, 2001 at 01:21:25AM +1100
On Sat, Mar 10, 2001 at 01:21:25AM +1100, Andrew Morton wrote:
> +static atomic_t nmi_watchdog_enabled = ATOMIC_INIT(0); /* 0 == enabled */
> +
> +void enable_nmi_watchdog(int yes)
> +{
> + if (yes)
> + atomic_inc(&nmi_watchdog_enabled);
> + else
> + atomic_dec(&nmi_watchdog_enabled);
> +}
>
> void nmi_watchdog_tick (struct pt_regs * regs)
> {
> @@ -255,7 +264,7 @@
>
> sum = apic_timer_irqs[cpu];
>
> - if (last_irq_sums[cpu] == sum) {
> + if (last_irq_sums[cpu] == sum && atomic_read(&nmi_watchdog_enabled) == 0) {
Shouldn't that be atomic_read(&nmi_watchdog_enabled) != 0?
next prev parent reply other threads:[~2001-03-09 22:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-09 14:21 [patch] serial console vs NMI watchdog Andrew Morton
2001-03-09 16:35 ` Ion Badulescu
2001-03-10 2:41 ` Andrew Morton
2001-03-09 22:23 ` Robert Read [this message]
2001-03-11 7:44 ` Ingo Molnar
2001-03-11 7:52 ` Keith Owens
2001-03-11 7:53 ` Ingo Molnar
2001-03-11 8:00 ` Keith Owens
2001-03-11 8:16 ` Andrew Morton
2001-03-11 9:01 ` [patch] nmi-watchdog-2.4.2-A1 Ingo Molnar
2001-03-11 10:08 ` Andrew Morton
2001-03-11 15:04 ` [patch] nmi-watchdog-2.4.2-A2 Ingo Molnar
2001-03-12 4:43 ` [patch] serial console vs NMI watchdog george anzinger
2001-03-12 5:52 ` Keith Owens
2001-03-12 8:27 ` george anzinger
2001-03-12 8:41 ` Keith Owens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010309142332.E1792@tenchi.datarithm.net \
--to=rread@datarithm.net \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andrewm@uow.edu.au \
--cc=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.