From: Greg KH <greg@kroah.com>
To: Seth Andrew Hallem <shallem@Stanford.EDU>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Potential free/use-after-free bugs
Date: Sat, 17 Mar 2001 13:47:58 -0800 [thread overview]
Message-ID: <20010317134758.B6382@wirex.com> (raw)
In-Reply-To: <20010316221730.B17586@elaine23.stanford.edu>
In-Reply-To: <20010316221730.B17586@elaine23.stanford.edu>; from shallem@Stanford.EDU on Fri, Mar 16, 2001 at 10:17:30PM -0800
On Fri, Mar 16, 2001 at 10:17:30PM -0800, Seth Andrew Hallem wrote:
> [BUG] Potential double or more free.
> /home/shallem/oses/linux/2.4.1/drivers/usb/serial/belkin_sa.c:236:belkin_sa_shutdown:
> ERROR:FREE:237:236: Use-after-free of 'private'! set by 'kfree':237
>
> }
> /* My special items, the standard routines free my urbs */
> if (serial->port->private)
> Error --->
> Start --->
> kfree(serial->port->private);
> }
>
> [BUG] Copy paste of above potential bug.
> /home/shallem/oses/linux/2.4.1/drivers/usb/serial/mct_u232.c:277:mct_u232_shutdown:
> ERROR:FREE:278:277: Use-after-free of 'private'! set by 'kfree':278
>
> [BUG]
Damn fine catch, the author meant to say serial->port[i].private there.
Thanks, I'll fix these up.
greg k-h
--
greg@(kroah|wirex).com
prev parent reply other threads:[~2001-03-17 21:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-17 6:17 Potential free/use-after-free bugs Seth Andrew Hallem
2001-03-17 11:31 ` Andrew Morton
2001-03-17 21:47 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010317134758.B6382@wirex.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shallem@Stanford.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.