From: Ion Badulescu <ionut@moisil.cs.columbia.edu>
To: "J . A . Magallon" <jamagallon@able.es>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gcc-3.0 warnings
Date: Fri, 23 Mar 2001 21:30:25 -0800 [thread overview]
Message-ID: <200103240530.f2O5UP028482@moisil.dev.hydraweb.com> (raw)
In-Reply-To: <20010323235909.C3098@werewolf.able.es>
On Fri, 23 Mar 2001 23:59:09 +0100, J . A . Magallon <jamagallon@able.es> wrote:
>
>
> On 03.23 Linus Torvalds wrote:
>>
>> I agree. I'd much prefer that syntax also.
>>
>> Or just remove the "default:" altogether, when it doesn't make any
>> difference.
>>
>
> Well, at last some sense. The same is with that ugly out: at the end
> of the function. Just change all that 'goto out' for a return.
No, no. Hell no. Multiple return paths in a function are a sure recipe
for errors creeping in later.
Just change the
out:;
into
out:
return;
and be done with it. Heck, it even looks like C code for a change. :-)
Ion
--
It is better to keep your mouth shut and be thought a fool,
than to open it and remove all doubt.
next prev parent reply other threads:[~2001-03-24 5:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-23 0:11 [PATCH] gcc-3.0 warnings J . A . Magallon
2001-03-23 0:28 ` Alan Cox
2001-03-23 0:38 ` J . A . Magallon
2001-03-23 9:29 ` Tim Waugh
2001-03-23 23:56 ` Ingo Oeser
2001-03-23 22:29 ` Bill Wendling
2001-03-23 22:34 ` Linus Torvalds
2001-03-23 22:59 ` J . A . Magallon
2001-03-24 0:31 ` Tim Wright
2001-03-24 0:42 ` Andrew Morton
2001-03-24 0:55 ` J . A . Magallon
2001-03-24 21:51 ` Tim Waugh
2001-03-24 1:16 ` Stephen Satchell
2001-03-26 14:25 ` Tim Wright
2001-03-24 5:30 ` Ion Badulescu [this message]
2001-03-23 17:12 ` Horst von Brand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200103240530.f2O5UP028482@moisil.dev.hydraweb.com \
--to=ionut@moisil.cs.columbia.edu \
--cc=jamagallon@able.es \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.