From: Tim Waugh <twaugh@redhat.com>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, linux-kernel@vger.kernel.org
Subject: [take 2] [patch] 2.4.3-pre8: another parport bug
Date: Tue, 27 Mar 2001 23:04:03 +0100 [thread overview]
Message-ID: <20010327230403.Q21068@redhat.com> (raw)
Oops, the last patch isn't the one I meant to send. Here is the right
one.
Tim.
*/
2001-03-27 Tim Waugh <twaugh@redhat.com>
* parport_pc: Fix save/restore_state to take account of the soft
control port.
* ChangeLog: Updated.
--- linux/drivers/parport/parport_pc.c.restorestate Tue Mar 27 23:00:18 2001
+++ linux/drivers/parport/parport_pc.c Tue Mar 27 23:00:50 2001
@@ -347,15 +347,16 @@
void parport_pc_save_state(struct parport *p, struct parport_state *s)
{
const struct parport_pc_private *priv = p->physport->private_data;
- s->u.pc.ctr = inb (CONTROL (p));
+ s->u.pc.ctr = priv->ctr;
if (priv->ecr)
s->u.pc.ecr = inb (ECONTROL (p));
}
void parport_pc_restore_state(struct parport *p, struct parport_state *s)
{
- const struct parport_pc_private *priv = p->physport->private_data;
+ struct parport_pc_private *priv = p->physport->private_data;
outb (s->u.pc.ctr, CONTROL (p));
+ priv->ctr = s->u.pc.ctr;
if (priv->ecr)
outb (s->u.pc.ecr, ECONTROL (p));
}
*** linux/drivers/parport/ChangeLog.restorestate Tue Mar 27 23:00:18 2001
--- linux/drivers/parport/ChangeLog Tue Mar 27 23:00:38 2001
***************
*** 0 ****
--- 1,7 ----
+ 2001-03-27 Tim Waugh <twaugh@redhat.com>
+
+ * parport_pc.c (parport_pc_save_state): Read from the soft copy of
+ the control port.
+ (parport_pc_restore_state): Update the soft copy of the control
+ port.
+
reply other threads:[~2001-03-27 22:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010327230403.Q21068@redhat.com \
--to=twaugh@redhat.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.