From: Steven Walter <srwalter@yahoo.com>
To: Brian Gerst <bgerst@didntduck.org>
Cc: jgarzik@mandrakesoft.com, tytso@mit.edu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] properly detect ActionTec modem of PCI_CLASS_COMMUNICATION_OTHER
Date: Tue, 24 Apr 2001 17:19:04 -0500 [thread overview]
Message-ID: <20010424171904.A404@hapablap.dyn.dhs.org> (raw)
In-Reply-To: <20010424160310.A338@hapablap.dyn.dhs.org> <3AE5EDAC.AF06F124@didntduck.org>
In-Reply-To: <3AE5EDAC.AF06F124@didntduck.org>; from bgerst@didntduck.org on Tue, Apr 24, 2001 at 05:18:36PM -0400
On Tue, Apr 24, 2001 at 05:18:36PM -0400, Brian Gerst wrote:
> Steven Walter wrote:
> >
> > This patch allows the serial driver to properly detect and set up the
> > ActionTec PCI modem. This modem has a PCI class of COMMUNICATION_OTHER,
> > which is why this modem is not otherwise detected.
> >
> > Any suggestions on the patch are welcome. Thanks
>
> A small suggestion: Vendor/device id are sufficient to identify the
> device. You can change PCI_CLASS_COMMUNICATION_OTHER << 8 to 0.
Excellent suggestion. Follows is the amended patch. Compiled and
tested to work. BTW: patch is against 2.4.3.
--
-Steven
In a time of universal deceit, telling the truth is a revolutionary act.
-- George Orwell
--- clean-2.4.3/drivers/char/serial.c Fri Mar 30 23:15:33 2001
+++ linux/drivers/char/serial.c Tue Apr 24 16:32:02 2001
@@ -4706,6 +4728,8 @@
static struct pci_device_id serial_pci_tbl[] __devinitdata = {
+ { PCI_VENDOR_ID_ATT, PCI_DEVICE_ID_ATT_VENUS_MODEM,
+ PCI_ANY_ID, PCI_ANY_ID, },
{ PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID,
PCI_CLASS_COMMUNICATION_SERIAL << 8, 0xffff00, },
{ 0, }
prev parent reply other threads:[~2001-04-24 22:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-04-24 21:03 [PATCH] properly detect ActionTec modem of PCI_CLASS_COMMUNICATION_OTHER Steven Walter
2001-04-24 21:18 ` Brian Gerst
2001-04-24 22:19 ` Steven Walter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010424171904.A404@hapablap.dyn.dhs.org \
--to=srwalter@yahoo.com \
--cc=bgerst@didntduck.org \
--cc=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.