All of lore.kernel.org
 help / color / mirror / Atom feed
From: Grant Grundler <grundler@puffin.external.hp.com>
To: Xavier Debacker <xavier.debacker@esiee.net>
Cc: parisc-linux@lists.parisc-linux.org
Subject: Re: [parisc-linux] Keyboard driver patch proposal
Date: Sun, 29 Apr 2001 00:24:49 -0600	[thread overview]
Message-ID: <200104290624.AAA21764@puffin.external.hp.com> (raw)
In-Reply-To: Your message of "Sat, 28 Apr 2001 07:00:30 +0200." <3AEA4E6E.A990140B@esiee.net>

Xavier,
It seems Helge Deller has reviewed and committed most of the ESIEE team
work in the past. Any word on if Helge will be able to review/commit
this patch?

Xavier Debacker wrote:
> +	switch (keyval) {
> +		case KBD_BREAK :  
> +			// sets the "release_key" bit
> +			// when a key is released
> +			// HP keyboard send f0 followed by the keycode
> +			// while AT keyboard send the keycode with
> +			// this bit set.
> +			brk = 0x80;
>  			return;

BTW, I'm told the '//' comment style is not ok;  "/* ... */" is expected.
It's not mentioned in Documentation/CodingStyle so I can't explain it.

thanks,
grant

Grant Grundler
parisc-linux {PCI|IOMMU|SMP} hacker
+1.408.447.7253

  reply	other threads:[~2001-04-29  6:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-04-28  5:00 [parisc-linux] Keyboard driver patch proposal Xavier Debacker
2001-04-29  6:24 ` Grant Grundler [this message]
2001-04-29 22:14   ` Xavier Debacker
2001-04-29 22:45     ` Helge Deller
2001-04-30  2:25   ` Andrew Shugg
2001-04-30  2:29     ` Matthew Wilcox
2001-04-30 17:02     ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200104290624.AAA21764@puffin.external.hp.com \
    --to=grundler@puffin.external.hp.com \
    --cc=parisc-linux@lists.parisc-linux.org \
    --cc=xavier.debacker@esiee.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.