From: Arjan van de Ven <arjanv@redhat.com>
To: Andrea Arcangeli <andrea@suse.de>
Cc: Arjan van de Ven <arjanv@redhat.com>,
linux-mm@kvack.org, alan@lxorguk.ukuu.org.uk,
Linus Torvalds <torvalds@transmeta.com>
Subject: Re: RFC: Bouncebuffer fixes
Date: Sun, 29 Apr 2001 09:41:21 -0400 [thread overview]
Message-ID: <20010429094121.B3131@devserv.devel.redhat.com> (raw)
In-Reply-To: <20010429151711.A11395@athlon.random>; from andrea@suse.de on Sun, Apr 29, 2001 at 03:17:11PM +0200
On Sun, Apr 29, 2001 at 03:17:11PM +0200, Andrea Arcangeli wrote:
> GFP_BUFFER doesn't provide guarantee of progress and that's fine, as far
> as GFP_BUFFER allocations returns NULL eventually there should be no
> problem. The fact some emergency buffer is in flight is just the guarantee
> of progress because after unplugging tq_disk we know those emergency
> buffers will be released without the need of further memory allocations.
This is NOT what is happening. Look at the code. It does a GFP_BUFFER
allocation before even attempting to use the bounce-buffers! So there is no
guarantee of having emergency bouncebuffers in flight.
Also, I'm not totally convinced that GFP_BUFFER will never sleep before
running the tq_disk, but I agree that that can qualify as a seprate bug.
Greetings,
Arjan van de Ven
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/
next prev parent reply other threads:[~2001-04-29 13:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-04-28 21:06 RFC: Bouncebuffer fixes Arjan van de Ven
2001-04-29 0:07 ` Andrea Arcangeli
2001-04-29 7:56 ` Arjan van de Ven
2001-04-29 13:17 ` Andrea Arcangeli
2001-04-29 13:41 ` Arjan van de Ven [this message]
2001-04-29 14:10 ` Andrea Arcangeli
2001-04-30 13:53 ` anti-deadlock logic (was Re: RFC: Bouncebuffer fixes) Szabolcs Szakacsits
2001-04-29 13:42 ` RFC: Bouncebuffer fixes Andrea Arcangeli
2001-05-01 8:14 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010429094121.B3131@devserv.devel.redhat.com \
--to=arjanv@redhat.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andrea@suse.de \
--cc=linux-mm@kvack.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.