From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Date: Wed, 26 Nov 2014 19:06:02 +0000 Subject: Re: [PATCH v4 6/9] drm: Decouple EDID parsing from I2C adapter Message-Id: <2001051.DfcmgkZjNf@avalon> List-Id: References: <1414337068-28664-7-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1416959247-23132-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: dri-devel@lists.freedesktop.org Cc: Laurent Pinchart , linux-sh@vger.kernel.org Hi Rob, On Tuesday 25 November 2014 19:38:47 Rob Clark wrote: > On Tue, Nov 25, 2014 at 6:47 PM, Laurent Pinchart wrote: > > From: Lars-Peter Clausen > > > > The drm_get_edid() function performs direct I2C accesses to read EDID > > blocks, assuming that the monitor DDC interface is directly connected to > > the I2C bus. It can't thus be used with HDMI encoders that control the > > DDC bus and expose EDID blocks through a different interface. > > > > Refactor drm_do_get_edid() to take a block read callback function > > instead of an I2C adapter, and export it for direct use by drivers. > > > > As in the general case the DDC bus is accessible by the kernel at the > > I2C level, drivers must make all reasonable efforts to expose it as an > > I2C adapter and use drm_get_edid() instead of abusing this function. > > > > Signed-off-by: Lars-Peter Clausen > > Signed-off-by: Laurent Pinchart > > > > I suppose if tda998x were converted over to use it, it would be a nice > negative diffstat ;-) tda998x_drv.c | 86 ++++++++++++------------------------------------------- 1 file changed, 18 insertions(+), 68 deletions(-) :-) > Reviewed-by: Rob Clark > > > --- > > > > drivers/gpu/drm/drm_edid.c | 43 ++++++++++++++++++++++++++++------------- > > include/drm/drm_edid.h | 5 +++++ > > 2 files changed, 35 insertions(+), 13 deletions(-) > > > > Daniel, could you please review and hopefully ack this ? If this new > > version is acceptable I'd like to send an updated pull request for R-Car > > DU HDMI support for v3.19, so time is running short. > > > > Changes since v3: > > > > - Add kerneldoc for the new exported drm_do_get_edid function -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v4 6/9] drm: Decouple EDID parsing from I2C adapter Date: Wed, 26 Nov 2014 21:06:02 +0200 Message-ID: <2001051.DfcmgkZjNf@avalon> References: <1414337068-28664-7-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1416959247-23132-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [185.26.127.97]) by gabe.freedesktop.org (Postfix) with ESMTP id 162026E699 for ; Wed, 26 Nov 2014 11:05:36 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: Laurent Pinchart , linux-sh@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org SGkgUm9iLAoKT24gVHVlc2RheSAyNSBOb3ZlbWJlciAyMDE0IDE5OjM4OjQ3IFJvYiBDbGFyayB3 cm90ZToKPiBPbiBUdWUsIE5vdiAyNSwgMjAxNCBhdCA2OjQ3IFBNLCBMYXVyZW50IFBpbmNoYXJ0 IHdyb3RlOgo+ID4gRnJvbTogTGFycy1QZXRlciBDbGF1c2VuIDxsYXJzQG1ldGFmb28uZGU+Cj4g PiAKPiA+IFRoZSBkcm1fZ2V0X2VkaWQoKSBmdW5jdGlvbiBwZXJmb3JtcyBkaXJlY3QgSTJDIGFj Y2Vzc2VzIHRvIHJlYWQgRURJRAo+ID4gYmxvY2tzLCBhc3N1bWluZyB0aGF0IHRoZSBtb25pdG9y IEREQyBpbnRlcmZhY2UgaXMgZGlyZWN0bHkgY29ubmVjdGVkIHRvCj4gPiB0aGUgSTJDIGJ1cy4g SXQgY2FuJ3QgdGh1cyBiZSB1c2VkIHdpdGggSERNSSBlbmNvZGVycyB0aGF0IGNvbnRyb2wgdGhl Cj4gPiBEREMgYnVzIGFuZCBleHBvc2UgRURJRCBibG9ja3MgdGhyb3VnaCBhIGRpZmZlcmVudCBp bnRlcmZhY2UuCj4gPiAKPiA+IFJlZmFjdG9yIGRybV9kb19nZXRfZWRpZCgpIHRvIHRha2UgYSBi bG9jayByZWFkIGNhbGxiYWNrIGZ1bmN0aW9uCj4gPiBpbnN0ZWFkIG9mIGFuIEkyQyBhZGFwdGVy LCBhbmQgZXhwb3J0IGl0IGZvciBkaXJlY3QgdXNlIGJ5IGRyaXZlcnMuCj4gPiAKPiA+IEFzIGlu IHRoZSBnZW5lcmFsIGNhc2UgdGhlIEREQyBidXMgaXMgYWNjZXNzaWJsZSBieSB0aGUga2VybmVs IGF0IHRoZQo+ID4gSTJDIGxldmVsLCBkcml2ZXJzIG11c3QgbWFrZSBhbGwgcmVhc29uYWJsZSBl ZmZvcnRzIHRvIGV4cG9zZSBpdCBhcyBhbgo+ID4gSTJDIGFkYXB0ZXIgYW5kIHVzZSBkcm1fZ2V0 X2VkaWQoKSBpbnN0ZWFkIG9mIGFidXNpbmcgdGhpcyBmdW5jdGlvbi4KPiA+IAo+ID4gU2lnbmVk LW9mZi1ieTogTGFycy1QZXRlciBDbGF1c2VuIDxsYXJzQG1ldGFmb28uZGU+Cj4gPiBTaWduZWQt b2ZmLWJ5OiBMYXVyZW50IFBpbmNoYXJ0Cj4gPiA8bGF1cmVudC5waW5jaGFydCtyZW5lc2FzQGlk ZWFzb25ib2FyZC5jb20+Cj4gCj4gSSBzdXBwb3NlIGlmIHRkYTk5OHggd2VyZSBjb252ZXJ0ZWQg b3ZlciB0byB1c2UgaXQsIGl0IHdvdWxkIGJlIGEgbmljZQo+IG5lZ2F0aXZlIGRpZmZzdGF0IDst KQoKIHRkYTk5OHhfZHJ2LmMgfCAgIDg2ICsrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCsp LCA2OCBkZWxldGlvbnMoLSkKCjotKQoKPiBSZXZpZXdlZC1ieTogUm9iIENsYXJrIDxyb2JkY2xh cmtAZ21haWwuY29tPgo+IAo+ID4gLS0tCj4gPiAKPiA+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2Vk aWQuYyB8IDQzICsrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tCj4gPiAg aW5jbHVkZS9kcm0vZHJtX2VkaWQuaCAgICAgfCAgNSArKysrKwo+ID4gIDIgZmlsZXMgY2hhbmdl ZCwgMzUgaW5zZXJ0aW9ucygrKSwgMTMgZGVsZXRpb25zKC0pCj4gPiAKPiA+IERhbmllbCwgY291 bGQgeW91IHBsZWFzZSByZXZpZXcgYW5kIGhvcGVmdWxseSBhY2sgdGhpcyA/IElmIHRoaXMgbmV3 Cj4gPiB2ZXJzaW9uIGlzIGFjY2VwdGFibGUgSSdkIGxpa2UgdG8gc2VuZCBhbiB1cGRhdGVkIHB1 bGwgcmVxdWVzdCBmb3IgUi1DYXIKPiA+IERVIEhETUkgc3VwcG9ydCBmb3IgdjMuMTksIHNvIHRp bWUgaXMgcnVubmluZyBzaG9ydC4KPiA+IAo+ID4gQ2hhbmdlcyBzaW5jZSB2MzoKPiA+IAo+ID4g LSBBZGQga2VybmVsZG9jIGZvciB0aGUgbmV3IGV4cG9ydGVkIGRybV9kb19nZXRfZWRpZCBmdW5j dGlvbgoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0CgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1k ZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=