From: "christophe barbé" <christophe.barbe@lineo.fr>
To: Andi Kleen <ak@suse.de>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: sk_buff destructor in 2.2.18
Date: Wed, 23 May 2001 17:02:15 +0200 [thread overview]
Message-ID: <20010523170215.C8075@pc8.lineo.fr> (raw)
In-Reply-To: <20010523161654.C7531@pc8.lineo.fr> <20010523162739.A24463@gruyere.muc.suse.de> <20010523163758.C7823@pc8.lineo.fr> <20010523164036.A24809@gruyere.muc.suse.de> <20010523165028.A7917@pc8.lineo.fr> <20010523165557.A25277@gruyere.muc.suse.de>
In-Reply-To: <20010523165557.A25277@gruyere.muc.suse.de>; from ak@suse.de on Wed, May 23, 2001 at 16:55:57 +0200
I believe you and It's sure that I have not tested all cases.
So do you see a way to use a private data buffer ?
Christophe
On Wed, 23 May 2001 16:55:57 Andi Kleen wrote:
> On Wed, May 23, 2001 at 04:50:28PM +0200, christophe barbé wrote:
> > I don't know about socket but I allocate myself the skbuff and I set
> the
> > destructor (and previously the pointer value is NULL). So I don't
> overwrite
> > a destructor.
>
> That just means you didn't test all cases; e.g. not TCP or UDP
> send/receive.
>
>
>
> >
> > I believe net/core/sock.c is not involved in my problem but I can be
> wrong.
> > What is worrying me is that I don't know who clones my skbuff and why.
>
> skbuffs are cloned all over the stack for various reasons.
>
>
> > To said everything, I know who clones my skbuff because it causes a
> oops
> > when it tries to free my buffer If I use my destructor.
>
> Because you're mistakely using a private field.
>
>
> -Andi
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel"
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
Christophe Barbé
Software Engineer - christophe.barbe@lineo.fr
Lineo France - Lineo High Availability Group
42-46, rue Médéric - 92110 Clichy - France
phone (33).1.41.40.02.12 - fax (33).1.41.40.02.01
http://www.lineo.com
next prev parent reply other threads:[~2001-05-23 15:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-23 14:16 sk_buff destructor in 2.2.18 christophe barbé
2001-05-23 14:27 ` Andi Kleen
2001-05-23 14:37 ` christophe barbé
2001-05-23 14:40 ` Andi Kleen
2001-05-23 14:50 ` christophe barbé
2001-05-23 14:55 ` Andi Kleen
2001-05-23 15:02 ` christophe barbé [this message]
2001-05-23 15:08 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010523170215.C8075@pc8.lineo.fr \
--to=christophe.barbe@lineo.fr \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.